hg: jdk8/tl/jdk: 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method; ...

2011-08-18 Thread weijun . wang
Changeset: 55952703809f Author:weijun Date: 2011-08-19 13:42 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55952703809f 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuth

Re: Request Review for small change to remove 2 warnings in rmic

2011-08-18 Thread Sebastian Sickelmann
Am 18.08.2011 16:11, schrieb Alan Bateman: Mandy Chung wrote: Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? Mandy I think it's best to separate this fix and so I've created the following to track it: 7080622: Remove varargs warn

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread Mike Duigou
I will echo Joe's comments about putting the "|" at the end of the line rather than at the beginning of the next line. Not a comment on your patch but some of the use of raw RuntimeException is rather weak. I saw a few cases where IllegalStateException or UnsupportedOperationException would be

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread joe . darcy
On 8/18/2011 1:14 PM, Alan Bateman wrote: Sebastian Sickelmann wrote: Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as th

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread Alan Bateman
Sebastian Sickelmann wrote: Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as the patches there. http://oss-patches.24.eu/op

Re: Request for Review: Chain more Exceptions (RuntimeException)

2011-08-18 Thread Dr Andrew John Hughes
On 07:01 Thu 18 Aug , Sebastian Sickelmann wrote: > Hi, > > i have created a fix for fixing Exception-Chains in case of an rethrown > RuntimeException. > > I am not quite sure if this is inside the scope of what i > discussed[0][1] with Joe. But it is > fixed in the same manner as the patch

hg: jdk8/tl/jdk: 7015589: (spec) BufferedWriter.close leaves stream open if close of underlying Writer fails

2011-08-18 Thread alan . bateman
Changeset: 759aa847dcaf Author:alanb Date: 2011-08-18 16:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/759aa847dcaf 7015589: (spec) BufferedWriter.close leaves stream open if close of underlying Writer fails Reviewed-by: forax, mduigou ! src/share/classes/java/io/Buffer

Re: Request Review for small change to remove 2 warnings in rmic

2011-08-18 Thread Mandy Chung
On 8/17/11 9:46 PM, Sebastian Sickelmann wrote: Are you going to include this change with another CR that you have a fix to be pushed? Is the CR to small, or what is the reason for your question? I was just curious which CR this change is going into since it's not mentioned in your email.

Fwd: Re: Request Review for small change to remove 2 warnings in rmic

2011-08-18 Thread Sebastian Sickelmann
Sorry. Does't Poster it to the list Original-Nachricht Betreff: Re: Request Review for small change to remove 2 warnings in rmic Von: Sebastian Sickelmann An: Alan Bateman CC: I updated my Patch so that it handles all varargs warnings in jdk subrepo. http://oss-patches.24.

Re: Request Review for small change to remove 2 warnings in rmic

2011-08-18 Thread Alan Bateman
Mandy Chung wrote: Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? Mandy I think it's best to separate this fix and so I've created the following to track it: 7080622: Remove varargs warnings from rmic -Alan.

Re: Two heads after pull of tl/jdk and jdk8/jdk

2011-08-18 Thread Weijun Wang
On 08/18/2011 05:04 PM, Charles Lee wrote: On 08/18/2011 03:23 AM, Sebastian Sickelmann wrote: Hi, after pulling from both sources http://hg.openjdk.java.net/jdk8/tl/jdk/ http://hg.openjdk.java.net/jdk8/jdk8/jdk/ i see that i got two heads. Is it because in all the other repositorys jdk8/*/

Re: Two heads after pull of tl/jdk and jdk8/jdk

2011-08-18 Thread Charles Lee
On 08/18/2011 03:23 AM, Sebastian Sickelmann wrote: Hi, after pulling from both sources http://hg.openjdk.java.net/jdk8/tl/jdk/ http://hg.openjdk.java.net/jdk8/jdk8/jdk/ i see that i got two heads. Is it because in all the other repositorys jdk8/*/jdk there are also many changes to the jdk-su