Sean,
The changes look good, though I haven't gone through the test in much
detail!
One question that is not directly related to your changes, but may be
applicable.
Shouldn't the close on FileChannel also check the value of the use count
before closing the native fd? For example:
Seán Coffey wrote:
http://bugs.sun.com/view_bug.do?bug_id=7082769
webrev : http://cr.openjdk.java.net/~coffeys/webrev.7082769.7087019.jdk8/
Bug fix where we ensure that the fd object is not disposed of until
all streams are closed out.
Testcase is a bulked up version of CR 6322678 (which
John,
This test fails in the jdk8/tl because javac now defaults to
source/target 8 and the test specifies -target 7 without specifying the
source. This means we can run the java/lang/** tests without getting at
least one failure. Any objection if I add -source 7 to the compile tag?
I assume
Good points Alan.
Coding styles probably differ from merging two testcases together. I'll
clean up on the issues mentioned and send out the new webrev shortly.
I thought about try with resources in a few places but it didn't always
suit. Take for example the TestMultipleFD() method. The
Hello.
In langtools, our policy is *not* to have explicit -source or -target
flags in the regression tests unless a non-default older source/target
is needed. Unnecessary options have been removed from both langtools
and jdk. [1] [2]
So, I recommend the compile line for this test just be
Changeset: e8eee45e1ca5
Author:michaelm
Date: 2011-09-09 14:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8eee45e1ca5
7085981: XXSocket types depend on impl finalizer to close if constructor throws
exception
Reviewed-by: alanb, chegar
!
Changeset: e995c36bb1eb
Author:michaelm
Date: 2011-09-09 15:24 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e995c36bb1eb
7088747: Use multicatch in Socket constructor
Reviewed-by: alanb
! src/share/classes/java/net/Socket.java
On Sep 9, 2011, at 6:24 AM, Joe Darcy wrote:
So, I recommend the compile line for this test just be
@compile InvokeGenericTest.java
I agree. Thanks, Joe.
-- John
John Rose wrote:
On Sep 9, 2011, at 6:24 AM, Joe Darcy wrote:
So, I recommend the compile line for this test just be
@compile InvokeGenericTest.java
I agree. Thanks, Joe.
-- John
Thanks Joe, thanks John. I'll get this done as this test failure has
been annoying me.
-Alan
Changeset: 1ee9f9a91e9c
Author:jjg
Date: 2011-09-09 17:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ee9f9a91e9c
7073508: Regression: NullPointerException at
com.sun.tools.javac.code.Lint$AugmentVisitor.augment
Reviewed-by: darcy
!
10 matches
Mail list logo