Doh,
This time with the patches, test code, and CPU usage stats attached
Regard
Mike
From: Alan Bateman alan.bate...@oracle.com
To: mike.ske...@talk21.com
Cc: Core-Libs-Dev core-libs-dev@openjdk.java.net
Sent: Monday, 10 October 2011, 0:15
Subject: Re: Patch
The patch (.patch) and results (.xlsx) seem to be filtered out. What is the
best format to submit files to avoid list filtering attachments?
From: Mike Skells mike.ske...@talk21.com
To: Alan Bateman alan.bate...@oracle.com
Cc: Core-Libs-Dev
Changeset: 1e89a13d9d8f
Author:chegar
Date: 2011-10-10 10:38 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e89a13d9d8f
7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work
correctly with System.gc()
Reviewed-by: michaelm
!
Approved
Maurizio
On 07/10/11 16:00, Chris Hegarty wrote:
Since the integration of the fix for CR 7094141, it has come to light
that the test should be using the supported compiler interface,
com.sun.tools.javac.Main. CR 7094141 was a little rushed so that the
failing test would not
On Mon, 2011-10-10 at 13:58 +0100, Steve Poole wrote:
hi all,
Please find attached a trivial patch to remove an unused variable in
jdk/src/solaris/bin/java_md.c
The present of the variable causes the AIX build to fail since Dl_info
is not supported on AIX.The other use of Dl_info in
Thumbs up from me too.
-Chris.
On 10/10/2011 05:44, David Holmes wrote:
On 10/10/2011 1:35 PM, Naoto Sato wrote:
Hi David,
Thank you for your review. availableJRELocales is already declared with
volatile keyword in the current source, so no change is involved.
Sorry - my mistake. I misread
Naoto,
Forgot to add, you can probably just push the changes for the test along
with your source changes. I modified it a little since last review.
Reproduces one in about every ten times on one of our Dual core Linux
x64 boxes.
: hg diff Bug6989440.java
diff -r 1e89a13d9d8f
This patch looks fine to me.
Have you been working with anyone to get your contributions pushed in?
-kto
On Oct 10, 2011, at 2:58 PM, Steve Poole wrote:
hi all,
Please find attached a trivial patch to remove an unused variable in
jdk/src/solaris/bin/java_md.c
The present of the
Changeset: 2a36b8741363
Author:chegar
Date: 2011-10-10 15:29 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a36b8741363
7098755: test/sun/misc/JarIndex/metaInfFilenames/Basic.java should use
supported compiler interface
Reviewed-by: mcimadamore
!
On Mon, 2011-10-10 at 16:27 +0200, Kelly O'Hair wrote:
This patch looks fine to me.
Have you been working with anyone to get your contributions pushed in?
-kto
Hi Kelly,
I've been looking for something with which to test my untold *powers* as
a committer, so can I swipe this one to work
Here is your CR, so use this as the first line in the changeset comment:
7099119: Remove unused dlinfo local variable in launcher code
Line 2 should be:
Reviewed-by: ohair, chegar
Line 3 should be:
Contributed-by: Steve Poole spo...@linux.vnet.ibm.com
I think it is ok to push this into the
Chris Hegarty wrote:
Naoto,
Forgot to add, you can probably just push the changes for the test
along with your source changes. I modified it a little since last
review. Reproduces one in about every ten times on one of our Dual
core Linux x64 boxes.
Is it the CME that duplicates for you? I'm
Approved.
Kumar
hi all,
Please find attached a trivial patch to remove an unused variable in
jdk/src/solaris/bin/java_md.c
The present of the variable causes the AIX build to fail since Dl_info
is not supported on AIX.The other use of Dl_info in the file is
safely wrapped with an #if
Changeset: dd55467dd1f2
Author:ngmr
Date: 2011-10-10 14:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2
7099119: Remove unused dlinfo local variable in launcher code
Reviewed-by: ohair, chegar, ngmr
Contributed-by: Steve Poole spo...@linux.vnet.ibm.com
!
On 10/10/2011 15:52, Alan Bateman wrote:
Chris Hegarty wrote:
Naoto,
Forgot to add, you can probably just push the changes for the test
along with your source changes. I modified it a little since last
review. Reproduces one in about every ten times on one of our Dual
core Linux x64 boxes.
Is
Thanks, Chris. Will do it after confirming all's well with the JPRT
(currently it's down).
Naoto
On 10/10/11 7:27 AM, Chris Hegarty wrote:
Naoto,
Forgot to add, you can probably just push the changes for the test along
with your source changes. I modified it a little since last review.
Hi All,
Trying to request a review again with different file types
hopefully it will get through the filter
Regards
Mike
From: Mike Skells mike.ske...@talk21.com
To: Mike Skells mike.ske...@talk21.com; Alan Bateman
alan.bate...@oracle.com
Cc: Core-Libs-Dev
Hi All,
Last attempt - hopefully
with all 3 files, a patch, test case and results. The patch and results are
text format to avoid the filters on this list
Hopefully you are not all to irritated with this posting to review it :-)
Regards
Mike
From: Mike Skells
So the jtreg uncaughtException code is doing a join() on the target
Thread while holding the monitor lock of the ThreadGroup - ouch! Where
do we file jtreg bugs?
David
On 11/10/2011 1:44 AM, Chris Hegarty wrote:
On 10/10/2011 15:52, Alan Bateman wrote:
Chris Hegarty wrote:
Naoto,
Forgot
Hi Mike,
I have one question. In part the existing code tends to use a single
println with multiple string concatenations. Your changes optimize the
string operations by using explicit, rather than implicit
StringBuilders. Did you consider instead/aso using multiple print
statmements top
Hi David,
In my opinion, this could be even written in this ways:
for (StackTraceElement traceElement : trace)
s.append(\tat ).println(traceElement);
and Similarly for:
for (int i = 0; i = m; i++)
s.append(prefix).append(\tat ).println(trace[i]);
and the change
21 matches
Mail list logo
