Re: Race condition in ThreadGroup stop test

2011-11-08 Thread Chris Hegarty
On 11/ 7/11 10:45 PM, David Holmes wrote: On 8/11/2011 6:50 AM, Brian Goetz wrote: Wait/notify may be better than sleeping, but semaphore/latch/barrier are much better than wait/notify. Much. Don't be hasty. This test is using Thread.stop - which as we all know is a Very Bad Thing. You want

Re: Race condition in ThreadGroup stop test

2011-11-08 Thread Gary Adams
Let's see if this captures all the comments and is a bit more robust in the face of the original race conditions mentioned. - threads are started before they are recorded in local variables - second is now volatile - stop thread group is triggered by first thread once second thread

Re: Race condition in ThreadGroup stop test

2011-11-08 Thread RĂ©mi Forax
On 11/08/2011 02:12 PM, Gary Adams wrote: Let's see if this captures all the comments and is a bit more robust in the face of the original race conditions mentioned. - threads are started before they are recorded in local variables - second is now volatile - stop thread group is

Re: Who is on Dedoxx?

2011-11-08 Thread Dalibor Topic
On 11/8/11 7:40 PM, Ulf Zibis wrote: Can one explain me what BOF stands for? https://secure.wikimedia.org/wikipedia/en/wiki/Birds_of_a_Feather_%28computing%29 cheers, dalibor topic -- Oracle http://www.oracle.com Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 |

hg: jdk8/tl/langtools: 6921494: provide way to print javac tree tag values

2011-11-08 Thread jonathan . gibbons
Changeset: ca49d50318dc Author:jjg Date: 2011-11-08 11:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ca49d50318dc 6921494: provide way to print javac tree tag values Reviewed-by: jjg, mcimadamore Contributed-by: vicent...@yahoo.es !

Re: Garbage collection race condition before final checks

2011-11-08 Thread Mandy Chung
Gary, Thanks for picking up this bug and fixing this intermittent issue. PlatformLoggingMXBeanTest.java in the same directory has the same issue. It'd be good to fix that with the same CR. These tests were copied from test/java/util/logging/LoggingMXBeanTest.java. I haven't looked in

hg: jdk8/tl/jdk: 7109096: keytool -genkeypair needn't call -selfcert

2011-11-08 Thread weijun . wang
Changeset: 52be75d060f9 Author:weijun Date: 2011-11-09 15:51 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52be75d060f9 7109096: keytool -genkeypair needn't call -selfcert Reviewed-by: xuelei ! src/share/classes/sun/security/tools/CertAndKeyGen.java !