Re: CR 6860309 - solaris timing issue on thread startup

2011-11-14 Thread Alan Bateman
On 14/11/2011 00:42, David Holmes wrote: Will the exec'd process block until the copier threads read from its output streams? If not then the copier threads (well stdin anyway) could read their input and have terminated before the main thread even reaches the original sleep() call. I don't

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-14 Thread Jonathan Lu
Hi Kurt, On 11/10/2011 11:09 AM, Kurt Miller wrote: On 11/09/11 03:01, Jonathan Lu wrote: On 11/04/2011 01:26 PM, David Holmes wrote: On 4/11/2011 2:53 PM, David Holmes wrote: On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10 and

hg: jdk8/tl/jdk: 7111548: unexpected debug log message

2011-11-14 Thread xuelei . fan
Changeset: 5c7c83a6ee24 Author:xuelei Date: 2011-11-14 01:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7c83a6ee24 7111548: unexpected debug log message Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLSocketImpl.java

hg: jdk8/tl/jdk: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself

2011-11-14 Thread chris . hegarty
Changeset: 68fc55d12ae6 Author:chegar Date: 2011-11-14 10:06 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68fc55d12ae6 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.ha...@oracle.com !

Re: Code Review Request for 6578042

2011-11-14 Thread Neil Richards
On Mon, 2011-11-14 at 10:28 +1000, David Holmes wrote: On 12/11/2011 10:14 PM, Alan Bateman wrote: On 11/11/2011 19:37, Darryl Mocek wrote: Returning null if the value is not a String gives the impression that there was no property with that key when the property may have been there and

Re: Code Review Request for 6578042

2011-11-14 Thread Alan Bateman
On 14/11/2011 13:19, Neil Richards wrote: : Of course, there are certain situations where the Java documentation guides you to specify property values which are not String objects. One that springs to my mind is the setting of java.naming.corba.orb to point to the ORB instance to be used by

hg: jdk8/tl/langtools: 7110974: (javac) add coding conventions and style checkers for langtools

2011-11-14 Thread kumar . x . srinivasan
Changeset: c1238fcc9515 Author:ksrini Date: 2011-11-14 08:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c1238fcc9515 7110974: (javac) add coding conventions and style checkers for langtools Reviewed-by: jjg ! make/build.properties ! make/build.xml +

Re: CR 6860309 - solaris timing issue on thread startup

2011-11-14 Thread RĂ©mi Forax
On 11/14/2011 05:09 PM, Gary Adams wrote: I've updated the webrev for CR#6860309 using a CountDownLatch. The main thread will wait til both worker threads are ready to block on the read() before the process is destroyed. http://cr.openjdk.java.net/~gadams/6860309/ Tested with -Xcomp, but

Re: CR 6860309 - solaris timing issue on thread startup

2011-11-14 Thread Gary Adams
Updated to move static latch to Copier constructor argument. On 11/14/11 11:09 AM, Gary Adams wrote: I've updated the webrev for CR#6860309 using a CountDownLatch. The main thread will wait til both worker threads are ready to block on the read() before the process is destroyed.

hg: jdk8/tl/langtools: 7106166: (javac) re-factor EndPos parser

2011-11-14 Thread kumar . x . srinivasan
Changeset: 7375d4979bd3 Author:ksrini Date: 2011-11-14 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7375d4979bd3 7106166: (javac) re-factor EndPos parser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java !

Re: CR 6860309 - solaris timing issue on thread startup

2011-11-14 Thread David Holmes
On 14/11/2011 6:05 PM, Alan Bateman wrote: The test runs cat without any arguments so the Copier threads will block when they read from the stream. Thank's Alan that critical point had escaped my notice. David If we can get the main thread to wait until the Copier threads are just about to