On 30/11/2011 01:31, Dr Andrew John Hughes wrote:
On 10:23 Tue 29 Nov , Alan Bateman wrote:
snip...
When we talked about the zlib version here (I think back in February) we
talked about having the option to use the system's zip library where
appropriate. Have you given this any thought
On 30/11/2011 7:43 PM, Alan Bateman wrote:
On 30/11/2011 01:31, Dr Andrew John Hughes wrote:
On 10:23 Tue 29 Nov , Alan Bateman wrote:
snip...
When we talked about the zlib version here (I think back in February) we
talked about having the option to use the system's zip library where
On 29/11/2011 23:01, Stuart Marks wrote:
On 11/29/11 8:10 AM, Alan Bateman wrote:
:
http://cr.openjdk.java.net/~alanb/7116404/webrev/
Wow, you're getting a jump on us! Any idea how many warnings this
cleared up? Looks like dozens.
110, so not too many. There is still plenty of low hanging
On 11/30/2011 11:00 AM, Alan Bateman wrote:
On 29/11/2011 23:01, Stuart Marks wrote:
On 11/29/11 8:10 AM, Alan Bateman wrote:
:
http://cr.openjdk.java.net/~alanb/7116404/webrev/
Wow, you're getting a jump on us! Any idea how many warnings this
cleared up? Looks like dozens.
110, so not too
Changeset: 4749df4f04f1
Author:alanb
Date: 2011-11-30 10:57 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4749df4f04f1
7030624: size_t usages in src/windows/native/java/io/io_util_md.c need to be
re-visited
Reviewed-by: lancea, chegar
! src/share/native/java/io/io_util.c
On 30/11/2011 15:06, Rémi Forax wrote:
Note that you can use clazz.asSubclass(Enum.class) instead of casting
to the raw type Class,
you will still have a warning but you will be not the one that have
introduced a raw type :)
Your mail arrived just a few minutes after I did the hg push. The
I started to look at the reason why we suppressed unchecked warning for
sun.misc.Service in a few places, and this lead me into some other
sun.misc classes. Here's a change that fixes a few warnings in this area.
http://cr.openjdk.java.net/~chegar/7116722/webrev.00/webrev/
-Chris.
On 30/11/2011 16:33, Chris Hegarty wrote:
I started to look at the reason why we suppressed unchecked warning
for sun.misc.Service in a few places, and this lead me into some other
sun.misc classes. Here's a change that fixes a few warnings in this area.
On 11/30/2011 8:56 AM, Alan Bateman wrote:
On 30/11/2011 16:33, Chris Hegarty wrote:
I started to look at the reason why we suppressed unchecked warning
for sun.misc.Service in a few places, and this lead me into some
other sun.misc classes. Here's a change that fixes a few warnings in
this
On 30/11/2011 17:04, Joe Darcy wrote:
public JarIndex() {
- indexMap = new HashMap();
- jarMap = new HashMap();
+ indexMap = new HashMapString,LinkedListString();
+ jarMap = new HashMapString,LinkedListString();
jarMap = new HashMapString,LinkedHashSetString();
or similar might be
On 11/21/2011 3:58 PM, David Holmes wrote:
On 22/11/2011 4:29 AM, Brandon Passanisi wrote:
Thank you for the review David. I'll make the changes to the test
program as you have suggested and I will also update the bug report with
the comments you have given. I'll then send out an updated
Hi Chris,
Do you want to use diamond reference on lines 81, 82 of jarindex.java?
In Signal.java, line 203, i do not think you need new Integer() any longer?
Other than that it looks good
Best
Lance
On Nov 30, 2011, at 11:33 AM, Chris Hegarty wrote:
I started to look at the reason why we
On 11/30/11 10:43 AM, Lance Andersen - Oracle wrote:
Hi Stuart,
Thanks for the feedback.
Great, thanks for the updates. Further comments below.
* In CachedRowSetWriter.java, cols is changed from Vector to VectorInteger.
This is fine but there's now a redundant cast (Integer)cols.get(i) at
Changeset: 43a630f11af6
Author:smarks
Date: 2011-11-30 13:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6
7116322: enhance javac make rule with a little bit of instrumentation
Reviewed-by: dholmes, ohair
! make/common/Rules.gmk
Brandon,
Are there any opinions on this from other Collections experts?
http://cr.openjdk.java.net/~mduigou/4802647/0/webrev/
Shouldn't the test include all collections included with the JDK? Any override
of these methods could repeat the same (bad) behavior.
Jason
Hello. Please review this patch to fix the getting of the user's home
setting using System.getProperty(user.home) on UNIX's. The previous
implementation used getpwuid, which didn't allow the user to set the
value in the environment.
Webrev, can be found here:
On 1/12/2011 9:23 AM, Xueming Shen wrote:
(1) you might need to consider the use scenario of an unset HOME env
(2) it appears to be an in-compatible change if the values from getpwuid
and
from HOME are different (understood this is what you want to address),
in which
I think might need a CCC
looks OK to me
On Nov 30, 2011, at 5:34 PM, chris hegarty wrote:
Thanks for all the feedback.
changes:
- use diamond in JarIndex (style issue)
- sun.misc.Service - java.util.ServiceLoader
in InetAddress and HttpServerProvider
- ExtensionDependency: suppress unchecked on
18 matches
Mail list logo
