hg: jdk8/tl/jdk: 21 new changesets

Changeset: 4196fc971f65 Author:katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4196fc971f65 Added tag jdk8-b26 for changeset 5aca406e87cb ! .hgtags Changeset: 7a5c8c6f1c6b Author:prr Date: 2012-02-03 09:57 -0800 URL: http://hg.o

hg: jdk8/tl/hotspot: 69 new changesets

Changeset: 3c4621be5149 Author:amurillo Date: 2012-02-06 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c4621be5149 7143122: new hotspot build - hs23-b15 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 869be5c8882e Author:phh Date: 2012-02-03 17:2

hg: jdk8/tl/jaxp: Added tag jdk8-b26 for changeset dbb7283c197b

Changeset: 80c47eb83d24 Author:katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/80c47eb83d24 Added tag jdk8-b26 for changeset dbb7283c197b ! .hgtags

hg: jdk8/tl/corba: Added tag jdk8-b26 for changeset 79f709a099f4

Changeset: 4fffe75e4edd Author:katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4fffe75e4edd Added tag jdk8-b26 for changeset 79f709a099f4 ! .hgtags

hg: jdk8/tl/langtools: 3 new changesets

Changeset: fba3cbee0fa3 Author:katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fba3cbee0fa3 Added tag jdk8-b26 for changeset b556aa8a99c3 ! .hgtags Changeset: e127334a64fe Author:darcy Date: 2012-02-17 15:24 -0800 URL: htt

hg: jdk8/tl: Added tag jdk8-b26 for changeset 2accafff224a

Changeset: 1533dfab9903 Author:katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1533dfab9903 Added tag jdk8-b26 for changeset 2accafff224a ! .hgtags

hg: jdk8/tl/jaxws: 2 new changesets

Changeset: 329ace7198ac Author:katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/329ace7198ac Added tag jdk8-b26 for changeset 3518639eab6c ! .hgtags Changeset: 38c037af4127 Author:lana Date: 2012-02-18 16:09 -0800 URL: http://h

Re: RFR : 7144488 StackOverflowError occurres on list via Collections.synchronizedList(List)

On 23/02/2012 12:22 AM, Alan Bateman wrote: On 22/02/2012 13:25, Seán Coffey wrote: Bug recently reported. We enter infinite recursion on a boundary case for Collections.synchronizedList.remove(..) Fix is a simple equals check in class method before delegating the call. bug : http://bugs.sun.c

Re: Code review request: 7146763: Warnings cleanup in the sun.rmi and related packages

Hi Remi, Thanks for your review. Please see my comment: On 2/22/2012 10:01 AM, Rémi Forax wrote: Hi Kurchi, hi all, in ReliableLog, you can get ride of the @SupressWarnings, getLogClassConstructor should return a Constructor and not a Constructor, the field logClassConstructor should be ty

Re: Code review request: 7146763: Warnings cleanup in the sun.rmi and related packages

Hi Kurchi, overall the changes look good. I have a few comments: - TCPTransport: Lines #552/553: I actually prefer the way it was as I think it's more readable. - RMIMasterSocketFactory: Line #244: The comment was removed, was there a reason for this? - HttpInputStream: Line #73: Why even

Re: Code review request: 7146763: Warnings cleanup in the sun.rmi and related packages

Hi Kurchi, hi all, in ReliableLog, you can get ride of the @SupressWarnings, getLogClassConstructor should return a Constructor and not a Constructor, the field logClassConstructor should be typed Constructor and in openLogFile, the log should be constructed like this log = (logClassConstructo

Re: Code review request: 6282196 There should be Math.mod(number, modulo) methods

Thanks for the explanation, I don't think that the change in floorDiv behaviour will cause JSR-310 a problem Stephen On 22 February 2012 16:21, Roger Riggs wrote: > > On 02/22/2012 09:37 AM, Stephen Colebourne wrote: > > Can you explain why the mod implementation differs from that in JSR-310? > h

Re: Code review request: 6282196 There should be Math.mod(number, modulo) methods

On 02/22/2012 09:37 AM, Stephen Colebourne wrote: Can you explain why the mod implementation differs from that in JSR-310? https://github.com/ThreeTen/threeten/blob/master/src/main/java/javax/time/MathUtils.java#L401 The code ((a % b) + b) % b; is short and involves no branches, which should a

Re: RFR : 7144488 StackOverflowError occurres on list via Collections.synchronizedList(List)

Yes, I stumbled across another few issues in the Collections class while looking to expand the testcase for this one. Below are other such cases. Various hashCode methods lead to recursive calls and this has been discussed in the past. It's also mentioned in the javadocs (albeit somewhat vague

Re: Code review request: 6282196 There should be Math.mod(number, modulo) methods

Can you explain why the mod implementation differs from that in JSR-310? https://github.com/ThreeTen/threeten/blob/master/src/main/java/javax/time/MathUtils.java#L401 The code ((a % b) + b) % b; is short and involves no branches, which should aid performance and inlining. Is this to do with accep

Code review request: 6282196 There should be Math.mod(number, modulo) methods

Hi, 6282196 There should be Math.mod(number, modulo) methods Requests that floor and modulus methods be provided for primitive types. Floor division is pretty straight-forward, rounding toward minus infinity. For modulus of int and l

Re: RFR : 7144488 StackOverflowError occurres on list via Collections.synchronizedList(List)

On 22/02/2012 13:25, Seán Coffey wrote: Bug recently reported. We enter infinite recursion on a boundary case for Collections.synchronizedList.remove(..) Fix is a simple equals check in class method before delegating the call. bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144488 we

RFR : 7144488 StackOverflowError occurres on list via Collections.synchronizedList(List)

Bug recently reported. We enter infinite recursion on a boundary case for Collections.synchronizedList.remove(..) Fix is a simple equals check in class method before delegating the call. bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144488 webrev : http://cr.openjdk.java.net/~coffey

Re: Code review request: 7146763: Warnings cleanup in the sun.rmi and related packages

Kurchi, Great work. I've been through the complete webrev and I think it looks good. Just a few minor comments: - there are API changes, but only in sun private implementation classes, so this should be fine. - Minor indentation nit where method declaration return type was generified.