7152866: Tests not run because they are missing the @run tag

2012-03-11 Thread Alan Bateman
I was looking at a test and happen to notice that it had a @build tag but no @run tag so the test wasn't actually running as expected (it wasn't a compile-only test). This prompted me to do a quick audit and I found several other tests with similar issues. The following webrev fixes the test

Re: 7152866: Tests not run because they are missing the @run tag

2012-03-11 Thread Brian Goetz
I would think scanning for test files that have a main() method but not a @run tag would be a good way to find more of these... On Mar 11, 2012, at 4:21 AM, Alan Bateman wrote: I was looking at a test and happen to notice that it had a @build tag but no @run tag so the test wasn't actually

Re: 7152866: Tests not run because they are missing the @run tag

2012-03-11 Thread Alan Bateman
On 11/03/2012 17:06, Brian Goetz wrote: I would think scanning for test files that have a main() method but not a @run tag would be a good way to find more of these... We definitely should setup a script or something to catch these issues automatically, just need to work out what the pattern.

Re: 7152866: Tests not run because they are missing the @run tag

2012-03-11 Thread David Holmes
Hi Alan, On 11/03/2012 9:21 PM, Alan Bateman wrote: I was looking at a test and happen to notice that it had a @build tag but no @run tag so the test wasn't actually running as expected (it wasn't a compile-only test). This prompted me to do a quick audit and I found several other tests with

Re: 7152866: Tests not run because they are missing the @run tag

2012-03-11 Thread chris hegarty
On 11/03/2012 20:15, David Holmes wrote: Hi Alan, On 11/03/2012 9:21 PM, Alan Bateman wrote: I was looking at a test and happen to notice that it had a @build tag but no @run tag so the test wasn't actually running as expected (it wasn't a compile-only test). This prompted me to do a quick

Re: 7152866: Tests not run because they are missing the @run tag

2012-03-11 Thread David Holmes
On 12/03/2012 8:12 AM, chris hegarty wrote: On 11/03/2012 20:15, David Holmes wrote: On 11/03/2012 9:21 PM, Alan Bateman wrote: I was looking at a test and happen to notice that it had a @build tag but no @run tag so the test wasn't actually running as expected (it wasn't a compile-only test).

Re: Suggestion about including pthread.h

2012-03-11 Thread Shi Jun Zhang
On 3/9/2012 6:05 PM, David Holmes wrote: On 9/03/2012 7:04 PM, Alan Bateman wrote: On 09/03/2012 08:01, Shi Jun Zhang wrote: The situation in NativeThread.c is more complicated than other 2 files. I'm not familiar with BSD or Mac. It seems that we don't need to signal threads on BSD or Mac.