hg: jdk8/tl/jdk: 7152176: More krb5 tests

2012-03-20 Thread weijun . wang
Changeset: 0d1c576980a0 Author:weijun Date: 2012-03-20 19:12 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d1c576980a0 7152176: More krb5 tests Reviewed-by: xuelei + test/sun/security/krb5/auto/Basic.java ! test/sun/security/krb5/auto/Context.java +

Re: RFR (7u4) 7150637: No newline emitted after XML decl in XSLT output

2012-03-20 Thread Lance Andersen - Oracle
Hi Joe, This looks Ok, a couple of minor comments: - SerializationHandler.java could use a comment before the method setIsStandalone(). - ToXMLStream.java seems to have a typo in the comment /** 331 * Before Xalan 1497, a newline char was printed out if not inside of an

hg: jdk8/tl/jdk: 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11

2012-03-20 Thread valerie . peng
Changeset: 4c4d2337dfad Author:valeriep Date: 2012-03-20 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c4d2337dfad 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11 Summary: Always return the secret in the same

Re: RFR: 7155300 Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-20 Thread Shi Jun Zhang
On 3/12/2012 11:28 AM, Shi Jun Zhang wrote: On 3/9/2012 6:05 PM, David Holmes wrote: On 9/03/2012 7:04 PM, Alan Bateman wrote: On 09/03/2012 08:01, Shi Jun Zhang wrote: The situation in NativeThread.c is more complicated than other 2 files. I'm not familiar with BSD or Mac. It seems that we

Re: RFR (7u4) 7150637: No newline emitted after XML decl in XSLT output

2012-03-20 Thread Joe Wang
Thanks Lance! On 3/20/2012 2:44 PM, Lance Andersen - Oracle wrote: Hi Joe, This looks Ok, a couple of minor comments: - SerializationHandler.java could use a comment before the method setIsStandalone(). Added the following comment: /** * Specify if the output will be treated as a

Re: RFR: 7155300 Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-20 Thread Alan Bateman
On 21/03/2012 02:47, Shi Jun Zhang wrote: Hi Alan/David, There is no response on this thread for long time. I created a sun bug 7155300, could you help to review it? The webrev link is http://cr.openjdk.java.net/~zhangshj/pthread/webrev.02/ Looks okay to me. -Alan