Hi,
These changes cleanup warnings in java.util.* and were contributed by
Remi Forax ([email protected]).
Specifically the files that I merged/had conflicts are:
src/share/classes/java/util/Currency.java
src/share/classes/java/util/EnumMap.java
src/share/classes/java/util/PropertyPermissio
Jim's and Remi's comments on the problem are correct.
In the current design, MH.type values must be interned. Comments on this
design decision are interesting and useful, but this is not new ground; we went
over it during the JDK 7 engineering and spec. work. It is likely we will
revisit this
On 3/29/12 4:25 AM, Michael McMahon wrote:
On 27/03/12 22:23, Michael McMahon wrote:
Could I get the following webrev for 7u4 reviewed please?
It is the same code change as for jdk 8
http://cr.openjdk.java.net/~michaelm/7134701/webrev.7u4.1/
Thanks,
Michael.
I've updated the webrev for this
I don't see anything precluding == equality check. MethodType is the key,
it implements equals() via ==. In order to look it up in the data
structure you need to have a reference to one of these instances already,
correct? So if you have a reference to it, call containsKey() using it and
get true
No set that I know of allows you to get the key - you can check for its
presence or remove it. Since containsKey() requires that you pass it the
key to find, there's nothing to return since you already have an equivalent
key (although possibly different instance). If that's not the intent of
Weak
Looks good to me.
PS. Remi notes that only constructor and "add" method of WeakInternSet
are accessed from the containing class. The rest can be made private.
-Sundar
John Rose wrote:
Thanks, Jim.
-- John (on my iPhone T-1000)
On Mar 28, 2012, at 6:01 PM, Jim Laskey wrote:
The Weak
On 27/03/12 22:23, Michael McMahon wrote:
Could I get the following webrev for 7u4 reviewed please?
It is the same code change as for jdk 8
http://cr.openjdk.java.net/~michaelm/7134701/webrev.7u4.1/
Thanks,
Michael.
I've updated the webrev for this 7u4 change, based on the testing yesterday.
Changeset: b2687ac9cffb
Author:peytoia
Date: 2012-03-29 18:02 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2687ac9cffb
7070436: Support Unicode 6.1.0 in JDK 8
Reviewed-by: okutsu
! make/tools/GenerateCharacter/CharacterData00.java.template
! make/tools/UnicodeData/PropLis
