Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-04-09 Thread Charles Lee
Hi Sean, The the patch has been committed @ Changeset: e06ea0dd9207 Author:littlee Date: 2012-04-10 10:17 +0800 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e06ea0dd9207 7121314: Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec Reviewed-by: dholmes, mduigou Con

hg: jdk8/tl/jdk: 7158329: NPE in sun.security.krb5.Credentials.acquireDefaultCreds()

2012-04-09 Thread weijun . wang
Changeset: 1ffe2565ec06 Author:weijun Date: 2012-04-10 12:15 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ffe2565ec06 7158329: NPE in sun.security.krb5.Credentials.acquireDefaultCreds() Reviewed-by: valeriep, jjg ! src/share/classes/sun/security/krb5/Credentials.java + te

hg: jdk8/tl/jdk: 7121314: Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-04-09 Thread littlee
Changeset: e06ea0dd9207 Author:littlee Date: 2012-04-10 10:17 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e06ea0dd9207 7121314: Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec Reviewed-by: dholmes, mduigou Contributed-by: Sean Zhou , Ulf Zibis , Da

hg: jdk8/tl/langtools: 7156633: (javac) incorrect errors when parsing variable declaration in block statements.

2012-04-09 Thread kumar . x . srinivasan
Changeset: 9c429f38ca7e Author:ksrini Date: 2012-04-09 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9c429f38ca7e 7156633: (javac) incorrect errors when parsing variable declaration in block statements. Reviewed-by: jjg Contributed-by: [email protected] ! s

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-04-09 Thread Joe Darcy
The "Contributed-by:" information has to be email addresses: http://openjdk.java.net/guide/producingChangeset.html HTH, -Joe On 04/08/2012 06:57 PM, Charles Lee wrote: Hi guys, I am trying to push the changeset to the gate, but no matter how I change the Contributed-by list, I always ge

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-09 Thread Alan Bateman
On 09/04/2012 08:53, Sean Chou wrote: Hi all, I would like to suggest to replace the static error string in ZIP_Put_In_Cache0 with on stack memory. : The modification is here: http://cr.openjdk.java.net/~zhouyx/OJDK-482/webrev.00/ . Good catch, this one had probably been there for

Re: New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-09 Thread Deven You
On 04/09/2012 05:03 PM, Alan Bateman wrote: On 09/04/2012 08:01, Deven You wrote: Hi core-libs-devs, There are 2 sun bugs related to this issue: http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6695325^and http://bugs.sun.com/view_bug.do;jsessionid=66354

Re: New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-09 Thread Alan Bateman
On 09/04/2012 08:01, Deven You wrote: Hi core-libs-devs, There are 2 sun bugs related to this issue: http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6695325^and http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=661089

Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-09 Thread Sean Chou
Hi all, I would like to suggest to replace the static error string in ZIP_Put_In_Cache0 with on stack memory. Because it takes more time to modify a string than an int typed error number, it opens a window larger than int typed error number and might bring in race in multi-thread user cases.

New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-09 Thread Deven You
Hi core-libs-devs, There are 2 sun bugs related to this issue: http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6695325^and http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6610897^ The basic problem is that the new con