hg: jdk8/tl/jdk: 17 new changesets

2012-04-10 Thread lana . steuck
Changeset: 93ca9cbc8940 Author:katleman Date: 2012-04-05 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93ca9cbc8940 Added tag jdk8-b33 for changeset 78cea258caab ! .hgtags Changeset: 100b6c2f75ba Author:rupashka Date: 2012-03-22 17:10 +0200 URL: http:/

hg: jdk8/tl: 2 new changesets

2012-04-10 Thread lana . steuck
Changeset: 06ef0b4daa4c Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/06ef0b4daa4c Added tag jdk8-b33 for changeset 42f275168fa5 ! .hgtags Changeset: 3b70add6ae45 Author:lana Date: 2012-04-09 21:55 -0700 URL: http://hg.open

hg: jdk8/tl/hotspot: 18 new changesets

2012-04-10 Thread lana . steuck
Changeset: bc8881f974b8 Author:jcoomes Date: 2012-03-23 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bc8881f974b8 7156659: new hotspot build - hs24-b06 Reviewed-by: johnc ! make/hotspot_version Changeset: 1139f6b1cbd4 Author:jcoomes Date: 2012-03-20 19:

hg: jdk8/tl/langtools: 3 new changesets

2012-04-10 Thread lana . steuck
Changeset: e4241f09e2b6 Author:katleman Date: 2012-04-05 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e4241f09e2b6 Added tag jdk8-b33 for changeset 46831c72b7f6 ! .hgtags Changeset: 517f0789bd4e Author:lana Date: 2012-04-09 21:58 -0700 URL: http

hg: jdk8/tl/jaxp: Added tag jdk8-b33 for changeset 9bcab2b8b8ea

2012-04-10 Thread lana . steuck
Changeset: 19d53d500474 Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/19d53d500474 Added tag jdk8-b33 for changeset 9bcab2b8b8ea ! .hgtags

hg: jdk8/tl/corba: Added tag jdk8-b33 for changeset 1e2ac1ea3f6c

2012-04-10 Thread lana . steuck
Changeset: 0feb9b8a9538 Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0feb9b8a9538 Added tag jdk8-b33 for changeset 1e2ac1ea3f6c ! .hgtags

hg: jdk8/tl/jaxws: Added tag jdk8-b33 for changeset ea80b2388dce

2012-04-10 Thread lana . steuck
Changeset: b3cad5619239 Author:katleman Date: 2012-04-05 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b3cad5619239 Added tag jdk8-b33 for changeset ea80b2388dce ! .hgtags

New reviewers: 7160496 : Rename JDK8 JAXP source directory

2012-04-10 Thread Joe Wang
After removing the jaxp source drop bundle process, refer to 7150324, the source structure needs to be changed to be consistent with that of jdk7. I will rename jdk8/jaxp/src/share/classes to jdk8/jaxp/src before updating it to the current jaxp source (7160380). webrev for the build files: ht

Re: Request for review : 7121314 : Behavior mismatch between AbstractCollection.toArray(T[] ) and its spec

2012-04-10 Thread Sean Chou
Hi Charles, Verified. Thanks. On Tue, Apr 10, 2012 at 2:03 PM, Charles Lee wrote: > Hi Sean, > > The the patch has been committed @ > > Changeset: e06ea0dd9207 > Author:littlee > Date: 2012-04-10 10:17 +0800 > URL:http://hg.openjdk.java.**net/jdk8/tl/jdk/rev/**e06ea0dd9207

Re: Code Review Request: 7157893: Warnings Cleanup in java.util.*

2012-04-10 Thread Kurchi Hazra
Hi Stuart, Please find the updated webrev here: http://cr.openjdk.java.net/~khazra/7157893/webrev.01/ I hope to have included all the suggestions correctly. Also, note that I made some new changes in Hashtable.java at lines 185, 355 and 910 to get rid of some additional warnings. Thanks

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread Mandy Chung
Staffan, Roger, There isn't any undocumented semantics other than what the specification for com.sun.management.OperatingSystemMXBean specifies (that is indicated by its method name): http://docs.oracle.com/javase/7/docs/jre/api/management/extension/index.html As Roger suggests, you can d

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread rhoover
Scott, Steffan (I am he one who put in the original lines of: return -1.0; // not available being replaced by this patch) I was reluctant to implement these functions because the linux code was quite involved and it appeared to me that there might be some additional semantics to what was imple

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread Scott Kovatch
Regarding Apple, Roger Hoover would be a good person to look at this, as he's spent more time in the Darwin levels of the VM. I think he's still partially attached to the OpenJDK work. -- Scott On Apr 10, 2012, at 8:58 AM, Daniel D. Daugherty wrote: > Staffan, > > I reviewed it and I think i

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread Daniel D. Daugherty
Staffan, I reviewed it and I think it looks OK. I tried looking at the code in MacosxOperatingSystem.c relative to the Linux version, but I think it is easily possible to miss something subtle here. You might try a direct ping to Mandy Chung since M&M was her area. You might also try a direct pi

hg: jdk8/tl/jdk: 7158930: (ann) library support for repeating annotations is not built when compiling the JDK

2012-04-10 Thread jonathan . gibbons
Changeset: eec133f2406a Author:jfranck Date: 2012-04-10 10:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eec133f2406a 7158930: (ann) library support for repeating annotations is not built when compiling the JDK Reviewed-by: ohair, erikj ! make/java/java/reflect/Makefile

hg: jdk8/tl/jdk: 7154809: JDI: update JDI/JDB debugee commandline option parsing

2012-04-10 Thread staffan . larsen
Changeset: fb52e8bd3718 Author:mgronlun Date: 2012-04-10 10:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb52e8bd3718 7154809: JDI: update JDI/JDB debugee commandline option parsing Summary: update debugee commandline parsing Reviewed-by: dcubed, dsamersoff, sla ! src/s

Re: RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

2012-04-10 Thread Staffan Larsen
Any takers for this review? (added core-libs-dev as well) Thanks, /Staffan On 3 apr 2012, at 15:39, Staffan Larsen wrote: > Please review the following fix: > > webrev: http://cr.openjdk.java.net/~sla/7147848/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147848 > > This

Re: New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-10 Thread Alan Bateman
On 09/04/2012 10:32, Deven You wrote: : The issue is reported by one of our test team which maintains a set of ORB test cases. Okay but I guess I'm still a bit curious as it's not obvious that rmic (or rmic --iiop) invokes toString, maybe this is a white box test or a test that is using sun.

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-10 Thread Alan Bateman
On 10/04/2012 08:10, Sean Chou wrote: And it is found that hotspot calls ZIP_Open through (*ZipOpen) in file classLoader.cpp .So I also made a patch for it and add hotspot-dev to cc list. File classLoader.cpp is the only one I have found calling ZIP_Open. The webrev for hotspot is: h

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-10 Thread Sean Chou
Hi Alan, I modified the patch according to your comments. The new webrev for cl is: http://cr.openjdk.java.net/~zhouyx/7159982/webrev.00/ And it is found that hotspot calls ZIP_Open through (*ZipOpen) in file classLoader.cpp .So I also made a patch for it and add hotspot-dev to cc list.