Hi Martin, yes, I will be the sponsor of this rfe.
-Sherman
On 4/16/2012 1:43 PM, Martin Kirst wrote:
Am 14.04.2012 10:28, schrieb Martin Kirst:
Hi,
[...]
WebRev here:
http://dl.dropbox.com/u/52514330/6341887/webrev.00/index.html
Feedback is welcome.
Thanks for all your feedback.
Today, I'v
Hi Rob,
Adding new methods to Process definitely requires providing defaults.
This aspect should be covered in CCC request.
David
On 12/04/2012 9:48 AM, Rob McKenna wrote:
Hi folks,
I'm hoping for some feedback on the above. Webrev:
http://cr.openjdk.java.net/~robm/4244896/webrev.00/
This
Certainly the string management in this code is a bit of a mess, but I
don't understand why the strdup's of string literals have been
introduced. Even if for a good reason this seems to imply that an
allocation failure will result in a NULL where before the caller was
guaranteed never to get NU
Hi Roger,
In a case like this where the Math and StrictMath versiosn of a method
have exactly the same behavior defined, I strongly suggest having the
Math version of the test invoke tests for both Math and StrictMath
siblings of a method. In other words, have a single
test/java/lang/Ma
On 04/17/2012 12:26 AM, Stuart Marks wrote:
On 4/16/12 1:18 PM, Kurchi Hazra wrote:
Sorry, I forgot to insert a link to the webrev :
http://cr.openjdk.java.net/~khazra/7157893/webrev.02/
On 4/16/2012 12:31 PM, Kurchi Hazra wrote:
On 4/13/2012 8:26 PM, Mike Duigou wrote:
Looks good for commit
On 4/16/12 1:18 PM, Kurchi Hazra wrote:
Sorry, I forgot to insert a link to the webrev :
http://cr.openjdk.java.net/~khazra/7157893/webrev.02/
On 4/16/2012 12:31 PM, Kurchi Hazra wrote:
On 4/13/2012 8:26 PM, Mike Duigou wrote:
Looks good for commit. Just a few notes
EnumMap.java:
maskNull s
Hi there,
Sorry if this has been asked before, but I am curious as to why the
newer methods in StrictMath (including addExact etc.) are now
delegating to methods in Math.
Looking at the other static methods, they seem to be going in the
opposite direction, i.e. Math methods calling equivalent met
Hi,
I've corrected a number of issues raised with javadoc in java.lang.Math
and java.lang.StrictMath. The updated webrev is:
http://cr.openjdk.java.net/~rriggs/6282196.2/
Please review.
Thanks, Roger
On 03/05/2012 08:38 AM, Roger Riggs wrote:
CR 6282196 There should be Math.mod(number, mod
Am 14.04.2012 10:28, schrieb Martin Kirst:
> Hi,
> [...]
> WebRev here:
> http://dl.dropbox.com/u/52514330/6341887/webrev.00/index.html
>
> Feedback is welcome.
Thanks for all your feedback.
Today, I've send my signed OCA to oracle-ca_us(at)oracle.com.
>From all your feedback I've caught the fo
Sorry, I forgot to insert a link to the webrev :
http://cr.openjdk.java.net/~khazra/7157893/webrev.02/
- Kurchi
On 4/16/2012 12:31 PM, Kurchi Hazra wrote:
On 4/13/2012 8:26 PM, Mike Duigou wrote:
Looks good for commit. Just a few notes
EnumMap.java:
maskNull seemed to have the unchecked
On 4/13/2012 8:26 PM, Mike Duigou wrote:
Looks good for commit. Just a few notes
EnumMap.java:
maskNull seemed to have the unchecked cast well bottlenecked. Why move the cast outside
of unmaskNull() and thus require @SuppressWarnings("unchecked") in many other
places.
I agree with this o
On 4/16/12 2:38 PM, Joe Wang wrote:
> I've added the testcase. The new webrev is here:
> http://cr.openjdk.java.net/~joehw/jdk8/7160380/jdk/webrev/
Looks good.
Thanks,
Sean
>
> Also, Lance has reviewed the long list of the source changes.
>
> Thanks!
>
> -Joe
>
> On 4/16/2012 7:20 AM, Sean
Changeset: c0f34986d1c5
Author:alanb
Date: 2012-04-16 20:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0f34986d1c5
7143744: (se) Stabilize KQueue SelectorProvider and make default on MacOSX
Reviewed-by: michaelm, chegar
! src/macosx/classes/sun/nio/ch/DefaultSelectorPro
I've added the testcase. The new webrev is here:
http://cr.openjdk.java.net/~joehw/jdk8/7160380/jdk/webrev/
Also, Lance has reviewed the long list of the source changes.
Thanks!
-Joe
On 4/16/2012 7:20 AM, Sean Mullan wrote:
On 4/12/12 6:25 PM, Joe Wang wrote:
This is a follow-up update on
See inline
On Sat 14 Apr 2012 09:12:37 AM PDT, Alan Bateman wrote:
On 14/04/2012 00:45, Darryl Mocek wrote:
Hello core-libs. Please review this webrev to fix Bug #6948101 and
#7142596. This commit fixes concurrency issues with the RMI tests.
- Added TestLibrary.getUnusedRandomPort method. Th
Hi,
I ain't got permission to publish webrevs yet. So attached is a patch produced
by hg export on the jdk tree for:
7157656 (zipfs) SeekableByteChannel to entry in zip file always reports its
position as 0
Paul.
# HG changeset patch
# User psandoz
# Date 1334594401 -3600
# Node ID 9febc8c1
On 4/16/2012 7:20 AM, Sean Mullan wrote:
On 4/12/12 6:25 PM, Joe Wang wrote:
This is a follow-up update on Kelly's change that dropped the jaxp
source drop bundle process. With this update, the jaxp source in JDK8
will be sync-ed with the current JAXP 1.4.5, and also JDK7u (the last
change was 7
On 4/12/12 6:25 PM, Joe Wang wrote:
> This is a follow-up update on Kelly's change that dropped the jaxp
> source drop bundle process. With this update, the jaxp source in JDK8
> will be sync-ed with the current JAXP 1.4.5, and also JDK7u (the last
> change was 7151484). Going forward, we'll fo
Hi Sherman,
IMHO it is worth spending a little time getting the exception messages a little
more accurate. I have spent too many a time staring at such messages wondering
what the heck is going on :-)
e.g.
Syntax error parsing replacement string: escaped literal character is missing
at the en
19 matches
Mail list logo
