Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

Thanks David, I suspect Alan simply meant that it may be preferable to use System.nanoTime to measure the time elapsed in the default implementation as opposed to System.currentTimeMillis. I had forgotten about the lower resolution of the timer interrupt. I'll revert that aspect of the change

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

Hi Rob, On 20/04/2012 11:33 AM, Rob McKenna wrote: I've uploaded another webrev to: http://cr.openjdk.java.net/~robm/4244896/webrev.02/ I'll take a look as soon as I have a chance but will be OOTO the rest of today. I plan to spend s

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

I've uploaded another webrev to: http://cr.openjdk.java.net/~robm/4244896/webrev.02/ I plan to spend some time over the coming day or two beefing up the test for waitFor (right now its really geared towards destroyForcibly) so I won't g

hg: jdk8/tl/jdk: 7158636: InterfaceAddress.getBroadcast() returns invalid broadcast address on WLAN

Changeset: 715f50872ae7 Author:khazra Date: 2012-04-19 18:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/715f50872ae7 7158636: InterfaceAddress.getBroadcast() returns invalid broadcast address on WLAN Summary: Update Windows native code to infer WLAN interface type in Win

Re: RFR: 7103570 AtomicIntegerFieldUpdater does not work when SecurityManager is installed

Thanks Paul that was a good set of suggestions. I had overlooked the change in the exceptions being thrown. Updated webrev: http://cr.openjdk.java.net/~dholmes/7103570/webrev.01/ I can't do quite exactly as you said because the NoSuchFieldException has to remain wrapped in one RuntimeExceptio

Re: RFR: 7160725 - Strange or obsolete @see tags in some exception java.lang javadoc

Hi Jim, On 20/04/2012 12:41 AM, Jim Gish wrote: Hi David, As I discussed with Alan, I don't think the conventions for @see in general are very clear. One could argue that there are a number of approaches that could be taken, among them: an exhaustive list, a representative list, or one simpl

hg: jdk8/tl/jdk: 7162385: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing again

Changeset: bc51d0569ccd Author:khazra Date: 2012-04-19 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc51d0569ccd 7162385: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing again Summary: Enable finding "foo1.jar" Reviewed-by: chegar ! test/sun/net/www/protocol

RFR : 7161925 : sjava files in corba don't have copyright string and legal notice

This is a copyright patch that misha.by...@oracle.com has asked to contribute. I'm pushing it to jdk8 for him. corba repo found to be lacking headers on 2 files. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161925 http://cr.openjdk.java.net/~coffeys/webrev.7161925.jdk8/ regards, Sean.

RFR : 7161925 : sjava files in corba don't have copyright string and legal notice

This is a copyright patch that misha.by...@oracle.com has asked to contribute. I'm pushing it to jdk8 for him. corba repo found to be lacking headers on 2 files. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161925 http://cr.openjdk.java.net/~coffeys/webrev.7161925.jdk8/ regards, Sean.

hg: jdk8/tl/jdk: 7162823: Modify the list of excluded tests (ProblemList

Changeset: 404c8e097ae9 Author:vinnie Date: 2012-04-19 16:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/404c8e097ae9 7162823: Modify the list of excluded tests (ProblemList Reviewed-by: alanb ! test/ProblemList.txt

Re: RFR: 7160725 - Strange or obsolete @see tags in some exception java.lang javadoc

Hi David, As I discussed with Alan, I don't think the conventions for @see in general are very clear. One could argue that there are a number of approaches that could be taken, among them: an exhaustive list, a representative list, or one simple example. A complete enumeration in many cases (

Re: RFR: 7103570 AtomicIntegerFieldUpdater does not work when SecurityManager is installed

Hi David, I think you can retain the same exception throwing behavior (plus no casts are required to Field) as before by doing: try { field = AccessController.doPrivileged(new PriviledgedExceptionAction() { public Field run() throws NoSuchFieldException { return tclass.g

hg: jdk8/tl/jdk: 7162262: (fs) Typo in java.nio.file.Path class description

Changeset: 7b023213681c Author:psandoz Date: 2012-04-19 14:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b023213681c 7162262: (fs) Typo in java.nio.file.Path class description Reviewed-by: alanb ! src/share/classes/java/nio/file/Path.java

RFR: 7103570 AtomicIntegerFieldUpdater does not work when SecurityManager is installed

http://cr.openjdk.java.net/~dholmes/7103570/webrev/ Basic fix is to call getDeclaredField() inside a doPrivileged block. In addition the call to checkPackageAccess is now conditional - it allows for, for example, a class in sun.misc to create a field updater for another class in sun.misc. Fi

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

On 19/04/2012 01:05, David Holmes wrote: On 18/04/2012 11:44 PM, Jason Mehrens wrote: Rob, It looks like waitFor is calling Object.wait(long) without owning this objects monitor. If I pass Long.MAX_VALUE to waitFor, shouldn't waitFor return if the early if the process ends? Also waitFor d

Re: Code Review Request - Bug #6948101 & 7142596: RMI JPRT tests are failing

On 18/04/2012 21:39, Darryl Mocek wrote: : Brilliant! I didn't realize Registry.toString included the port number. However, I did in fact find a way to get the port through the API's (see below), although I think toString is more efficient. I'm pretty sure I can get rid of the instanceof c

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

On 19/04/2012 09:05, Sean Chou wrote: Thanks David and Alan, shall I find some one to commit it ? I assume Charles or Neil will push it for you. If they aren't available then I should be able to find someone to sponsor this. -Alan.

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

Thanks David and Alan, shall I find some one to commit it ? On Thu, Apr 19, 2012 at 8:53 AM, David Holmes wrote: > On 19/04/2012 4:05 AM, Alan Bateman wrote: > >> On 18/04/2012 14:02, David Holmes wrote: >> >>> On 18/04/2012 10:23 PM, Sean Chou wrote: >>> Hi David, Alan, So is the