Code Review Request: 7164636: (prefs) Cleanup src/macosx/classes/java/util/prefs

2012-05-11 Thread Kurchi Hazra
Hi, This change aims at removing some rawtype usages in src/macosx/classes/java/util/prefs that were brought into jdk8 with the macport. I have added @Override tags too where applicable. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7164636 Webrev: http://cr.openjdk.java.net/~kha

hg: jdk8/tl/jdk: 7144861: speed up RMI activation tests

2012-05-11 Thread stuart . marks
Changeset: f131d4361faf Author:olagneau Date: 2012-05-11 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f131d4361faf 7144861: speed up RMI activation tests Reviewed-by: alanb, smarks, dholmes, dmocek ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi

hg: jdk8/tl/jdk: 26 new changesets

2012-05-11 Thread lana . steuck
Changeset: 8e3fb7dd21cd Author:skovatch Date: 2012-04-25 12:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e3fb7dd21cd 7128699: Fix bundle name so it contains the bugfix number in the name. Reviewed-by: robilad ! make/common/Release-macosx.gmk Changeset: 919be2f7fd6e Au

hg: jdk8/tl/hotspot: 21 new changesets

2012-05-11 Thread lana . steuck
Changeset: 4ee58fcab520 Author:katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4ee58fcab520 Added tag jdk8-b37 for changeset bfcf92bfefb8 ! .hgtags Changeset: 3c91f2c9fd21 Author:amurillo Date: 2012-04-20 17:13 -0700 URL: ht

hg: jdk8/tl/jaxp: 4 new changesets

2012-05-11 Thread lana . steuck
Changeset: aabc08ea546f Author:ohair Date: 2012-04-30 16:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/aabc08ea546f 7165312: Fix jaxp source movement for new build-infra Reviewed-by: ohrstrom ! makefiles/Makefile Changeset: 90204bfab4e2 Author:katleman Date: 2

hg: jdk8/tl/langtools: 3 new changesets

2012-05-11 Thread lana . steuck
Changeset: 1f224f160aa8 Author:katleman Date: 2012-05-09 13:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f224f160aa8 Added tag jdk8-b37 for changeset 5891b38985e8 ! .hgtags Changeset: a9f547c218d9 Author:katleman Date: 2012-05-10 10:25 -0700 URL:

hg: jdk8/tl/jaxws: 2 new changesets

2012-05-11 Thread lana . steuck
Changeset: ac1ba3b56775 Author:katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/ac1ba3b56775 Added tag jdk8-b37 for changeset b05a948db1b6 ! .hgtags Changeset: 7f6b44fd3034 Author:katleman Date: 2012-05-10 10:25 -0700 URL: http

hg: jdk8/tl: 6 new changesets

2012-05-11 Thread lana . steuck
Changeset: afeeed8e5f8c Author:ihse Date: 2012-04-30 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/afeeed8e5f8c 7165277: Fix missing execute permission issue running logger.sh Reviewed-by: ohair ! common/autoconf/configure ! common/autoconf/configure.ac Changeset: b29720

hg: jdk8/tl/corba: 3 new changesets

2012-05-11 Thread lana . steuck
Changeset: 2d2f6b0f855b Author:katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/2d2f6b0f855b Added tag jdk8-b37 for changeset 83fac66442cf ! .hgtags Changeset: b8cbfb31139f Author:katleman Date: 2012-05-09 13:11 -0700 URL: http

hg: jdk8/tl/jdk: 7071826: Avoid benign race condition in initialization of UUID

2012-05-11 Thread mike . duigou
Changeset: 944676ef3c58 Author:mduigou Date: 2012-05-11 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/944676ef3c58 7071826: Avoid benign race condition in initialization of UUID Summary: Avoids mostly benign but sometimes expensive race condition on initialization of

Re: Review Request : 7071826 : Avoid benign race condition in initialization of UUID

2012-05-11 Thread Mike Duigou
On May 11 2012, at 03:12 , Alan Bateman wrote: > On 11/05/2012 00:11, Mike Duigou wrote: >> >> Hello all; >> >> A benign but potentially expensive race condition was discovered in >> java.util.UUID. The initialization of numberGenerator may cause the creation >> of a number of SecureRandom in

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

2012-05-11 Thread Paul Sandoz
On May 11, 2012, at 5:24 PM, Rob McKenna wrote: > >> >> For the following code: >> >> 227 long rem = end - now; >> 228 while (!hasExited&& (rem> 0)) { >> 229 wait(TimeUnit.NANOSECONDS.toMillis(rem)); >> 230 rem = end - System.nanoTime(); >> 231

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

2012-05-11 Thread Rob McKenna
Hi Paul, Comments inline: On 11/05/12 12:29, Paul Sandoz wrote: Hi Rob, I dunno if the following has been pointed out before. It's hard to track review comments. The implementation of Process.waitFor normalizes the end time and duration remaining time to nano seconds. However, the Thread.

hg: jdk8/tl/langtools: 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type

2012-05-11 Thread sundararajan . athijegannathan
Changeset: 96a8278e323c Author:sundar Date: 2012-05-11 20:06 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96a8278e323c 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type Reviewed-by: mcimadamore ! src/share/classes/com/sun/t

Re: Request for CR : 7144861 RMI activation tests are too slow (webrev.02)

2012-05-11 Thread Olivier Lagneau
I made the changes below and checked again all the rmi regression test. This updated webrev is here : http://cr.openjdk.java.net/~olagneau/7144861/webrev.02/ Olivier Olivier Lagneau said on date 5/11/2012 12:18 PM: Stuart Marks said on date 5/11/2012 3:04 AM: Looks good. Just one thing: in J

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

2012-05-11 Thread Paul Sandoz
Hi Rob, I dunno if the following has been pointed out before. It's hard to track review comments. The implementation of Process.waitFor normalizes the end time and duration remaining time to nano seconds. However, the Thread.sleep method expects a duration in units of milliseconds. You coul

Re: Review Request for CR : 7144861 RMI activation tests are too slow (wrong webev link fixed)

2012-05-11 Thread Olivier Lagneau
Stuart Marks said on date 5/11/2012 3:04 AM: Looks good. Just one thing: in JavaVM.java, the declaration line for "boolean started" still has a comment that says "updated by started() method". That method has been renamed to setStarted(). Either fix the comment or perhaps better, remove it ent

Re: Review Request : 7071826 : Avoid benign race condition in initialization of UUID

2012-05-11 Thread Alan Bateman
On 11/05/2012 00:11, Mike Duigou wrote: Hello all; A benign but potentially expensive race condition was discovered in java.util.UUID. The initialization of numberGenerator may cause the creation of a number of SecureRandom instances if multiple threads are attempting to initialize the field

Re: Review Request : 7071826 : Avoid benign race condition in initialization of UUID

2012-05-11 Thread Chris Hegarty
The changes look good to me. -Chris. On 11/05/12 00:11, Mike Duigou wrote: Hello all; A benign but potentially expensive race condition was discovered in java.util.UUID. The initialization of numberGenerator may cause the creation of a number of SecureRandom instances if multiple threads are

hg: jdk8/tl/jdk: 7167359: (tz) SEGV on solaris if TZ variable not set

2012-05-11 Thread sean . coffey
Changeset: 3e83229a3779 Author:coffeys Date: 2012-05-11 10:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e83229a3779 7167359: (tz) SEGV on solaris if TZ variable not set Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c

hg: jdk8/tl/jdk: 7163874: InetAddress.isReachable should support pinging 0.0.0.0

2012-05-11 Thread littlee
Changeset: c5a07e3dca63 Author:youdwei Date: 2012-05-11 16:20 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5a07e3dca63 7163874: InetAddress.isReachable should support pinging 0.0.0.0 Reviewed-by: alanb, chegar ! src/share/native/java/net/net_util.h ! src/solaris/native/ja