Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-22 Thread Mike Duigou
Dear OpenJDK CoreLibs community, A significant enhancement to the Java SE hashing-based Map implementations in planned for inclusion in Java SE 7u6. All of the hashing based Map implementations: HashMap, Hashtable, LinkedHashMap, WeakHashMap and ConcurrentHashMap will now use an enhanced hashin

Re: Code Review Request: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8

2012-05-22 Thread David Holmes
On 23/05/2012 1:02 PM, Kurchi Subhra Hazra wrote: I ran the tests in jdk/test/java/lang and they all pass. Let me know if you think some other tests should also be run. I would think AWT/Swing is the place most likely to have version specific workarounds. David - Kurchi On 5/22/12 7:33 P

Re: Code Review Request: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8

2012-05-22 Thread Kurchi Subhra Hazra
I ran the tests in jdk/test/java/lang and they all pass. Let me know if you think some other tests should also be run. - Kurchi On 5/22/12 7:33 PM, David Holmes wrote: On 23/05/2012 11:32 AM, Kurchi Hazra wrote: Hi, This is a minor change to java_props_md.c to return "Windows 8" as the "os.n

Re: Code Review Request: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8

2012-05-22 Thread David Holmes
On 23/05/2012 11:32 AM, Kurchi Hazra wrote: Hi, This is a minor change to java_props_md.c to return "Windows 8" as the "os.name" for Windows version 6.2. Is there any windows version specific code that might also need updating to allow for Windows 8 aka 6.2? David Bug: http://bugs.sun.com

Re: Code Review Request: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8

2012-05-22 Thread Joseph Darcy
Hi Kurchi, Looks fine, -Joe On 5/22/2012 6:32 PM, Kurchi Hazra wrote: Hi, This is a minor change to java_props_md.c to return "Windows 8" as the "os.name" for Windows version 6.2. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170169 Webrev: http://cr.openjdk.java.net/~khazra/7

Code Review Request: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8

2012-05-22 Thread Kurchi Hazra
Hi, This is a minor change to java_props_md.c to return "Windows 8" as the "os.name" for Windows version 6.2. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170169 Webrev: http://cr.openjdk.java.net/~khazra/7170169/webrev.00/ Thanks, Kurchi