Two small issues related to the larger alternative string hashing changes
(CR#7126277) from last week. One issue is for JDK 7 and the other is for JDK 8.
Both are quite small.
For the JDK 7 issue, as documented in the review request, the default threshold
for the alternative hashing in that
Both sets of changes look fine to me.
David
On 4/06/2012 4:08 PM, Mike Duigou wrote:
Two small issues related to the larger alternative string hashing changes
(CR#7126277) from last week. One issue is for JDK 7 and the other is for JDK 8.
Both are quite small.
For the JDK 7 issue, as
Changeset: a5bb0343f135
Author:weijun
Date: 2012-06-04 18:06 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5bb0343f135
7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected
Reviewed-by: alanb
! test/com/sun/jdi/ConnectedVMs.java
Hi Mike,
Am 31.05.2012 07:19, schrieb mike.dui...@oracle.com:
Changeset: 43bd5ee0205e
Author:mduigou
Date: 2012-05-30 22:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43bd5ee0205e
7126277: Alternative String hashing implementation
Summary: ... when the capacity of the
Thanks David. Thanks Mike.
The patch has been committed.
On 06/04/2012 11:33 AM, Mike Duigou wrote:
The change looks good to me.
On Jun 3 2012, at 20:05 , David Holmes wrote:
On 4/06/2012 11:55 AM, Charles Lee wrote:
Thanks David. Do I need another review?
Yes. Someone from TL - Mike or
Am 04.06.2012 08:08, schrieb Mike Duigou:
Two small issues related to the larger alternative string hashing changes
(CR#7126277) from last week. One issue is for JDK 7 and the other is for JDK 8.
Both are quite small.
For the JDK 7 issue, as documented in the review request, the default
On 06/03/2012 11:35 PM, Mike Duigou wrote:
[I trimmed the distribution list]
On Jun 3 2012, at 13:44 , Peter Levart wrote:
On Thursday, May 31, 2012 03:22:35 AM mike.dui...@oracle.com wrote:
Changeset: 2c773daa825d
Author:mduigou
Date: 2012-05-17 10:06 -0700
URL:
Please review. In addition to fixing the copyright I also fixed the incorrect
indentation of the rest of the file (which is kind of hard to tell from the
webrev).
Bug: 7156963
CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156963
Synopsis: Incorrect copyright header in
Hi Alan,
I've already sent the signed OCA. Will you sponsor the patch ?
Best,
Diego
On Mon, May 28, 2012 at 11:37 PM, Diego Belfer dbel...@gmail.com wrote:
Hi Alan,
Thanks for your reply. I am attaching a new patch and it contains the test
case now.
I have read the contents of the link
In getBytes() you do not need:
int n = srcEnd;
int i = srcBegin;
You could already use srcEnd srcBegin
@@ -1015,16 +968,16 @@ public final class String
return true;
}
if (anObject instanceof String) {
-String anotherString = (String)anObject;
-
Looks fine,
-Joe
On 6/4/2012 7:01 AM, Edvard Wendelin wrote:
Please review. In addition to fixing the copyright I also fixed the incorrect
indentation of the rest of the file (which is kind of hard to tell from the
webrev).
Bug: 7156963
CR:
Ulf,
As I understand Mike's email, the JDK7 code is not being modified (at
this stage at least) to apply the optimizations that have been applied
to the JDK8 code. The JDK 7 changes are only to set the default value to
512 (plus that one final field change)
David
On 4/06/2012 10:39 PM, Ulf
It seems the whole copyright header is one-char shifted to right.
-Max
On 06/05/2012 02:38 AM, Joe Darcy wrote:
Looks fine,
-Joe
On 6/4/2012 7:01 AM, Edvard Wendelin wrote:
Please review. In addition to fixing the copyright I also fixed the
incorrect indentation of the rest of the file
Changeset: 4573662cb28c
Author:zhouyx
Date: 2012-06-05 10:16 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4573662cb28c
7173044: MemoryMonitor hangs if getMax method in MemoryUsage object returns -1
Reviewed-by: dholmes, sspitsyn
!
14 matches
Mail list logo
