Changeset: 46ff1b63b0c3
Author:lancea
Date: 2012-06-11 07:10 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ff1b63b0c3
7171917: CachedRowSetImpl.populate does not handle map properly
Reviewed-by: joehw
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
On 07/06/2012 21:39, Joe Darcy wrote:
I'd like to see some () on this line!
470 ClassLoader cl = cc != null ? cc.getClassLoader() : null;
It's `a==b ? c : d` is such an incredibly common idiom in Java, and
generally unambiguous, that parentheses are unhelpful noise. Emphasising
precedence
Changeset: 1af3996aa431
Author:sla
Date: 2012-06-11 20:52 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/rev/1af3996aa431
7175802: Missing jdk_jfr in top-level make file
Reviewed-by: alanb
! test/Makefile
As reported in 7157610, when
setFeature(http://apache.org/xml/features/disallow-doctype-decl;, true)
is set on SAXParserFactory object, XMLReader object or
DocumentBuilderFactory object, NullPointerException will be thrown when
parsing XML document that has DOCTYPE declaration.
The cause of
Looks OK joe.
Do you still need the comment
//return fSupportDTD? next() : dtdEvent;
in XMLDocumentScannerImpl? If not you might consider removing it.
Best
Lance
On Jun 11, 2012, at 3:08 PM, Joe Wang wrote:
As reported in 7157610, when
Hi,
Here is a patch that fixes the merge method of the JarIndex. This bug was
reported as the cause of the bug 6901992. Although, I was not able to
reproduce the BUG itself (InvalidJarIndexException), I did verified that
the method had a bug, and resources/classes where not found in a jarIndex
Thanks Lance.
That comment was there forever, removed now :)
New webrev:
http://cr.openjdk.java.net/~joehw/7u6/7157610/webrev/
http://cr.openjdk.java.net/%7Ejoehw/7u6/7157610/webrev/
-Joe
On 6/11/2012 12:33 PM, Lance Andersen - Oracle wrote:
Looks OK joe.
Do you still need the comment
Hi Joe,
No need to see it with just the change of the comment removed...
good to go by me :-)
Best
Lance
On Jun 11, 2012, at 4:23 PM, Joe Wang wrote:
Thanks Lance.
That comment was there forever, removed now :)
New webrev:
http://cr.openjdk.java.net/~joehw/7u6/7157610/webrev/
-Joe
While triaging outstanding String bugs, I was looking at 4247235, (spec
str) StringBuffer.insert(int, char[]) specification is inconsistent
Although the description is out of date w.r.t. the current code, I did
find what I would consider weaknesses (maybe even holes) in the specs
relative to
Changeset: f328914a04ea
Author:joehw
Date: 2012-06-11 15:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f328914a04ea
7157610: NullPointerException occurs when parsing XML doc
Summary: recovers what was the original disallow-doctype-decl, reporting error
when
On Jun 11, 2012, at 5:44 AM, Tom Hawtin wrote:
On 07/06/2012 21:39, Joe Darcy wrote:
I'd like to see some () on this line!
470 ClassLoader cl = cc != null ? cc.getClassLoader() : null;
It's `a==b ? c : d` is such an incredibly common idiom in Java, and generally
unambiguous, that
Changeset: 9cafabb5e576
Author:ksrini
Date: 2012-06-11 15:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9cafabb5e576
7160072: (javac) JavacParserTests needs cleanup
Reviewed-by: jjg
! test/tools/javac/parser/JavacParserTest.java
Hi,
This is patch to make sure the cause of the error is properly reported.
It has been in jaxp since Feb.
webrev: http://cr.openjdk.java.net/~joehw/7u6/7143711/webrev/
Please review.
Thanks,
Joe
Changeset: 844478076c25
Author:jjh
Date: 2012-05-31 15:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/844478076c25
7159016: Static import of member in processor-generated class fails in JDK 7
Reviewed-by: jjg
!
Changeset: c6c0b1047985
Author:jmelvin
Date: 2012-04-16 17:10 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/c6c0b1047985
7130404: [macosx] os.arch value should be x86_64 for compatibility with
Apple JDK6
Summary: On Mac OS X, align system property os.arch with Apple
Changeset: 77b35c5c4b95
Author:jmelvin
Date: 2012-04-16 18:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77b35c5c4b95
7130404: [macosx] os.arch value should be x86_64 for compatibility with
Apple JDK6
Summary: On Mac OS X, align system property os.arch with Apple legacy
Changeset: f5dbd6895994
Author:jjh
Date: 2012-05-21 16:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f5dbd6895994
7157798: Add 6 test scenarios for testing inheritance of multiple same-name
methods from mulitple interfaces
Reviewed-by: mcimadamore
Contributed-by:
On Thursday, May 31, 2012 03:22:35 AM mike.dui...@oracle.com wrote:
Changeset: 2c773daa825d
Author:mduigou
Date: 2012-05-17 10:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c773daa825d
6924259: Remove offset and count fields from java.lang.String
Summary: Removes
Hi, Mandy,
the client part of the fix looks fine. Let me ask a naive question, though.
From your explanation, I see that System.loadLibrary() is now aware of
modules. What prevents us to change LoadLibraryAction the same way?
FROM code looks much more elegant than the new (the old?) TO one.
Approved.
On 05/02/2012 09:10 PM, Kurchi Hazra wrote:
Requesting approval to commit fix for CR 7118100.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7118100
Webrev: http://cr.openjdk.java.net/~khazra/7118100/webrev.01/
This had been reviewed by Alan Bateman. [1]
This fix has been
cc'ing Rroland Westrelin, as this may be caused by some of the changes in
hs24-b12. Note that jdk8/tl is only sync with b11 and that probably explains
why we aren't seeing them here.
Yes, a change we made to speed up pow/exp calculation by relying on x86 fpu
instructions broke this test. Is
Hi Jim,
On 12/06/2012 7:59 AM, Jim Gish wrote:
While triaging outstanding String bugs, I was looking at 4247235, (spec
str) StringBuffer.insert(int, char[]) specification is inconsistent
Although the description is out of date w.r.t. the current code, I did
find what I would consider
22 matches
Mail list logo
