classlist.* and jar_reorder ?

2012-07-02 Thread David Holmes
Can someone explain to me, or point me to docs, regarding the make/tools/sharing/classlist.* files, how they are used and maintained and what jar_reorder does with them? Thanks, David

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-02 Thread Eric Wang
David, I have added the comments before the loop, please help to review. If it is OK, I'll update the 7123972 as well. Thanks, Eric On 2012/7/3 12:22, David Holmes wrote: Hi Eric, On 3/07/2012 1:28 PM, Eric Wang wrote: Hi Stuart and David, Thanks for the suggestion about the timeout. so t

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-02 Thread David Holmes
Hi Eric, On 3/07/2012 1:28 PM, Eric Wang wrote: Hi Stuart and David, Thanks for the suggestion about the timeout. so there are three ways to handle the timeout. 1. Add comment to explain that test failed due to default timeout 2. Specify the the timeout option 3. Timeout programly Is it ok fo

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-02 Thread Eric Wang
Hi Stuart and David, Thanks for the suggestion about the timeout. so there are three ways to handle the timeout. 1. Add comment to explain that test failed due to default timeout 2. Specify the the timeout option 3. Timeout programly Is it ok for you that i'd like to choose the second way "ex

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-02 Thread David Holmes
On 3/07/2012 7:08 AM, Stuart Marks wrote: On 7/1/12 5:39 PM, David Holmes wrote: Now, how can the test fail? If ref is never cleared, the while loop will never terminate, and we rely on jtreg to timeout and kill this test. It would be good to have a brief comment above the while loop that explai

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

2012-07-02 Thread Stuart Marks
Pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2fc66012451 Thanks for your contributions to OpenJDK! s'marks On 7/1/12 4:05 AM, Martijn Verburg wrote: Hi Stuart, The java.util patches look good and are almost ready to go in. The only issue is how to format the Contributed-by line in

hg: jdk8/tl/jdk: 7176907: additional warnings cleanup in java.util, java.util.regexp, java.util.zip

2012-07-02 Thread stuart . marks
Changeset: b2fc66012451 Author:smarks Date: 2012-07-02 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2fc66012451 7176907: additional warnings cleanup in java.util, java.util.regexp, java.util.zip Reviewed-by: forax, khazra, smarks Contributed-by: Mani Sarkar ! src/

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-07-02 Thread Stuart Marks
On 7/1/12 5:39 PM, David Holmes wrote: Now, how can the test fail? If ref is never cleared, the while loop will never terminate, and we rely on jtreg to timeout and kill this test. It would be good to have a brief comment above the while loop that explains this. Agreed. Something like // Might

hg: jdk8/tl/jdk: 7174887: Deadlock in jndi ldap connection cleanup

2012-07-02 Thread rob . mckenna
Changeset: ecc5dd3790a1 Author:robm Date: 2012-07-02 19:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecc5dd3790a1 7174887: Deadlock in jndi ldap connection cleanup Reviewed-by: xuelei ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi

Re: [8] Review request for 7162111 change tests run in headless mode [macosx]

2012-07-02 Thread Anthony Petrov
Looks fine to me. -- best regards, Anthony On 07/02/12 18:18, Jason Uh wrote: Anthony and Alan, Thanks for your comments. I've reverted the changes to CommonSetup.sh so that XToolkit is no longer forced. Tests still pass. Please see the new webrev: http://cr.openjdk.java.net/~juh/7162111/webr

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-02 Thread Lance Andersen - Oracle
Hi Deven, Thanks for the email and the proposed patch. I will look at this later today or tomorrow. I actually have made these changes in my workspace for JDK 8 but will compare your changes to mine. Best Lance On Jul 2, 2012, at 5:04 AM, Deven You wrote: > Hi All, > Could anyone notice this

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-02 Thread Deven You
Hi All, Could anyone notice this problem? Thanks a lot! On 06/25/2012 04:18 PM, Deven You wrote: Hi All, First of all, if the jdbc problem has a better mailing list to post please tell me. I find that javax.sql.rowset.serial.SerialBlob is not fully implemented in OpenJDK 8. Methods pu