Stuart,
see inline...
On Fri 06 Jul 2012 11:47:54 AM PDT, Stuart Marks wrote:
Hi,
I've reviewed the first half of the files, thru
test/java/rmi/registry/reexport/Reexport.java. Basically things look
good and make sense, but there are some details to be ironed out and
some cleanups to be
Changeset: 516e0c884af2
Author:robm
Date: 2012-07-09 22:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/516e0c884af2
7179305: (fs) Method name sun.nio.fs.UnixPath.getPathForExecptionMessage is
misspelled
Reviewed-by: dholmes, chegar
!
OK, here's the review for the second half of the files in the webrev. I saw
your reply to the first half (to which I'll reply separately), and I don't
think there's anything here that's affected by them.
*** AppleUserImpl.java
*** ApplicationServer.java
REGISTRY_PORT should be a local
On 7/9/12 11:14 AM, Darryl Mocek wrote:
*** SetChildEnv.java
The testing of the message string from the IOException causes me great
concern. This message is defined all the way over in
java.io.PipedInputStream, and while it's not localized, it does seem
like a pretty fragile dependency. I mean,
On Mon 09 Jul 2012 05:02:23 PM PDT, Stuart Marks wrote:
On 7/9/12 11:14 AM, Darryl Mocek wrote:
*** SetChildEnv.java
The testing of the message string from the IOException causes me great
concern. This message is defined all the way over in
java.io.PipedInputStream, and while it's not
Hi Paul,
I'm back from vacation.
You're right. But such an error is also expected. The original design
never tried to out-do the java.net.URL. If a system ID input fails URL,
it shall result in an exception.
The patch that supplied the extra encoding was provided to both Sun and
Apache,
On 7/9/12 5:04 PM, Darryl Mocek wrote:
I originally had getUnusedRandomPort/createRegistry(randomPort), but Alan felt
LocateRegistry.createRegistry(0) is a better choice. getUnusedRandomPort
creates a socket to ensure the port is available, then closes it and returns
the port number. It's
