Thanks Kurchi, looks fine.
-Chris
Kurchi Hazra kurchi.subhra.ha...@oracle.com wrote:
On 7/11/12 4:24 PM, Chris Hegarty wrote:
On 12 Jul 2012, at 00:15, Kurchi Hazrakurchi.subhra.ha...@oracle.com
wrote:
Thanks for the review Alan. Updated webrev:
On 07/11/2012 11:05 PM, Louis Wasserman wrote:
Doing it with bit-twiddling and Double.longBitsToDouble improves the speed
of those methods by something like two orders of magnitude in my benchmarks.
Mmm, but that's going to hit double-rounding bugs for large numbers. Where
is this patch,
On 12/07/2012 00:45, Kurchi Hazra wrote:
On 7/11/12 4:24 PM, Chris Hegarty wrote:
On 12 Jul 2012, at 00:15, Kurchi
Hazrakurchi.subhra.ha...@oracle.com wrote:
Thanks for the review Alan. Updated webrev:
http://cr.openjdk.java.net/~khazra/7160252/webrev.01/
Looks fine.
Trivially, is there
It was attached to the previous message? I don't know if this list works
with attachments. Alternately, the patch was attached here:
https://bugs.openjdk.java.net/show_bug.cgi?id=100222
I'm not sure what you mean by double-rounding bugs, though. It's not
difficult to actually implement the
Hi Joe,
On Jul 11, 2012, at 7:59 AM, Joe Wang wrote:
Hi Paul,
This is now for 7u8, so I started a new thread.
As we discussed, I've removed the hack of using escapeNonUSAscii. In this
regard, we're now in sync with the source code in Xerces.
Here's the webrev:
On 07/12/2012 10:32 AM, Louis Wasserman wrote:
It was attached to the previous message? I don't know if this list works
with attachments. Alternately, the patch was attached here:
https://bugs.openjdk.java.net/show_bug.cgi?id=100222
I'm not sure what you mean by double-rounding bugs,
+1
Best
Lance
On Jul 12, 2012, at 5:42 AM, Paul Sandoz wrote:
Hi Joe,
On Jul 11, 2012, at 7:59 AM, Joe Wang wrote:
Hi Paul,
This is now for 7u8, so I started a new thread.
As we discussed, I've removed the hack of using escapeNonUSAscii. In this
regard, we're now in sync with the
Float.parseFloat doesn't currently round correctly, or even monotonically,
in certain cases.
In particular, the following test program prints false:
public class Foo {
public static void main(String[] args) {
System.out.println(144115196665790480f = 144115196665790481f);
}
}
A patch is
I used a new workspace and missed adding it to mercurial. The test
remains the same,
I'll push it after adding the test.
- Kurchi
On 7/12/12 12:16 AM, Alan Bateman wrote:
On 12/07/2012 00:45, Kurchi Hazra wrote:
On 7/11/12 4:24 PM, Chris Hegarty wrote:
On 12 Jul 2012, at 00:15, Kurchi
Lance, Paul,
Thanks!
Joe
On 7/12/2012 3:55 AM, Lance Andersen - Oracle wrote:
+1
Best
Lance
On Jul 12, 2012, at 5:42 AM, Paul Sandoz wrote:
Hi Joe,
On Jul 11, 2012, at 7:59 AM, Joe Wang wrote:
Hi Paul,
This is now for 7u8, so I started a new thread.
As we discussed, I've removed the
OK, I took a look at the revised webrev. Most stuff is good. A couple changes
are necessary though.
*** MultipleRegistries.java
Not a big deal, but the comment at lines 65-67 is no longer necessary.
*** TestLibrary.java
I think the reserved port range stuff still needs to be fixed up.
Changeset: 6e444b892c99
Author:joehw
Date: 2012-07-12 21:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6e444b892c99
7183760: DocumentBuilder.parse(String uri) is not IPv6 enabled
Summary: removing the hack of using escapeNonUSAscii. this is the same patch as
7166896
12 matches
Mail list logo
