hg: jdk8/tl/jdk: 7189363: Regex Pattern compilation buggy for special sequences

2012-08-09 Thread xueming . shen
Changeset: 717ed00b7787 Author:sherman Date: 2012-08-09 10:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/717ed00b7787 7189363: Regex Pattern compilation buggy for special sequences Summary: fixed the incorrect implementation in expr(...) Reviewed-by: psandoz, alanb ! src

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-09 Thread Andrew Hughes
- Original Message - > On 08/06/2012 11:26 AM, Andrew Hughes wrote: > > - Original Message - > >> Hi Andrew, > >> > >> I meant if we are going to put SYSTEM_ZLIB=true as default for > >> linux > >> as > >> Alan suggested, > >> we might need to update the build document as well to

Re: Code review request 7190219 CharBuffer position changed after BufferOverflowException in put()

2012-08-09 Thread Alan Bateman
On 09/08/2012 13:16, Jonathan Lu wrote: Hi folks, Here's a patch for bug 7190219, could you please help to have a look? http://cr.openjdk.java.net/~luchsh/7190219/ According to the specification, in the method java.nio.CharBuffer.put(String src, int start, int end). If there are more chars to

Code review request 7190219 CharBuffer position changed after BufferOverflowException in put()

2012-08-09 Thread Jonathan Lu
Hi folks, Here's a patch for bug 7190219, could you please help to have a look? http://cr.openjdk.java.net/~luchsh/7190219/ According to the specification, in the method java.nio.CharBuffer.put(String src, int start, int end). If there are more chars to be copied from the string than remain in

hg: jdk8/tl/jdk: 7183753: [TEST] Some colon in the diff for this test

2012-08-09 Thread dmitry . samersoff
Changeset: bf85c3ab2637 Author:dsamersoff Date: 2012-08-09 14:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf85c3ab2637 7183753: [TEST] Some colon in the diff for this test Summary: Reference output file contains extra colon Reviewed-by: sspitsyn, mgronlun ! test/sun/to

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-09 Thread Alan Bateman
On 08/08/2012 17:10, Neil Richards wrote: : Hi Alan, Apologies, I confused myself about the Hotspot behaviour. (I was testing with 'nohup', but not checking the contents of 'nohup.out' for the output from my registered shutdown hook - doh!). You're correct, when running with Hotspot with 'nohup'

Re: Codereview request for 7189363: Regex Pattern compilation buggy for special sequences

2012-08-09 Thread Alan Bateman
On 08/08/2012 22:58, Xueming Shen wrote: Hi It appears the optimization (flatten a binary tree structure into a branch/ switch) we put into JDK6 for alternation operation [1] has problem if the first construct is a group "(...)" followed by a greedy/reluctant "once or not at all" quantifier.

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-09 Thread Frank Ding
Thanks Neil for clarifying it in such a convincing way. And David for creating CR. So now we're ready to commit this patch? Best regards, Frank On 8/8/2012 8:57 AM, David Holmes wrote: On 8/08/2012 4:07 AM, Neil Richards wrote: On Tue, 2012-08-07 at 18:01 +0100, Alan Bateman wrote: On 07/08/2

Re: Codereview request for 7189363: Regex Pattern compilation buggy for special sequences

2012-08-09 Thread Paul Sandoz
Looks OK to me. Paul. On Aug 8, 2012, at 11:58 PM, Xueming Shen wrote: > Hi > > It appears the optimization (flatten a binary tree structure into a branch/ > switch) we put into JDK6 for alternation operation [1] has problem if the > first construct is a group "(...)" followed by a greedy/relu