Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Ni Naoto, Where will this be pushed to initially? It is a big set of changes, albeit localized (no pun intended :) ), so it would be good to see this get some bake time before propagating up. Further we're just about to have a "flag day" between hotspot and JDK due to JSR292 changes, so it wo

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Since I haven't heard any more comments from Erik/Kelly, I would like to push the changeset without the new build infra patch. Erik/Kelly, can you please give us an official "GO" in terms of the build related changes? Aside from build changes, I have updated the changeset based on an internal

hg: jdk8/tl/jdk: 7188442: rename java.lang.annotation.ContainerAnnotation to ContainedBy

Changeset: f0bf7358ba23 Author:jfranck Date: 2012-08-09 17:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0bf7358ba23 7188442: rename java.lang.annotation.ContainerAnnotation to ContainedBy Reviewed-by: darcy, jjg + src/share/classes/java/lang/annotation/ContainedBy.java

Re: Codereview request: 6931128: (spec) File attribute tests fail when run as root.

On 13/08/2012 15:31, Rob McKenna wrote: Hi folks, Looking for a codereview for a spec change in jdk8. In summary, when a java application is run as root it can perform file operations regardless of the permissions attributed to that file. I.e. canExecute, canRead, canWrite would return true e

Codereview request: 6931128: (spec) File attribute tests fail when run as root.

Hi folks, Looking for a codereview for a spec change in jdk8. In summary, when a java application is run as root it can perform file operations regardless of the permissions attributed to that file. I.e. canExecute, canRead, canWrite would return true even though the File may not have those p

hg: jdk8/tl/jdk: 7190945: pkcs11 problem loading NSS libs on Ubuntu

Changeset: 5e5bdfd18325 Author:vinnie Date: 2012-08-13 14:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e5bdfd18325 7190945: pkcs11 problem loading NSS libs on Ubuntu Reviewed-by: xuelei, alanb ! src/share/classes/sun/security/pkcs11/Secmod.java ! test/sun/security/pkcs

hg: jdk8/tl/jdk: 7190254: NetworkInterface getFlags implementation should support full integer bit range for flags value

Changeset: 399c2adf3ad6 Author:chegar Date: 2012-08-13 13:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/399c2adf3ad6 7190254: NetworkInterface getFlags implementation should support full integer bit range for flags value Reviewed-by: chegar Contributed-by: Shirish Kuncol

Re: Code review request 7190219 CharBuffer position changed after BufferOverflowException in put()

On 08/13/2012 06:41 PM, Alan Bateman wrote: On 13/08/2012 09:26, Jonathan Lu wrote: Hello Alan, Thanks for reviewing, I've updated the webrev, could you please take a look? http://cr.openjdk.java.net/~luchsh/7190219_2/ : In the updated webrev, I'm using relGet() to perform the content chec

hg: jdk8/tl/jdk: 7190219: (bf) CharBuffer.put(String, int, int) modifies position even if BufferOverflowException thrown

Changeset: bf0c6f91bc22 Author:luchsh Date: 2012-08-13 19:51 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf0c6f91bc22 7190219: (bf) CharBuffer.put(String,int,int) modifies position even if BufferOverflowException thrown Reviewed-by: alanb ! src/share/classes/java/nio/X-B

Re: Code review request 7190219 CharBuffer position changed after BufferOverflowException in put()

On 13/08/2012 09:26, Jonathan Lu wrote: Hello Alan, Thanks for reviewing, I've updated the webrev, could you please take a look? http://cr.openjdk.java.net/~luchsh/7190219_2/ : In the updated webrev, I'm using relGet() to perform the content checking after put(). And I also updated all the

Re: [PATCH] Review Request for bug 7132247 java/rmi/registry/readTest/readTest.sh failing with Cygwin

On 13/08/2012 10:30, Eric Wang wrote: Hi Alan, Please help to review the below fix for** bug 7132247 java/rmi/registry/readTest/readTest.sh failing with Cygwin. http://dl.dropbox.com/u/90659131/fixes/7132247/webrev/index.html Root cause of

[PATCH] Review Request for bug 7132247 java/rmi/registry/readTest/readTest.sh failing with Cygwin

Hi Alan, Please help to review the below fix for** bug 7132247 java/rmi/registry/readTest/readTest.sh failing with Cygwin. http://dl.dropbox.com/u/90659131/fixes/7132247/webrev/index.html Root cause of this bug is: 1. CYGWIN doesn't handle "

Re: Code review request 7190219 CharBuffer position changed after BufferOverflowException in put()

Hello Alan, Thanks for reviewing, I've updated the webrev, could you please take a look? http://cr.openjdk.java.net/~luchsh/7190219_2/ On 08/09/2012 09:28 PM, Alan Bateman wrote: On 09/08/2012 13:16, Jonathan Lu wrote: Hi folks, Here's a patch for bug 7190219, could you please help to have a