On 8/29/2012 7:07 PM, Stuart Marks wrote:
On 8/29/12 4:56 PM, Joe Darcy wrote:
On 8/29/2012 4:20 PM, Stuart Marks wrote:
The original code was like this:
427 private static int getMask(String actions) {
...
435 // Check against use of constants (used heavily
Alan, Paul,
While I was writing a summery as you suggested below, I noticed an issue
with using ServiceLoader. I was trying to use the word 'delegate' but
found the ServiceLoader might be doing sth. different than the original
jaxp process.
Here's the spec:
The ServiceLoader.load(service)
Hi Joe,
On Aug 30, 2012, at 1:08 AM, Joe Wang huizhe.w...@oracle.com wrote:
I actually updated the webrev yesterday with your suggestion.
OK! Sorry if i am being stubbornly persistent!
Recall our discussions back in June, the suggestion was to delegate to the
ServiceLoader, e.g.
On Aug 30, 2012, at 1:33 AM, Joe Wang huizhe.w...@oracle.com wrote:
Paul, Alan,
Confusion was what jaxp meant to give :)
My eyes wobble when i look at all that class loading code!
I was told that the factory/object finders, security support classes were
duplicated, and needed to be
On 08/29/2012 11:53 PM, Stuart Marks wrote:
On 8/29/12 8:48 AM, Andrew Hughes wrote:
But presumably [-Werror] would be removed when everything is warning free?
-Werror should not be the default for everyone building OpenJDK, who then
end up having to fix or workaround issues which are
On Aug 30, 9:17am, a...@redhat.com (Andrew Haley) wrote:
-- Subject: Re: Review Request: 7193406 - Clean-up JDK Build Warnings in java
| -Werror is probably OK for Java code, but not for HotSpot.
|
| We GCC developers keep adding new warnings, so poor souls who keep
| up-to-date with new Fedora
On 30/08/2012 03:01, Stuart Marks wrote:
Hi Alan,
I'm opening another front in the war against test failures. Please
review these additions to the problem list.
Thanks.
s'marks
I see you've got bugs for each of these so looks okay to me.
BTW: On EagerHttpFallback.java, I've seen that
bug report should be live shortly :
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7195063
The introduction of a new corba testcase in recent past is showing up as
a random failure on our internal build/test harness (JPRT).
===
-
Changeset: cf492d1199dc
Author:dxu
Date: 2012-08-30 12:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf492d1199dc
7193710: ByteArrayOutputStream Javadoc contains unclosed code element
Reviewed-by: dholmes, alanb, ulfzibis
!
On 08/29/2012 09:11 PM, Dan Xu wrote:
On 08/29/2012 08:27 AM, Joe Darcy wrote:
Hello,
On 8/29/2012 1:48 AM, Rémi Forax wrote:
On 08/29/2012 08:33 AM, Kurchi Subhra Hazra wrote:
Thanks for cleaning up those spaces Dan. The changes look fine.
Sorry for the extra trouble!
- Kurchi
On 8/28/12
On 08/30/2012 01:39 AM, Dan Xu wrote:
On 08/29/2012 12:11 PM, Dan Xu wrote:
On 08/29/2012 08:27 AM, Joe Darcy wrote:
Hello,
On 8/29/2012 1:48 AM, Rémi Forax wrote:
On 08/29/2012 08:33 AM, Kurchi Subhra Hazra wrote:
Thanks for cleaning up those spaces Dan. The changes look fine.
Sorry for
On 29/08/2012 22:47, Dan Xu wrote:
Thanks for your comments. I have updated my fix and posted at,
http://cr.openjdk.java.net/~dxu/7193710/webrev.01/.
I think the effort to upgrade to use new tags is out of the scope of
this fix and will be addressed against the whole JDK in one chunk later.
Am 30.08.2012 01:39, schrieb Dan Xu:
I have updated my fix with above suggestions. Thanks for your comments. The webrev is at
http://cr.openjdk.java.net/~dxu/7193406/webrev.04/. Thanks!
-Dan
- * @param action the action string.
+ * @param actions the action string.
I think you
Oops, sorry about the noise. I was wrong :-(
-Ulf
Am 30.08.2012 14:33, schrieb Ulf Zibis:
Am 30.08.2012 01:39, schrieb Dan Xu:
I have updated my fix with above suggestions. Thanks for your comments. The webrev is at
http://cr.openjdk.java.net/~dxu/7193406/webrev.04/. Thanks!
-Dan
-
Am 30.08.2012 01:03, schrieb Stuart Marks:
On 8/29/12 3:50 AM, Ulf Zibis wrote:
In FilePermission.java file, I make one change to its method
signature,
public Enumeration elements() == public EnumerationPermission
elements()
Actually the whole method is synchronized. To make this
Am 30.08.2012 08:23, schrieb Joe Darcy:
On 8/29/2012 7:07 PM, Stuart Marks wrote:
On 8/29/12 4:56 PM, Joe Darcy wrote:
On 8/29/2012 4:20 PM, Stuart Marks wrote:
The various SecurityConstants being used here are Strings.
Note that this is doing String comparisons using == which is usually a
Am 30.08.2012 01:20, schrieb Stuart Marks:
On 8/29/12 4:36 AM, Ulf Zibis wrote:
@SuppressWarnings(fallthrough) is put to suppress warnings generated by
another switch/case statements
Can't you move it from method scope to there?
while (i = matchlen !seencomma) {
On 30/08/2012 00:08, Joe Wang wrote:
I actually updated the webrev yesterday with your suggestion.
Can you send a link? I checked the original location [1] but it's
doesn't seem to have updated since Monday evening.
-Alan
[1] http://cr.openjdk.java.net/~joehw/jdk8/7169894/
Hi Remi,
On 8/30/2012 5:06 AM, Rémi Forax wrote:
On 08/29/2012 09:11 PM, Dan Xu wrote:
On 08/29/2012 08:27 AM, Joe Darcy wrote:
Hello,
On 8/29/2012 1:48 AM, Rémi Forax wrote:
On 08/29/2012 08:33 AM, Kurchi Subhra Hazra wrote:
Thanks for cleaning up those spaces Dan. The changes look fine.
On Aug 30, 2012, at 8:59 AM, Joe Wang huizhe.w...@oracle.com wrote:
Alan, Paul,
While I was writing a summery as you suggested below, I noticed an issue with
using ServiceLoader. I was trying to use the word 'delegate' but found the
ServiceLoader might be doing sth. different than the
On 8/30/12 1:17 AM, Andrew Haley wrote:
On 08/29/2012 11:53 PM, Stuart Marks wrote:
On 8/29/12 8:48 AM, Andrew Hughes wrote:
But presumably [-Werror] would be removed when everything is warning free?
-Werror should not be the default for everyone building OpenJDK, who then
end up having to fix
Changeset: 11bfec75d333
Author:lancea
Date: 2012-08-30 13:38 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11bfec75d333
7193683: DriverManager Iterator Warning cleanup
Reviewed-by: lancea
Contributed-by: Dan Xu dan...@oracle.com
!
Hi Paul, Alan,
I've read your latest comments. Before getting back to you on those
items, I felt it's important we get the classloader handling correctly.
If it's as what I suspected (as I described in the last email), we may
have problem with using ServiceLoader.
I've read Paul's
On 30/08/2012 19:38, Joe Wang wrote:
Hi Paul, Alan,
I've read your latest comments. Before getting back to you on those
items, I felt it's important we get the classloader handling
correctly. If it's as what I suspected (as I described in the last
email), we may have problem with using
Changeset: 0a2565113920
Author:mullan
Date: 2012-08-30 14:40 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a2565113920
6995421: Eliminate the static dependency to sun.security.ec.ECKeyFactory
Reviewed-by: mullan, vinnie
Contributed-by: stephen.flo...@oracle.com
!
Changeset: baf30df50ce3
Author:andrew
Date: 2012-08-23 15:42 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/baf30df50ce3
7192804: Build should not install jvisualvm man page for OpenJDK
Summary: OpenJDK builds don't ship VisualVM so shouldn't ship its man page
either.
Changeset: 6898d85cf0bb
Author:amurillo
Date: 2012-08-10 23:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6898d85cf0bb
7190772: new hotspot build - hs24-b21
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: d5ec46c7da5c
Author:amurillo
Date:
On 8/30/12 7:14 AM, Ulf Zibis wrote:
Am 30.08.2012 01:20, schrieb Stuart Marks:
On 8/29/12 4:36 AM, Ulf Zibis wrote:
@SuppressWarnings(fallthrough) is put to suppress warnings generated by
another switch/case statements
Can't you move it from method scope to there?
while (i =
On 8/30/12 2:23 AM, Alan Bateman wrote:
On 30/08/2012 03:01, Stuart Marks wrote:
Hi Alan,
I'm opening another front in the war against test failures. Please review
these additions to the problem list.
Thanks.
s'marks
I see you've got bugs for each of these so looks okay to me.
BTW: On
Changeset: f9b11772c4b2
Author:smarks
Date: 2012-08-30 18:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9b11772c4b2
7195099: update problem list with RMI test failures
Reviewed-by: alanb
! test/ProblemList.txt
30 matches
Mail list logo
