hg: jdk8/tl/jdk: 7196533: TimeZone.getDefault() slow due to synchronization bottleneck

2012-10-09 Thread sean . coffey
Changeset: fecba6a8b78e Author:coffeys Date: 2012-10-09 12:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fecba6a8b78e 7196533: TimeZone.getDefault() slow due to synchronization bottleneck Reviewed-by: okutsu ! src/share/classes/java/util/TimeZone.java

hg: jdk8/tl: 7173494: some jdk tests are not run in test/Makefile

2012-10-09 Thread alan . bateman
Changeset: 4bde5640fb36 Author:alanb Date: 2012-10-09 13:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4bde5640fb36 7173494: some jdk tests are not run in test/Makefile Reviewed-by: chegar, mchung, mduigou, iris ! make/jprt.properties ! test/Makefile

hg: jdk8/tl/jdk: 7173494: some jdk tests are not run in test/Makefile

2012-10-09 Thread alan . bateman
Changeset: 3b79177ebfef Author:alanb Date: 2012-10-09 13:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b79177ebfef 7173494: some jdk tests are not run in test/Makefile Reviewed-by: chegar, mchung, mduigou, iris ! make/jprt.properties ! test/Makefile !

hg: jdk8/tl/jdk: 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC

2012-10-09 Thread lance . andersen
Changeset: 036c55976cef Author:lancea Date: 2012-10-09 08:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC Reviewed-by: alanb, smarks !

Re: JAXP RFR: 8000172 : 2 SAX features does not work properly

2012-10-09 Thread Lance Andersen - Oracle
Look OK Joe On Oct 9, 2012, at 12:31 AM, Joe Wang wrote: This is an issue found while I was working with SQE to expand test coverage. For a non-validating parser, when load-external-dtd is false, entity references are skipped. However, the skippedEntity() event was not reported. The

Re: JAXP RFR: 8000172 : 2 SAX features does not work properly

2012-10-09 Thread Joe Wang
Thanks Lance! On 10/9/2012 7:55 AM, Lance Andersen - Oracle wrote: Look OK Joe On Oct 9, 2012, at 12:31 AM, Joe Wang wrote: This is an issue found while I was working with SQE to expand test coverage. For a non-validating parser, when load-external-dtd is false, entity references are

hg: jdk8/tl/jdk: 7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in some circumstances

2012-10-09 Thread naoto . sato
Changeset: c725ce4bbf12 Author:naoto Date: 2012-10-09 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c725ce4bbf12 7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in some circumstances Reviewed-by: okutsu !

Review Request: 7186817 - Remove Windows 95/98/ME Support

2012-10-09 Thread Dan Xu
Hi folks, Please help review the code change for CR7186817 to remove Windows 95/98/ME support. The webrev has been uploaded to http://cr.openjdk.java.net/~dxu/7186817/webrev/ http://cr.openjdk.java.net/%7Edxu/7186817/webrev/ The main focus of this clean-up is in IO area. And I also cleaned

RFR : 7196086 : update copyright years for files in corba repository (JDK 8)

2012-10-09 Thread Seán Coffey
steve.si...@oracle.com has contributed the following patch which I'd like to push to jdk8 TL. It's the correction of copyright years in corba repo. Need a reviewer. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7196086.jdk8/ http://cr.openjdk.java.net/%7Ecoffeys/webrev.7196086.jdk8/

hg: jdk8/tl/jdk: 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed

2012-10-09 Thread sean . coffey
Changeset: 71de5e31d497 Author:coffeys Date: 2012-10-09 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71de5e31d497 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed Reviewed-by: alanb, chegar !

Re: RFR : 7196086 : update copyright years for files in corba repository (JDK 8)

2012-10-09 Thread Lance Andersen - Oracle
looks fine Sean Best Lance On Oct 9, 2012, at 2:38 PM, Seán Coffey wrote: steve.si...@oracle.com has contributed the following patch which I'd like to push to jdk8 TL. It's the correction of copyright years in corba repo. Need a reviewer. webrev :

hg: jdk8/tl/corba: 7196086: update copyright years for files in corba repository (JDK 8)

2012-10-09 Thread sean . coffey
Changeset: 679e8ad9874f Author:coffeys Date: 2012-10-09 20:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/679e8ad9874f 7196086: update copyright years for files in corba repository (JDK 8) Reviewed-by: lancea ! make/common/Defs-bsd.gmk !

Re: Review Request: 7186817 - Remove Windows 95/98/ME Support

2012-10-09 Thread Alan Bateman
On 09/10/2012 18:46, Dan Xu wrote: Hi folks, Please help review the code change for CR7186817 to remove Windows 95/98/ME support. The webrev has been uploaded to http://cr.openjdk.java.net/~dxu/7186817/webrev/ http://cr.openjdk.java.net/%7Edxu/7186817/webrev/ The main focus of this

Re: Review Request: 7186817 - Remove Windows 95/98/ME Support

2012-10-09 Thread Ulf Zibis
Hi, I did not look into the details, but the hint about performance on String.toLower in WindowsNTFileSystem catched my attention. Here is a very fast converter, which may be enough for calculating the hash: // Private ASCII-only optimized version public static final String

Re: RFR: 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol]

2012-10-09 Thread Martin Buchholz
On Mon, Oct 8, 2012 at 2:24 PM, Rob McKenna rob.mcke...@oracle.com wrote: Thanks Martin, Updated webrev at: http://cr.openjdk.java.net/~robm/7152183/webrev.03/ The latest webrev looks correct to me - thanks! I'd also make a couple of pedantic cosmetic changes: 1969

Re: Review Request: 7186817 - Remove Windows 95/98/ME Support

2012-10-09 Thread Dan Xu
On 10/09/2012 12:30 PM, Alan Bateman wrote: On 09/10/2012 18:46, Dan Xu wrote: Hi folks, Please help review the code change for CR7186817 to remove Windows 95/98/ME support. The webrev has been uploaded to http://cr.openjdk.java.net/~dxu/7186817/webrev/

Re: Review Request: 7186817 - Remove Windows 95/98/ME Support

2012-10-09 Thread Dan Xu
Hi Ulf, I think it is better to focus on the clean-up for my current transaction. The performance improvement of toUpper() method can be another topic for String class. Thanks, -Dan On 10/09/2012 12:31 PM, Ulf Zibis wrote: Hi, I did not look into the details, but the hint about

hg: jdk8/tl/jaxp: 8000172: 2 SAX features does not work properly

2012-10-09 Thread huizhe . wang
Changeset: 53a2a4893c8f Author:joehw Date: 2012-10-09 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/53a2a4893c8f 8000172: 2 SAX features does not work properly Summary: When external dtd is not loaded, skippedEntity event should be reported for entity references.

Re: Review Request: 7186817 - Remove Windows 95/98/ME Support

2012-10-09 Thread Ulf Zibis
Thanks Zhong, you are correct. So we additionally can save again 1 variable and 2 lines. -Ulf Am 09.10.2012 23:08, schrieb Zhong Yu: Ulf, since allUpper == ca==null we don't need allUpper... On Tue, Oct 9, 2012 at 2:31 PM, Ulf Zibis ulf.zi...@cosoco.de wrote: Hi, I did not look

hg: jdk8/tl/langtools: 8000663: clean up langtools imports

2012-10-09 Thread jonathan . gibbons
Changeset: c75be5bc5283 Author:jjg Date: 2012-10-09 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c75be5bc5283 8000663: clean up langtools imports Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/CompilationUnitTree.java !