Re: TreeMap.putAll has undocumented behavior which has different side effect based on parameter

2012-10-15 Thread David Holmes
Hi Sean, On 15/10/2012 1:50 PM, Sean Chou wrote: Hi all, It is found TreeMap.putAll method may or may not invoke TreeMap.put method based on parameter. If TreeMap is extended and the put method is override, it may behave different from what is expected. This behavior should be

Re: CloneNotSupportedException should extends RuntimeException not Exception

2012-10-15 Thread Remi Forax
On 10/15/2012 12:34 AM, David Holmes wrote: Remi, This ship has sailed you can't recall it. CloneNotSupportedException is a checked exception and needs to remain so for source and binary compatibility. yes, it burns into flame :) too bad, I'm pretty sure that no-one (until now) use a catch

Re: CloneNotSupportedException should extends RuntimeException not Exception

2012-10-15 Thread Joel Borggrén-Franck
On 10/15/2012 12:34 AM, David Holmes wrote: Remi, This ship has sailed you can't recall it. CloneNotSupportedException is a checked exception and needs to remain so for source and binary compatibility. I see how this is source incompatible and also behaviorally incompatible in a few

Re: CloneNotSupportedException should extends RuntimeException not Exception

2012-10-15 Thread Alan Bateman
On 15/10/2012 11:28, Joel Borggrén-Franck wrote: On 10/15/2012 12:34 AM, David Holmes wrote: Remi, This ship has sailed you can't recall it. CloneNotSupportedException is a checked exception and needs to remain so for source and binary compatibility. I see how this is source

Re: CloneNotSupportedException should extends RuntimeException not Exception

2012-10-15 Thread David Holmes
On 15/10/2012 8:56 PM, Alan Bateman wrote: On 15/10/2012 11:28, Joel Borggrén-Franck wrote: On 10/15/2012 12:34 AM, David Holmes wrote: Remi, This ship has sailed you can't recall it. CloneNotSupportedException is a checked exception and needs to remain so for source and binary

Re: CloneNotSupportedException should extends RuntimeException not Exception

2012-10-15 Thread Remi Forax
Hi Jeroen, On 10/15/2012 01:48 PM, Jeroen Frijters wrote: The solution is actually pretty easy. Just deprecate Object.clone() and add a new method to Object: protected final native Object shallowClone(); It doesn't require the useless Cloneable interface and doesn't conflate shallow and

Re: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods

2012-10-15 Thread Joe Darcy
Looks fine Roger; thanks, -Joe On 10/13/2012 9:21 AM, Roger Riggs wrote: Thanks for the comments and suggestions from Eamonn, Joe, and Bruce. The updates add the suggested text and note the special case for floorDiv(MIN_VALUE/-1). Updated webrev:

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-10-15 Thread Jim Gish
Here's an updated webrev that fixes some javadoc syntax issues: http://cr.openjdk.java.net/~jgish/Bug7159567-set-logging-MemoryHandler/ http://cr.openjdk.java.net/%7Ejgish/Bug7159567-set-logging-MemoryHandler/ Thanks, Jim On 10/11/2012 05:37 PM, Jim Gish wrote: Please review the updated

RE: CloneNotSupportedException should extends RuntimeException not Exception

2012-10-15 Thread Jeroen Frijters
Hi Rémi, The point about a non-final class being cloneable is simply that a base class can always implement Cloneable, so that interface is currently meaningless. With the static method approach, the Cloneable interface becomes a valid way to opt in to that, but I see two downsides to the

RE: CloneNotSupportedException should extends RuntimeException not Exception

2012-10-15 Thread Jeroen Frijters
I wrote: The point about a non-final class being cloneable is simply that a base class can always implement Cloneable, so that interface is currently meaningless. Obviously that should read ... a derived class can always implement Cloneable... Regards, Jeroen

hg: jdk8/tl/jdk: 8000487: Java JNDI connection library on ldap conn is not honoring configured timeout

2012-10-15 Thread rob . mckenna
Changeset: c0736b62160e Author:robm Date: 2012-10-15 22:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0736b62160e 8000487: Java JNDI connection library on ldap conn is not honoring configured timeout Reviewed-by: vinnie !

Re: about JavaOne2012 Finding and Solving Java Deadlocks

2012-10-15 Thread Mike Duigou
The session was a hands on lab so was not recorded that I can tell. Here's the official session page:

hg: jdk8/tl/langtools: 8000666: javadoc should write directly to Writer instead of composing strings

2012-10-15 Thread jonathan . gibbons
Changeset: 8db45b13526e Author:jjg Date: 2012-10-15 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8db45b13526e 8000666: javadoc should write directly to Writer instead of composing strings Reviewed-by: bpatel !

Re: Code Review Request: 7198073: (prefs) user prefs not saved [macosx]

2012-10-15 Thread Kurchi Hazra
Hi Alan, Please find an updated webrev with a test included: http://cr.openjdk.java.net/~khazra/7198073/webrev.01/ CheckUserPrefsStorage.sh is the main entry point - it runs CheckUserPrefFirst first (which creates and attempts to store a preference), and then runs CheckUserPrefLater