Re: RFR: 6519127 : user.home property not set correctly

2012-10-23 Thread Sean Chou
Hi Alan, I did some search and wrote a brief, hope it helps. = A brief about home directory, user profile directory, and My Documents directory of windows users. In windows NT and early, there is an assigned home directory act as a user's default folder

Re: RFR: 6519127 : user.home property not set correctly

2012-10-23 Thread Ulf Zibis
Hi, after studying many MSDN docs, I think you are right, to use CSIDL_PROFILE. And as I read ... * Note: To save space we want to avoid loading SHELL32.DLL * unless really necessary. However if we do load it, we leave it * in memory, as it may be needed again later. I'm pretty

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-23 Thread Alan Bateman
On 18/10/2012 03:10, Xueming Shen wrote: : webrev: http://cr.openjdk.java.net/~sherman/4235519/webrev I took another pass over this, focusing on the API as that is what we have to get right. Performance is important too but I think the priority has to be the API first. Overall I think it is

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-23 Thread Ulf Zibis
Am 23.10.2012 15:04, schrieb Alan Bateman: I'm not sure that getUrlEncoder is the most suitable name to get a base64url encoder. The reason is that the method name makes it sound like it returns a URLEncoder or or at least an encoder for HTML forms. While more verbose, getBase64UrlEncoder is

hg: jdk8/tl/jdk: 7197071: Makefiles for various security providers aren't including the default manifest

2012-10-23 Thread bradford . wetmore
Changeset: 940c8cc5a5c4 Author:wetmore Date: 2012-10-23 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/940c8cc5a5c4 7197071: Makefiles for various security providers aren't including the default manifest Reviewed-by: valeriep, mullan, katleman !

hg: jdk8/tl/langtools: 8000416: refactor javadoc to provide and use an abstraction for relative URIs

2012-10-23 Thread jonathan . gibbons
Changeset: 4a1c57a1c410 Author:jjg Date: 2012-10-23 13:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a1c57a1c410 8000416: refactor javadoc to provide and use an abstraction for relative URIs Reviewed-by: darcy !

hg: jdk8/tl/jdk: 8001419: Build the JCE portion of JDK-8000970

2012-10-23 Thread bradford . wetmore
Changeset: 13b46e8eda33 Author:ohrstrom Date: 2012-10-23 15:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13b46e8eda33 8001419: Build the JCE portion of JDK-8000970 Summary: Original code done by Fredrik Ohrstrom, separated/pushed by wetmore Reviewed-by: wetmore !

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-23 Thread Xueming Shen
Hi Alan, Thanks for the review. I hope I addressed most of the comments in the updated webrev at http://cr.openjdk.java.net/~sherman/4235519/webrev mainly (1) Pulled the base64 terms up to the class doc and then be referenced from various methods (2) Gave up the C style de/encode(byte[],

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-23 Thread Xueming Shen
On 10/23/2012 8:50 PM, Mike Duigou wrote: I'm eager to use this! Some comments: -ttcode/tt is used in some places rather than {@code } fixed - The initialul would perhaps be better as adl. I don't know if definition lists are allowed in javadoc. - public OutputStream wrap(OutputStream