In preparation to a re-sync of the java.util.concurrent classes with
Doug's CVS, I've extracted most of the minor/small changes. This will
reduce the noise when reviewing the remainder of the implementation
changes. More specifically,
Cleanup:
javadoc style/consistency
javadoc example
OK. One more time.
http://cr.openjdk.java.net/~jgish/Bug7159567-set-logging-MemoryHandler
I compromised with the RuntimeException. I'm instead catching it, but
throwing a new one this way:
65 throw new RuntimeException(
66 Test Failed: did not load
On 10/25/2012 10:25 AM, Jim Gish wrote:
OK. One more time.
http://cr.openjdk.java.net/~jgish/Bug7159567-set-logging-MemoryHandler
Great, thanks! I'll push it for you.
I compromised with the RuntimeException. I'm instead catching it, but
throwing a new one this way:
65
Changeset: c002fdee76fd
Author:jjg
Date: 2012-10-25 11:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c002fdee76fd
7200915: convert TypeTags from a series of small ints to an enum
Reviewed-by: jjg, mcimadamore
Contributed-by: vicente.rom...@oracle.com
!
Changeset: ea2616a6bd01
Author:jjg
Date: 2012-10-25 13:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea2616a6bd01
6725230: Java Compilation with Jsr199 ignores Class-Path in manifest
Reviewed-by: jjg, mcimadamore
Contributed-by: vicente.rom...@oracle.com
!
Hi,
Please review the code change to avoid native codes when creating the
FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/.
In the change, the native codes for windows and unix platforms are
removed. Instead, corresponding Java codes are added for each platform.
Thanks!
Hi,
Please help review the javadoc typo fix at,
http://cr.openjdk.java.net/~dxu/8001565/webrev/. Thanks!
-Dan
This fix is fine Dan
Best
Lance
On Oct 25, 2012, at 5:45 PM, Dan Xu wrote:
Hi,
Please help review the javadoc typo fix at,
http://cr.openjdk.java.net/~dxu/8001565/webrev/. Thanks!
-Dan
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1
On 10/25/2012 2:45 PM, Dan Xu wrote:
Hi,
Please help review the javadoc typo fix at,
http://cr.openjdk.java.net/~dxu/8001565/webrev/. Thanks!
Looks good with me. I can push this for you.
Mandy
Looks good to me.
Jim
On 10/25/2012 05:26 PM, Dan Xu wrote:
Hi,
Please review the code change to avoid native codes when creating the
FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/.
In the change, the native codes for windows and unix platforms are
removed. Instead,
Fine and Dandy :-)
...Jim
On 10/25/2012 05:45 PM, Dan Xu wrote:
Hi,
Please help review the javadoc typo fix at,
http://cr.openjdk.java.net/~dxu/8001565/webrev/. Thanks!
-Dan
--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries
Thank you. Do you need me to generate the patch?
-Dan
On 10/25/2012 03:12 PM, Mandy Chung wrote:
On 10/25/2012 2:45 PM, Dan Xu wrote:
Hi,
Please help review the javadoc typo fix at,
http://cr.openjdk.java.net/~dxu/8001565/webrev/. Thanks!
Looks good with me. I can push this for you.
I have your patch from the webrev.
Mandy
On 10/25/2012 3:17 PM, Dan Xu wrote:
Thank you. Do you need me to generate the patch?
-Dan
On 10/25/2012 03:12 PM, Mandy Chung wrote:
On 10/25/2012 2:45 PM, Dan Xu wrote:
Hi,
Please help review the javadoc typo fix at,
Hi Chris,
You can count me as a reviewer anyway. :)
A couple of observations:
--- old/src/share/classes/java/util/concurrent/ExecutionException.java
Thu Oct 25 14:14:15 2012
+++ new/src/share/classes/java/util/concurrent/ExecutionException.java
Thu Oct 25 14:14:14 2012
@@ -79,11 +79,9 @@
Looks good to me.
I have to wonder why we ever used a native method to invoke a Java
constructor though ???
David
On 26/10/2012 7:26 AM, Dan Xu wrote:
Hi,
Please review the code change to avoid native codes when creating the
FileSystem object,
15 matches
Mail list logo
