On 14/11/2012 05:26, Jonathan Gibbons wrote:
See http://cr.openjdk.java.net/~jjg/8000404/webrev/
A while back, we added a new annotation
javax.tools.GenerateNativeHeader, to mark classes that contained
constants of interest to native code, such that tools, like javac with
the -h option,
On Nov 14, 2012, at 2:19 AM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
I apologize for the quick turnaround from the second review request [1] but
I've updated the webrev again:
http://cr.openjdk.java.net/~mduigou/8001634/4/webrev/
Looks good to me.
Blame a busy Paul
On 11/14/2012 05:34 AM, Jonathan Lu wrote:
Hi Sean,
Patch pushed @ http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83765e82cacb
Could you please verify?
Looks fine to me.
-Chris.
Thanks regards
Jonathan
On 11/14/2012 10:23 AM, Sean Chou wrote:
Thanks Alan and Chris.
On Tue, Nov 13, 2012
On 13/11/2012 22:50, Brent Christian wrote:
At present, the JDK port for OS X gets its value for os.name from a
JRS function exported by the Apple Java Runtime Support framework.
Historically this has either been Mac OS X, or Mac OS X Server,
but there have been reports that this could change
On 14 November 2012 04:09, Henry Jen henry@oracle.com wrote:
This is a change set regarding Comparator already in lambda repo, it
depends on the CR#8001634, particularly the Function SAMs.
It implements proposed extension methods on Comparator
(reverse and compose) as well as static
On 13 November 2012 19:05, Mike Duigou mike.dui...@oracle.com wrote:
- Mapper.map becomes Function.apply
- Factory.make becomes Supplier.get
- Specializations of Supplier for int, long, double
- Reorder type variables to put result last
- Fixes many javadoc and stylistic comments.
What
On 13/11/2012 21:30, Jim Gish wrote:
Here's a new webrev with my latest changes for your reviewing pleasure :-)
http://cr.openjdk.java.net/~jgish/Bug6244047-FileHandler-CheckLockLocation/
http://cr.openjdk.java.net/%7Ejgish/Bug6244047-FileHandler-CheckLockLocation/
Main changes:
- Using the
On 13/11/2012 10:16, Staffan Larsen wrote:
This is a request for review for adding tracing to I/O calls. For now, this is
an empty infrastructure intended to enable diagnosing/tracing of i/o calls. A
user of the API can register a callback for read and write operations on
sockets and files.
Changeset: 0f54a98f9bc9
Author:alanb
Date: 2012-11-14 12:56 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f54a98f9bc9
8003285: TEST_BUG: java/nio/channels/AsynchronousChannelGroup/Unbounded.java
fails again [macosx]
Reviewed-by: chegar
!
Changeset: 369709a13823
Author:jjg
Date: 2012-11-14 07:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/369709a13823
8000404: rename javax.tools.GenerateNativeHeader to java.lang.annotation.Native
Reviewed-by: alanb
+ src/share/classes/java/lang/annotation/Native.java
Changing String.substring() from O(1) to O(n) is a big deal; we may
say it breaks compatibility.
Any code that intends to work across JDK versions before and after 7u6
cannot use the method, since its behavior is so different in different
versions.
Any deployment that upgrades JDK to 7u6 and
The new implementation also introduces a new form of memory leak.
Previously N substrings take O(N) space. Now it takes O(N*m) space
where m is the average length of substrings.
Some applications may be double penalized by the new implementation -
both CPU and memory go up.
On Wed, Nov 14, 2012
On 14/11/2012 01:19, Mike Duigou wrote:
Hello all;
I apologize for the quick turnaround from the second review request [1] but
I've updated the webrev again:
http://cr.openjdk.java.net/~mduigou/8001634/4/webrev/
Blame a busy Paul Sandoz who his making significant progress on the primitive
Hi Zhong Yu,
I agree with you that changing the implementation of something
like String.substring which is widely used is something that is always a
little hairy.
The memory leak you mention is one side of the problem, the other is that
we want the VM to do memory collocation of String (i.e.
On 14/11/2012 16:06, Remi Forax wrote:
Now, I don't know why this change was backported to a jdk update,
but it's more a question to the jdk7 update mailing list.
It was to offset the addition of the hash32 field.
-Alan.
The issue is primarily when one class wants to implement more than one
functional interface. If the names collide then the class will only be able to
implement one of the interfaces.
Mike
On Nov 14 2012, at 07:12 , Craig P. Motlin wrote:
What's the issue with both methods being named apply?
Changeset: e24123de581c
Author:mduigou
Date: 2012-11-13 20:02 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e24123de581c
7088952: Add size in bytes constant BYTES to primitive type wrapper types
Summary: Adds a constant BYTES to each of the primitive wrapper classes (Byte,
Looks good to me.
-kto
On Nov 13, 2012, at 9:26 PM, Jonathan Gibbons wrote:
See http://cr.openjdk.java.net/~jjg/8000404/webrev/
A while back, we added a new annotation javax.tools.GenerateNativeHeader, to
mark classes that contained constants of interest to native code, such that
tools,
Thanks for the detailed review, Alan. Comments inline.
On 14 nov 2012, at 13:50, Alan Bateman alan.bate...@oracle.com wrote:
On 13/11/2012 10:16, Staffan Larsen wrote:
This is a request for review for adding tracing to I/O calls. For now, this
is an empty infrastructure intended to enable
Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001533
Webrev:
http://cr.openjdk.java.net/~ddehaven/8001533/webrev.0/
This change adds support in the Java launcher to launch JavaFX applications
directly (without the aid of launcher code injected by javafxpackager). This is
Hello all;
A small but useful performance fix for sub-maps of TreeMap:
http://cr.openjdk.java.net/~mduigou/7175464/0/webrev/
The entrySetView was not being cached.
There is no unit test because either implementation is permissible under the
specification. The fix only has the effect of
Changeset: f14c693a0e48
Author:jjg
Date: 2012-11-14 10:07 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f14c693a0e48
8003412: javac needs to understand java.lang.annotation.Native
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/code/Symtab.java
!
As to the default locale detection, we need to call JavaRuntimeSupport.
MacOSX's POSIX calls do not return user's preferred language/format
settings.
Naoto
On 11/14/12 1:59 AM, Alan Bateman wrote:
On 13/11/2012 22:50, Brent Christian wrote:
At present, the JDK port for OS X gets its value
Or when one functional interface wants to extend another, such as
IntBlock extends BlockInteger
On 11/14/2012 12:12 PM, Mike Duigou wrote:
The issue is primarily when one class wants to implement more than one
functional interface. If the names collide then the class will only be able to
Why not just use CFLocale and call CFLocaleCopyCurrent?
https://developer.apple.com/library/mac/#documentation/CoreFoundation/Reference/CFLocaleRef/Reference/reference.html#//apple_ref/c/func/CFLocaleCopyCurrent
-DrD-
As to the default locale detection, we need to call JavaRuntimeSupport.
Hello all;
This patch causes the indexOf and lastIndexOf implementation in
AbstractStringBuilder to directly compare the character arrays rather than
making a copy of the substring before comparing.
http://cr.openjdk.java.net/~mduigou/6553074/0/webrev/
On Nov 14, 2012, at 1:59 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 13/11/2012 22:50, Brent Christian wrote:
At present, the JDK port for OS X gets its value for os.name from a JRS
function exported by the Apple Java Runtime Support framework.
Historically this has either been Mac
We do use CFLocale for the default format locale detection, which is
used for formatting Date/Time/Number etc. Users can specify different
language from it for the UI language, such as menu/button/etc, which can
(I think) only be retrieved with that JRS function.
Naoto
On 11/14/12 10:21 AM,
Check out the latest, please --
http://cr.openjdk.java.net/~jgish/Bug6244047-FileHandler-CheckLockLocation/
http://cr.openjdk.java.net/%7Ejgish/Bug6244047-FileHandler-CheckLockLocation/
-- If it's ok, please push it or let me know who to have do it?
Thanks,
Jim
BTW I was expecting that
Please review
http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/
http://cr.openjdk.java.net/%7Ejgish/Bug8003380-logging-test-warnings/
These are simple changes to eliminate compiler warnings from
java.util.logging test code.
Thanks,
Jim
--
Jim Gish | Consulting Member
Mike,
In String.java, with the new methods you're adding, should we make those
String target parameters a CharSequence instead?
Thanks,
Jim
On 11/14/2012 01:27 PM, Mike Duigou wrote:
Hello all;
This patch causes the indexOf and lastIndexOf implementation in
AbstractStringBuilder to
Thanks, Sergey.
It's good that we standardized on the recommended usage within the JDK
in order to stay ahead of a possible change to the value of ProductName
in /System/Library/CoreServices/SystemVersion.plist
But we can expect that Java application developers use the same variety
of OS
looks Ok.
On Nov 14, 2012, at 4:15 PM, Jim Gish wrote:
Please review
http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/
http://cr.openjdk.java.net/%7Ejgish/Bug8003380-logging-test-warnings/
These are simple changes to eliminate compiler warnings from
java.util.logging
On 14/11/2012 20:56, Jim Gish wrote:
Check out the latest, please --
http://cr.openjdk.java.net/~jgish/Bug6244047-FileHandler-CheckLockLocation/
http://cr.openjdk.java.net/%7Ejgish/Bug6244047-FileHandler-CheckLockLocation/
-- If it's ok, please push it or let me know who to have do it?
I think
On 11/14/2012 04:38 PM, Alan Bateman wrote:
On 14/11/2012 20:56, Jim Gish wrote:
Check out the latest, please --
http://cr.openjdk.java.net/~jgish/Bug6244047-FileHandler-CheckLockLocation/
http://cr.openjdk.java.net/%7Ejgish/Bug6244047-FileHandler-CheckLockLocation/
-- If it's ok, please
On 14/11/2012 18:26, Mike Swingler wrote:
:
JavaRuntimeSupport.framework was explicitly created to make API for OpenJDK and
3rd party JVMs to do everything that the Apple Java SE 6 did using private SPI.
To prove that it worked, we re-implemented Java SE 6 on top of it. It's purpose
is to
Implementing more than one of the functional interfaces sounds like a bad
idea; making it difficult or impossible to do is a *good *thing. Use apply
everywhere to prevent things like Shimmer implements FloorWax,
DessertTopping.
Does anyone have any compelling example of why you actually might
Changeset: e6b1abdc11ca
Author:rfield
Date: 2012-11-13 08:06 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e6b1abdc11ca
8003306: Compiler crash: calculation of inner class access modifier
Summary: Fix binary sense lost in transition to hasTag
Reviewed-by: mcimadamore
Hi!
This is a review request to add only the test case for the following
OracleJDK issue:
[ 7198904 : (alt-rt) TreeMap.clone is broken ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198904
The issue (root cause) is not in OpenJDK (i.e. the problem was OracleJDK
specific), but the
I'm sorry if I missed this, but I can't seem to find any information about
what happened to the RFE provide process ID [1]. This umbrella bug
report/RFE is marked as 'fixed', but I can't see that the getPid part is
included in the current build of JDK8 (build 62).
The process destroy/getPid RFE
What's the issue with both methods being named apply?
On Tue, Nov 13, 2012 at 2:05 PM, Mike Duigou mike.dui...@oracle.com wrote:
The name Block.apply currently conflicts with Function.apply and should be
renamed.
Changeset: a65971893c50
Author:rfield
Date: 2012-10-29 10:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a65971893c50
8000694: Add generation of lambda implementation code: invokedynamic call,
lambda method, adaptor methods
Summary: Add lambda implementation code
Great rate of progress on this - well done.
The package Javadoc still needs some work.
Sent from my iPad
On 14/11/2012, at 1:19 AM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
I apologize for the quick turnaround from the second review request [1] but
I've updated the webrev
On 06/03/2012 11:35 PM, Mike Duigou wrote:
[I trimmed the distribution list]
On Jun 3 2012, at 13:44 , Peter Levart wrote:
On Thursday, May 31, 2012 03:22:35 AM mike.duigou at oracle.com wrote:
Changeset: 2c773daa825d
Author:mduigou
Date: 2012-05-17 10:06 -0700
URL:
General Comment
=
For the collections framework there is a description of the whole framework
(http://docs.oracle.com/javase/7/docs/technotes/guides/collections/index.html);
why not do the same for the lambda framework and put a reference to the
description in all the interfaces'
(bcc'ing core-libs-dev@)
Looks like this is related to 6981400. I'm CC'ing Anton to take a look
at it.
--
best regards,
Anthony
On 11/7/2012 2:58 PM, Weijun Wang wrote:
I've just synced with jdk7u-dev and now it does not build.
symbol: class TimedWindowEvent
location: class
Redirecting the review request to core-libs-dev@openjdk.java.net mail
list...
Here is the webrev based on the jdk8/tl/jdk repository:
http://cr.openjdk.java.net/~jiangli/7197210/webrev.02/
The '-XX:+IgnoreUnrecognizedVMOptions -XX:-VerifyDependencies' options
are added to following tests
Changeset: 6302932b7380
Author:rfield
Date: 2012-10-25 17:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6302932b7380
8000806: Implement runtime lambda metafactory
Summary: Implement lambda invokedynamic bootstrap by generating at runtime an
inner class that implements
Interesting... fixing warnings in tests. A few comments.
- LoggingMXBeanTest2.java
ListIterator? - ListIteratorString and remove redundant cast ?
- @SuppressWarnings(unused) Eclipse???
Do we have precedent for adding these suppressions??
- ClassLoaderLeakTest
Why the change to use
On 11/14/2012 05:44 PM, Chris Hegarty wrote:
Interesting... fixing warnings in tests. A few comments.
Right -- one might consider it overkill sine the warnings don't show up
in normal testing, but they do show up in Eclipse. Just plain annoying.
- LoggingMXBeanTest2.java
ListIterator? -
I've updated the webrev with your suggestion. Here it is:
http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/
http://cr.openjdk.java.net/%7Ejgish/Bug8003380-logging-test-warnings/
Could someone please push it?
Thanks,
Jim
On 11/14/2012 05:48 PM, Jim Gish wrote:
On
Personally, I feel like the concern is a bit overstated:
1) the n in O(n) is likely actually fairly small in practice (at least in
what I'd consider sane code)
2) I think a lot of people that worry about perf probably aren't using
substring() anyway
3) copying char[] is optimized by jit - this is
Changeset: e20ffc02e437
Author:erikj
Date: 2012-11-03 16:15 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/e20ffc02e437
8002183: Increased max number of paths to list in ListPathsSafely to 16000.
Reviewed-by: ohair
! common/makefiles/MakeBase.gmk
Changeset: ed9e5635fc80
Changeset: 5cf3c69a93d6
Author:katleman
Date: 2012-11-08 11:51 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5cf3c69a93d6
Added tag jdk8-b64 for changeset 27ab79568c34
! .hgtags
Changeset: 5132f7900a8f
Author:katleman
Date: 2012-11-08 11:50 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5132f7900a8f
Added tag jdk8-b64 for changeset 54d599a5b4aa
! .hgtags
Changeset: fbe54291c9d3
Author:katleman
Date: 2012-11-08 11:51 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/fbe54291c9d3
Added tag jdk8-b64 for changeset 5ded18a14bcc
! .hgtags
Changeset: 49bc14aaadcc
Author:katleman
Date: 2012-11-08 11:51 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/49bc14aaadcc
Added tag jdk8-b64 for changeset 5920f72e799c
! .hgtags
Changeset: ca8168203393
Author:amurillo
Date: 2012-11-02 07:44 -0700
URL:
Changeset: 056d828ac1e1
Author:katleman
Date: 2012-11-08 11:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/056d828ac1e1
Added tag jdk8-b64 for changeset e6ee43b3e247
! .hgtags
Changeset: 5f2faba89cac
Author:lana
Date: 2012-11-09 14:47 -0800
URL:
Changeset: 63726e5b90da
Author:erikj
Date: 2012-11-03 16:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63726e5b90da
8002220: build-infra: update for mac, solaris 11 issues
8002184: Fixed exclude and includes for jarsigner in new build
Reviewed-by: ohair
!
Hi Thomas,
Don't ask me why, but for some reason this mail just landed in my client
now. (this happens a lot on this mailing list for some reason)
getPid() is still on the todo list at the moment. Once I clear my plate
a little I'll follow up on it.
-Rob
On 26/10/12 10:02, Thomas L
Changeset: 33abf479f202
Author:jjg
Date: 2012-11-14 17:23 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/33abf479f202
7021614: extend com.sun.source API to support parsing javadoc comments
Reviewed-by: ksrini, strarup
! make/build.xml
+
Looks okay to me.
David
On 14/11/2012 11:38 PM, David Buck wrote:
Hi!
This is a review request to add only the test case for the following
OracleJDK issue:
[ 7198904 : (alt-rt) TreeMap.clone is broken ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198904
The issue (root cause) is not
Since this change is to achieve minor performance boost, it's not fair
to defend it by saying that it only incurs minor performance
penalties.
Java programs are infested with strings, most of which could have used
a more appropriate type, but it is the insane reality. Any change to
the behavior
Hi Mike,
On 15/11/2012 3:49 AM, Mike Duigou wrote:
Hello all;
A small but useful performance fix for sub-maps of TreeMap:
http://cr.openjdk.java.net/~mduigou/7175464/0/webrev/
The entrySetView was not being cached.
Seems a bug that entrySetView was never being set, but given that it
That's right, thanks.
On Wed, Nov 14, 2012 at 1:34 PM, Jonathan Lu luc...@linux.vnet.ibm.comwrote:
Hi Sean,
Patch pushed @
http://hg.openjdk.java.net/**jdk8/tl/jdk/rev/83765e82cacbhttp://hg.openjdk.java.net/jdk8/tl/jdk/rev/83765e82cacb
Could you please verify?
Thanks regards
Jonathan
This bug appears to have been present as far back as Java 6 when NavigableSet
was introduced. I could only check 6u33 but it seems unlikely to have been
broken during the course of Java 6 maintenance releases.
As these are views which pass through mutation to the parent object I believe
there
Hi Mike,
My original comment still stands regarding the wording in the Function
specializations versus all the others. Why does, for example,
IntFunction say this is the {@code int}-bearing specialization for
{@link Function}, yet IntBinaryOperator does not make a similar
statement regarding
67 matches
Mail list logo
