Hi Mike,
Minor typos and inconsistencies:
DoubleBinaryOperator.java
28 * Combines two {@code double} operands producing an {@code double}
result.
an -> a
51 * @param rightvalue used as the right operand
Need space after right
52 * @return result value of the operation
"resul
On Nov 14 2012, at 02:48 , Stephen Colebourne wrote:
> On 13 November 2012 19:05, Mike Duigou wrote:
>> - Mapper.map becomes Function.apply
>> - Factory.make becomes Supplier.get
>> - Specializations of Supplier for int, long, double
>> - Reorder type variables to put result last
>> - Fixes many
I have posted another revision at
http://cr.openjdk.java.net/~mduigou/8001634/5/webrev/
This version contains some method remaining in the {I|L|D}UnaryOperation and
{I|L|D}BinaryOperator and a few Javadoc fixes.
The package javadoc ie. package-info.java, is known to be a weak point right
now.
The reason is that {Int|Double|Long}Function take an object and yield a
primitive. Supplier, BinaryOperator, UnaryOperator and Block variants all
operate on the primitive type (or the boxed version) and don't utilize any
generic reference types. The only reference types used are the boxed versio
On 11/19/2012 6:43 PM, David DeHaven wrote:
I've read the other mails and I see that there are a number of discussion
points that needs to be resolved before the proposal can move forward.
Yes, we've been discussing offline to nail down the actual wants for this
feature.
After discussion and
>>> If Main-Class is always present with JavaFX-Application-Class, it may be no
>>> impact; but this seems to be unclear at this moment. Kevin can chime in
>>> here and looks like this requires more investigation before we continue the
>>> code review.
>> I've read the other mails and I see th
Am 19.11.2012 23:09, schrieb Mike Duigou:
On Nov 14 2012, at 13:24 , Jim Gish wrote:
Mike,
In String.java, with the new methods you're adding, should we make those String
target parameters a CharSequence instead?
A String param enables us to extract the internal char array for the search. We
Changeset: 2531de382983
Author:jjg
Date: 2012-11-19 16:40 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2531de382983
8003655: Add javac.jvm.ClassFile.V52
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java
Changeset: 522a1ee72340
Author:bpatel
Date: 2012-11-19 16:10 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/522a1ee72340
8002304: Group methods by types in methods summary section
Reviewed-by: jjg
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWri
I didn't attempt to evaluate that or refactor it in this round. Something for a
future patch. A simplification/refactoring patch for indexOf/lastIndexOf would
certainly be welcome.
Mike
On Nov 19 2012, at 13:12 , Ulf Zibis wrote:
> Hi,
>
> I'm wondering, if we still need
> 1739 static int
On Nov 14 2012, at 13:24 , Jim Gish wrote:
> Mike,
>
> In String.java, with the new methods you're adding, should we make those
> String target parameters a CharSequence instead?
A String param enables us to extract the internal char array for the search. We
could not do so with a CharSequenc
Hi,
I'm wondering, if we still need
1739 static int indexOf(char[] source, int sourceOffset, int sourceCount,
1740 char[] target, int targetOffset, int targetCount,
1741 int fromIndex) {
since bug 6924259: Remove offset and count fields from java.lang.String.
I guess
Changeset: c0f0c41cafa0
Author:jjg
Date: 2012-11-19 11:38 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0f0c41cafa0
8001098: Provide a simple light-weight "plug-in" mechanism for javac
Reviewed-by: mcimadamore
+ src/share/classes/com/sun/source/util/Plugin.java
! src
Hi Dave,
I hadn't yet given much thought to retiring the JavaFX-Application-Class
attribute, but I agree that it could be considered legacy if we do make
the change to the javafxpackager to drop it.
I just talked with Mandy about a couple of launcher questions that she
had relating to the ma
By amazing coincidence a review for fixing this was issued last week:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012266.html
Additional review would be welcome. :-)
The patch will probably be ready for push before the end of the month.
Mike
On Nov 19 2012, at 07:46 , Ma
On 19/11/2012 14:54, Alexey Utkin wrote:
Here is the updated version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.01/
In Foo.java then I assume Vector would be better.
I don't think you can remove the javax/script/** tests from the exclude
list without adding -Djava
>> If Main-Class is always present with JavaFX-Application-Class, it may be no
>> impact; but this seems to be unclear at this moment. Kevin can chime in
>> here and looks like this requires more investigation before we continue the
>> code review.
> I've read the other mails and I see that th
Hello all
I noticed that AbstractStringBuilder.indexOf(String, int) is implemented
as below:
public int indexOf(String str, int fromIndex) {
return String.indexOf(value, 0, count,
str.toCharArray(), 0, str.length(),
fromIndex);
}
The call to str
Here is the updated version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.01/
On 19.11.2012 16:26, Alan Bateman wrote:
On 19/11/2012 09:57, Alexey Utkin wrote:
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-7162111
Here is the suggested fix:
http://cr
Changeset: 3877706701b1
Author:alanb
Date: 2012-11-19 13:17 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3877706701b1
8003607: More ProblemList.txt updates (11/2012)
Reviewed-by: lancea
! test/ProblemList.txt
! test/TEST.ROOT
Looks fine
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
On Nov 19, 2012, at 7:47 AM, Alan Bateman wrote:
>
> I need a reviewer for a few miscellaneous updat
I need a reviewer for a few miscellaneous updates to the ProblemList.txt
file (the motive as always to get a clean test run of jdk8/tl). The
updates this time are:
1. Jaroslav Bachorík fixed a long standing timing issue in the RMI-IIOP
Tie classes generated by rmic so this allows us to liber
On 19/11/2012 11:15, Staffan Larsen wrote:
:
I think you are right that bytecode instrumentation would also work. The only
problem I see (apart from the path field) is the time it would take to develop
such a solution. I'm not sure if that is a good enough argument for keeping the
non-bytecode
On 19/11/2012 09:57, Alexey Utkin wrote:
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-7162111
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/
Thanks for taking this one on.
The change to JFrameCreateTime.java looks fine to me.
For tes
On 19 nov 2012, at 10:52, Alan Bateman wrote:
> On 15/11/2012 15:50, Staffan Larsen wrote:
>>
>> I now have some micro-benchmark numbers on windows and linux (the solaris
>> runs are not complete yet). While doing these runs we initially saw a
>> regression on the file reading benchmarks. Inv
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-7162111
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/
Summary:
Tests that are not changed and pass successfully (all tests run for jdk8):
---
On 15/11/2012 15:50, Staffan Larsen wrote:
I now have some micro-benchmark numbers on windows and linux (the
solaris runs are not complete yet). While doing these runs we
initially saw a regression on the file reading benchmarks.
Investigation showed that the compiler was not able to inline the
On 16/11/2012 19:55, Mandy Chung wrote:
If Main-Class is always present with JavaFX-Application-Class, it may
be no impact; but this seems to be unclear at this moment. Kevin can
chime in here and looks like this requires more investigation before
we continue the code review.
I've read the o
28 matches
Mail list logo
