Re: bottleneck by java.lang.Class.getAnnotations() - a better patch

2012-11-23 Thread Peter Levart
Hi again, I have found an inconsistency in the last patch I posted. Specifically the Method.getAnnotation(Class) and Constructor.getAnnotation(Class) did not delegate to the root instance as .getAnnotations() did. I corrected that in new revision of the patch: http://dl.dropbox.com/u/1017774

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-11-23 Thread Lance Andersen - Oracle
It is on my list. to update the javadocs I need a ccc which I have not done yet and is needed as part of this change On Nov 23, 2012, at 3:07 AM, Deven You wrote: > Hi Lance, > > Is there any plan for this issue, if any could you update to me? > > Thanks a lot! > On 10/29/2012 06:39 PM, Lance

Re: hg: jdk8/tl/jdk: 6924259: Remove offset and count fields from java.lang.String

2012-11-23 Thread Zhong Yu
I just realized that I also use String.trim() a lot, and have always assumed it's very cheap; that's no longer the case. JDK itself contains many usages of trim(); even a lot of str.substring().trim() Just saying. On Wed, Nov 14, 2012 at 9:14 AM, Zhong Yu wrote: > Changing String.substring

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alan Bateman
On 23/11/2012 11:40, Alexey Utkin wrote: I mean: # jdk_io -# 7162111 - these tests need to be updated to run headless -java/io/Serializable/resolveClass/deserializeButton/run.sh macosx-all -java/io/Serializable/serialver/classpath/run.sh macosx-all -java/io/Serializable/ser

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

2012-11-23 Thread Alan Bateman
On 22/11/2012 21:27, Rob McKenna wrote: Hi folks, Looking for a review for the webrev below, which also resolves: 7175692: (process) Process.exec should use posix_spawn [macosx] For additional context and a brief description it would be well worth looking at the following thread started by Mi

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alexey Utkin
On 23.11.2012 15:24, Alan Bateman wrote: On 23/11/2012 11:22, Alexey Utkin wrote: On 23.11.2012 14:58, Alan Bateman wrote: On 23/11/2012 10:40, Alexey Utkin wrote: The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alan Bateman
On 23/11/2012 11:22, Alexey Utkin wrote: On 23.11.2012 14:58, Alan Bateman wrote: On 23/11/2012 10:40, Alexey Utkin wrote: The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account (changes in TraceJFrame.java): http://cr.o

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alexey Utkin
On 23.11.2012 14:58, Alan Bateman wrote: On 23/11/2012 10:40, Alexey Utkin wrote: The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account (changes in TraceJFrame.java): http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7

Re: Request for review: 7173494: some jdk tests are not run in test/Makefile

2012-11-23 Thread Alan Bateman
On 22/11/2012 16:36, Rob McKenna wrote: Hi folks, Looking to backport these changes to the test makefiles to jdk7. As per Alans original mail: "This one is a small clean-up of the test targets defined in jdk/test/Makefile. The union of the tests executed by each of the make targets should b

Re: bottleneck by java.lang.Class.getAnnotations() - a better patch

2012-11-23 Thread Peter Levart
Hi David, Alan, Alexander and others, Here's a refinement of a patch I proposed in this thread a couple of weeks ago: http://dl.dropbox.com/u/101777488/jdk8-hacks/JEP-149/webrev.02/index.html The changed sources can be browsed here: https://github.com/plevart/jdk8-hacks/tree/annotation-array

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alan Bateman
On 23/11/2012 10:40, Alexey Utkin wrote: The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account (changes in TraceJFrame.java): http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.03/ This looks good to me.

Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alexey Utkin
The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account (changes in TraceJFrame.java): http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.03/ On 22.11.2012 13:57, Alan Bateman wrote: On 22/11/2012 07:38

Re: hg: jdk8/tl/jdk: 8003898: X11 toolkit can be chosen as the default toolkit

2012-11-23 Thread Alan Bateman
On 23/11/2012 09:09, alexey.ut...@oracle.com wrote: Changeset: ee6e5b7d5d55 Author:uta Date: 2012-11-23 13:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee6e5b7d5d55 8003898: X11 toolkit can be chosen as the default toolkit Summary: XToolkit is not selected for any valu

hg: jdk8/tl/jdk: 8003898: X11 toolkit can be chosen as the default toolkit

2012-11-23 Thread alexey . utkin
Changeset: ee6e5b7d5d55 Author:uta Date: 2012-11-23 13:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee6e5b7d5d55 8003898: X11 toolkit can be chosen as the default toolkit Summary: XToolkit is not selected for any values of system-wide environment variables (ex. DISPLAY)

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-11-23 Thread Deven You
Hi Lance, Is there any plan for this issue, if any could you update to me? Thanks a lot! On 10/29/2012 06:39 PM, Lance Andersen - Oracle wrote: Hi Deven, I will address the needed updates a bit later. Thank you for your input Best Lance On Oct 29, 2012, at 3:51 AM, Deven You wrote: Hi Alan