On 11/27/2012 08:55 PM, Mandy Chung wrote:
On 11/27/2012 11:46 AM, Alan Bateman wrote:
This looks fine to me but when we move to module it means a reflection
scope dependency on JDBC
Right - this only removes the static dependency but the reflection scope
dependency from base to JDBC remains.
I hereby nominate Mike Duigou to membership of the core-libs group.
Mike doesn't need any introduction as he has been active in this group
and this mailing list for the last 2 years. Mike has Committer role in
the jdk8, jdk7u and lamdba projects and almost all of the changes that
he has
I hereby nominate Stuart Marks to membership of the core-libs group.
Stuart doesn't need any introduction as he has been active in this group
and this mailing list for more than 2 years. Stuart has Committer role
in the jdk8, jdk7u and lamdba projects and all of the changes that he
has
Vote: yes.
-Chris.
On 28/11/2012 11:10, Alan Bateman wrote:
I hereby nominate Mike Duigou to membership of the core-libs group.
Mike doesn't need any introduction as he has been active in this group
and this mailing list for the last 2 years. Mike has Committer role in
the jdk8, jdk7u and
I hereby nominate Mandy Chung to membership of the core-libs group.
Mandy doesn't need any introduction as she has been active in this group
and on this mailing list almost since the start of OpenJDK. This
includes changes to code in the core libraries area, reviewing changes
for others in
Vote: yes
-Chris.
On 28/11/2012 11:21, Alan Bateman wrote:
I hereby nominate Mandy Chung to membership of the core-libs group.
Mandy doesn't need any introduction as she has been active in this group
and on this mailing list almost since the start of OpenJDK. This
includes changes to code in
Did we conclude that my original change was good, or was there an alternative?
Thanks,
/Staffan
On 27 nov 2012, at 17:02, Seán Coffey sean.cof...@oracle.com wrote:
I suspect this test will fail with java agents too, say when doing code
coverage during test runs.
It might be better to just
Hi all,
There're two fields in java.lang.reflect.Field that are used to cache
FieldAccessors:
// Cached field accessor created without override
private FieldAccessor fieldAccessor;
// Cached field accessor created with override
private FieldAccessor overrideFieldAccessor;
Changeset: 46c627801490
Author:xuelei
Date: 2012-11-28 05:18 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c627801490
8004019: Removes unused method HandshakeHash.setCertificateVerifyAlg()
Summary: certification verification in HandshakeHash was abandoned during TLS
1.2
Staffan,
perhaps you can leave out the setting of security manager on the @run
tags. Security manager can be added through the code as per current
testcase.
@run main/othervm -Duser.timezone=Asia/Tokyo Bug6912560
should work ?
regards,
Sean.
--- a/test/java/util/TimeZone/Bug6912560.java
On 28 nov 2012, at 14:30, Seán Coffey sean.cof...@oracle.com wrote:
Staffan,
perhaps you can leave out the setting of security manager on the @run tags.
Security manager can be added through the code as per current testcase.
@run main/othervm -Duser.timezone=Asia/Tokyo Bug6912560
I was wondering if you plan to address the review comment by David. If
that part gets addressed, I think the test case change is no longer
required. Otherwise, your change to the test program is fine with me.
Thanks,
Masayoshi
On 2012/11/28 21:59, Staffan Larsen wrote:
Did we conclude that
Vote: yes
-Joe
On 11/28/2012 3:11 AM, Alan Bateman wrote:
I hereby nominate Stuart Marks to membership of the core-libs group.
Stuart doesn't need any introduction as he has been active in this
group and this mailing list for more than 2 years. Stuart has
Committer role in the jdk8, jdk7u
Vote: yes
-Joe
On 11/28/2012 3:10 AM, Alan Bateman wrote:
I hereby nominate Mike Duigou to membership of the core-libs group.
Mike doesn't need any introduction as he has been active in this group
and this mailing list for the last 2 years. Mike has Committer role in
the jdk8, jdk7u and
Vote: yes
-Joe
On 11/28/2012 3:21 AM, Alan Bateman wrote:
I hereby nominate Mandy Chung to membership of the core-libs group.
Mandy doesn't need any introduction as she has been active in this
group and on this mailing list almost since the start of OpenJDK. This
includes changes to code
Vote: yes
- Mark
Vote: yes
- Mark
Vote: yes
- Mark
On 28 nov 2012, at 15:41, Masayoshi Okutsu masayoshi.oku...@oracle.com wrote:
I was wondering if you plan to address the review comment by David. If that
part gets addressed, I think the test case change is no longer required.
Otherwise, your change to the test program is fine with me.
Changeset: 735b93462eed
Author:jfranck
Date: 2012-11-28 09:21 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/735b93462eed
7154390: Add support for repeating annotations in j.l.r.AnnotatedElement
Reviewed-by: darcy
! src/share/classes/java/lang/Class.java
!
Changeset: 1f41a5758cf7
Author:vromero
Date: 2012-11-23 15:13 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f41a5758cf7
7144981: javac should ignore ignorable characters in input
Reviewed-by: jjg, mcimadamore
!
Changeset: 3b6a2fe6d75c
Author:dfuchs
Date: 2012-11-28 15:14 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b6a2fe6d75c
8003476: Cleanup warnings in com.sun.jmx.snmp code
Reviewed-by: alanb, smarks
! src/share/classes/com/sun/jmx/snmp/EnumRowStatus.java
!
Since we don't yet have a resolution on this, I modified the test code
in question to remove the @SuppressWarnings(unused) and actually
removed the unused references (and retested, of course).
Please review
http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/
Changeset: 09bef1e118e3
Author:mchung
Date: 2012-11-28 10:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09bef1e118e3
8003851: MethodHandleNatives dependency on java.sql.DriverManager
Reviewed-by: alanb, dholmes
!
Vote: yes
Vote: yes
iris
Vote: yes
iris
On 11/28/2012 05:17 PM, Peter Levart wrote:
The fix is simple - transform the field to final - it is only
initialized in the constructor.
I agree with this conclusion. UnsafeStaticFieldAccessorImpl.base should
be final. Peter, will you be able to prepare the webrev?
-Aleksey.
Vote: yes
Vote: yes
Vote: yes
On 27/11/2012 23:18, Mandy Chung wrote:
:
See below for a few sample output.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8003562/
The implementation classes for jdeps are in the langtools repo along
with the com.sun.tools.classfile library. I'm working on adding more
unit
On 11/28/2012 11:53 AM, Alan Bateman wrote:
I suspect you will get a lots of feedback on the output once people
get a chance to try it out.
That's what I expect too :)
Personally I think I would print the code source against each of the
dependence if it's in a JAR file (might be more than
Ok, here it is:
http://dl.dropbox.com/u/101777488/jdk8-hacks/UnsafeStaticFieldAccessorImpl.base/webrev/index.html
All fields in FieldAccessor implementations should be final because
instances can be obtained via a data race in java.lang.reflect.Field.
Regards, Peter
On 11/28/2012 08:10 PM,
Vote: yes
David
On 28/11/2012 9:21 PM, Alan Bateman wrote:
I hereby nominate Mandy Chung to membership of the core-libs group.
Mandy doesn't need any introduction as she has been active in this group
and on this mailing list almost since the start of OpenJDK. This
includes changes to code in
Vote: yes
David
On 28/11/2012 9:10 PM, Alan Bateman wrote:
I hereby nominate Mike Duigou to membership of the core-libs group.
Mike doesn't need any introduction as he has been active in this group
and this mailing list for the last 2 years. Mike has Committer role in
the jdk8, jdk7u and
Vote: yes.
David
On 28/11/2012 9:11 PM, Alan Bateman wrote:
I hereby nominate Stuart Marks to membership of the core-libs group.
Stuart doesn't need any introduction as he has been active in this group
and this mailing list for more than 2 years. Stuart has Committer role
in the jdk8, jdk7u
I'm a bit happier that @SuppressWarnings(unused) has been removed.
Note, I only got pulled into this because of the @SuppressWarnings namespace
question; I didn't look at the rest of the webrev.
s'marks
On 11/28/12 10:51 AM, Jim Gish wrote:
Since we don't yet have a resolution on this, I
Mike,
On 28/11/2012 3:32 AM, Mike Duigou wrote:
On Nov 27 2012, at 03:56 , Stephen Colebourne wrote:
On 27 November 2012 02:12, Mike Duigoumike.dui...@oracle.com wrote:
In the original patch which added the basic lambda functional interfaces,
CR#8001634 [1], none of the interfaces extended
We have a few test failures on nightly testing, they are failing for
known issues and should be excluded until issue is resolved.
Please review:
https://dl.dropbox.com/u/5812451/yl153753/8004134/webrev.00/index.html
Thanks,
Amy
40 matches
Mail list logo
