Re: AnnotationType AnnotationSupport + repeating annotations

2012-12-04 Thread Peter Levart
Hi again, Zhong Yu suggested to use plain TheadLocalMapClass, ... instead of ClassValueThreadLocal in the proposed patch. Here's the updated webrev that contains this change: http://dl.dropbox.com/u/101777488/jdk8-tl/AnnotationTypeSupport/webrev.02/index.html The improvement is twofold: -

Re: CFR: javax.xml.parsers: Using ServiceLoader to load JAXP parser factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-04 Thread Alan Bateman
On 03/12/2012 19:04, Daniel Fuchs wrote: Hi, This is a first webrev in a series that addresses a change intended for JDK 8: 7169894: JAXP Plugability Layer: using service loader I've been building up on Joe's work and Paul Alan comments from an earlier discussion thread [1] This here

hg: jdk8/tl/jdk: 7142921: (fs) Files.probeContentType reports a MIME type of text/plain on Ubuntu 11.04; ...

2012-12-04 Thread alan . bateman
Changeset: 38ec2838dd86 Author:dxu Date: 2012-12-04 14:07 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38ec2838dd86 7142921: (fs) Files.probeContentType reports a MIME type of text/plain on Ubuntu 11.04 7144997: (fs) Files.probeContentType returns null on Solaris 64-bit

hg: jdk8/tl/jdk: 8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message

2012-12-04 Thread alan . bateman
Changeset: 2e8863c4f7d0 Author:kmo Date: 2012-12-04 15:10 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e8863c4f7d0 8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message Reviewed-by: twisti, alanb, dholmes !

Re: AnnotationType AnnotationSupport + repeating annotations

2012-12-04 Thread Alan Bateman
cc'ing Joel Borggrén-Franck as it he added the support for repeating annotations very recently. On 04/12/2012 09:23, Peter Levart wrote: Hi again, Zhong Yu suggested to use plain TheadLocalMapClass, ... instead of ClassValueThreadLocal in the proposed patch. Here's the updated webrev

Re: CFR: javax.xml.parsers: Using ServiceLoader to load JAXP parser factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-04 Thread Daniel Fuchs
On 12/4/12 3:42 PM, Daniel Fuchs wrote: In the class descriptions it suggests that the default implementation may be installed as a module but we aren't there yet so I'm not sure about using the term module. I think it should be okay to say installed as an extension as ServiceLoader uses this

Re: RFR: 8003596 CheckLockLocationTest-Windows-fix

2012-12-04 Thread Alan Bateman
On 04/12/2012 16:49, Jim Gish wrote: http://cr.openjdk.java.net/~jgish/Bug8003596-CheckLockLocationTest-Windows-fix/ http://cr.openjdk.java.net/%7Ejgish/Bug8003596-CheckLockLocationTest-Windows-fix/ Better? :-) Much nicer - thank you! I'll push this today for you. -Alan

Re: RFR: 8003596 CheckLockLocationTest-Windows-fix

2012-12-04 Thread Jim Gish
http://cr.openjdk.java.net/~jgish/Bug8003596-CheckLockLocationTest-Windows-fix/ http://cr.openjdk.java.net/%7Ejgish/Bug8003596-CheckLockLocationTest-Windows-fix/ Better? :-) Thanks, Jim On 12/04/2012 06:28 AM, Alan Bateman wrote: On 03/12/2012 15:01, Jim Gish wrote: Thanks. Could you

hg: jdk8/tl/langtools: 8004360: regression test DefaultMethodRegressionTests fails in langtools

2012-12-04 Thread maurizio . cimadamore
Changeset: 0e70eb71fec0 Author:mcimadamore Date: 2012-12-04 17:19 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e70eb71fec0 8004360: regression test DefaultMethodRegressionTests fails in langtools Summary: ignore broken failing test Reviewed-by: jjg -

Re: 8003562: Provide a command-line tool to find static dependencies

2012-12-04 Thread Mandy Chung
Alan - thanks for the feedback. I have made several changes to the jdeps tool. Here is the new webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8003562/langtools-webrev.01/ I'll send out a formal code review request once I add the new unit tests. $ jdeps -h Usage: jdeps options