I would think that it's good to merge the 3rd and 4th steps for a jdk in
module mode. In regular mode or JDK8, where the existence of the default
implementation is guaranteed, the last step is still necessary. It is a
requirement for the API implementation.
I probably was wrong to use
Hi Henry,
I don't know what the plans are about moving the static methods in
Comparators to the Comparator interface when static interface methods
are enabled, but if that is planned, there will be a clash between
Comparator.reverseOrder() default method and static method with same
name and
On 06/12/2012 22:03, Christian Schulte wrote:
:
Or update the code to use the thread context class loader if possible.
This would allow using custom charset providers with e.g. Webstart.
Anyway. Thanks for taking a look.
Using the TCCL for charset providers is highly problematic, this is a
On 07/12/2012 08:04, Joe Wang wrote:
I would think that it's good to merge the 3rd and 4th steps for a jdk
in module mode. In regular mode or JDK8, where the existence of the
default implementation is guaranteed, the last step is still
necessary. It is a requirement for the API
On 12/06/12 18:44, Remi Forax wrote:
BTW, at some point, it will be a good idea to get ride of all these method
access$000 in java.lang/java.util at least.
Maybe this is out of scope for this CR, but while in the
neighborhood of ThreadLocal, it could be done here.
There are a couple of
OK, looks pretty good. But
One little thing is still bothering me. Suppose we get interrupted from the
sleep() and bail out on that basis. If we got to the point where we're
sleeping, we must have caught an AccessDeniedException previously.
Unfortunately this exception is discarded
I filed 8004707: Remove superfluous access$000 methods in java.util,
to track this issue. I can file a separate issue for java.lang.
I'm sure there are other ways, but a simple find reports them:
:pwd
build/solaris-i586/classes/java/util
: find . -name *.class -exec javap -v {} \; | grep
On 12/07/2012 04:34 PM, Chris Hegarty wrote:
I filed 8004707: Remove superfluous access$000 methods in java.util,
to track this issue. I can file a separate issue for java.lang.
yes, please do that.
I'm sure there are other ways, but a simple find reports them:
:pwd
On 12/7/12 7:38 AM, David DeHaven wrote:
(There's another issue which is that if there were previous retries, the ADEs
from them are thrown away. But maybe we should save that one for another day.)
I had the same thought, but aside from collecting and reporting all of them
somehow I'm not
OK, looks pretty good. But
One little thing is still bothering me. Suppose we get interrupted from the
sleep() and bail out on that basis. If we got to the point where we're
sleeping, we must have caught an AccessDeniedException previously.
Unfortunately this exception is discarded if we
On 07/12/2012 15:15, Daniel Fuchs wrote:
Hi Alan,
I have updated the webrev according to your suggestion. I think it makes
things much clearer.
The new version is there:
http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.parsers/webrev.03/
This looks good to me except that
(There's another issue which is that if there were previous retries, the
ADEs from them are thrown away. But maybe we should save that one for
another day.)
I had the same thought, but aside from collecting and reporting all of them
somehow I'm not sure what could be done about it.
test scripts have been updated to invoke the JVM with an env variable TESTVMOPTS
which carries the vm options to be passed when the jvm is invoked in the test.
webrev location:
http://cr.openjdk.java.net/~chegar/8003890/webrev.00/
regards
Mark
On Dec 7, 2012, at 1:09 AM, Peter Levart peter.lev...@gmail.com wrote:
Hi Henry,
I don't know what the plans are about moving the static methods in
Comparators to the Comparator interface when static interface methods are
enabled, but if that is planned, there will be a clash between
(There's another issue which is that if there were previous retries, the
ADEs from them are thrown away. But maybe we should save that one for
another day.)
I had the same thought, but aside from collecting and reporting all of them
somehow I'm not sure what could be done about it.
On 12/7/12 8:32 AM, Alan Bateman wrote:
On 07/12/2012 15:15, Daniel Fuchs wrote:
Hi Alan,
I have updated the webrev according to your suggestion. I think it makes
things much clearer.
The new version is there:
http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.parsers/webrev.03/
This
Please review
http://cr.openjdk.java.net/~jgish/Bug8004651-CheckLockLocationTest-Windows-delete-file-fix/
http://cr.openjdk.java.net/%7Ejgish/Bug8004651-CheckLockLocationTest-Windows-delete-file-fix/
Summary -- failure to delete a test log should be a warning instead of a
failure. Also,
On 07/12/2012 16:57, Mark Sheppard wrote:
test scripts have been updated to invoke the JVM with an env variable TESTVMOPTS
which carries the vm options to be passed when the jvm is invoked in the test.
webrev location:
http://cr.openjdk.java.net/~chegar/8003890/webrev.00/
regards
Mark
On 12/5/12 10:58 AM, Alan Bateman wrote:
http://cr.openjdk.java.net/~alanb/8004371/webrev/
Yay! Properties no longer requires JAXP to be present in order to
load/store properties in XML format. This looks okay to me. Some minor
comments:
XMLStreamWriterImpl.isEncodingSupported - it
On Dec 6 2012, at 03:59 , Chris Hegarty wrote:
Mike,
Some small comments.
1) IntUnaryOperator.java
Typo in:
+ 30 * pThis is the primitive type specialization of {@link
IntUnaryOperator} for
+ 31 * {@code int} and also may be used as a {@code
IntUnaryOperatorInteger}. When
This is the updated webrev. It includes Erik's makefile changes and
small change - be consistent with javap, jdeps can take classnames as
the input argument or wildcard * to analyze all class files that
replaces the -all option.
Webrev:
On 07/12/2012 19:38, Mandy Chung wrote:
:
Yay! Properties no longer requires JAXP to be present in order to
load/store properties in XML format. This looks okay to me. Some
minor comments:
Thanks for going through it, I'll leave it Joe to respond as he did the
work.
:
As you mentioned,
On 12/7/12 2:14 PM, Alan Bateman wrote:
One question though - jdk.internal.org.xml.sax.** are copied from
JAXP source. What should the copyright years be? It currently
retains the same value from the original copy.
As the package has changed then the end year should probably be
changed
Thanks for reviewing the changes. Please see comments inline.
On 12/7/2012 11:38 AM, Mandy Chung wrote:
On 12/5/12 10:58 AM, Alan Bateman wrote:
http://cr.openjdk.java.net/~alanb/8004371/webrev/
Yay! Properties no longer requires JAXP to be present in order to
load/store properties in
On 12/7/12 1:39 PM, David DeHaven wrote:
Hopefully final webrev for this change:
http://cr.openjdk.java.net/~ddehaven/8004042/webrev.3/
I moved the createBatFile method to TestHelper as I thought it could be useful
to other tests and added more diagnostic info.
It turns out the culprit on my
As part of the Library Lambdafication, this patch adds the following
default methods to Collections -
Iterable.forEach(BlockT)
Collection.removeAll(PredicateT)
List.sort(Comparator)
List.replaceAll(UnaryOperatorT)
It also provides more efficient implementations of these methods for
ArrayList,
26 matches
Mail list logo
