Looks good.
/Erik
On 2012-12-07 22:55, Mandy Chung wrote:
This is the updated webrev. It includes Erik's makefile changes and
small change - be consistent with javap, jdeps can take classnames as
the input argument or wildcard * to analyze all class files that
replaces the -all option.
On 07/12/2012 21:02, Mike Duigou wrote:
...
5) I agree with David, NPE should be defined where applicable.
I am adding these though I am still somewhat resistant for reasons I will
mention in next review cycle thread
I don't want to to get bogged down in a debate over this, I'm really
On 07/12/2012 15:46, Remi Forax wrote:
On 12/07/2012 04:34 PM, Chris Hegarty wrote:
I filed 8004707: Remove superfluous access$000 methods in java.util,
to track this issue. I can file a separate issue for java.lang.
yes, please do that.
I filed 8004797: Remove superfluous access$000
On 10/12/2012 11:13, Chris Hegarty wrote:
Thank you Mark, this is a really useful contribution.
I noticed that a few tests (below) specify either -client or -server.
If the vmoptions contain either of these arguments, and this seems to
be the way our test/Makefile is passing them, then it may
Hi Frank,
As I explained in one of my earlier emails, tests that require a database will
not be added to jtreg. I have a unit test suite which i use for that but that
is not external
Best
Lance
On Dec 10, 2012, at 2:44 AM, Frank Ding wrote:
Hi Lance,
The code refactory looks good. By
Changeset: c78acf6c2f3e
Author:mcimadamore
Date: 2012-12-10 12:10 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c78acf6c2f3e
8004094: Javac compiler error - synthetic method accessor generated with
duplicate name
Summary: method clash check logic should skip methods
On 08/12/2012 01:42, Akhil Arora wrote:
As part of the Library Lambdafication, this patch adds the following
default methods to Collections -
Iterable.forEach(BlockT)
Collection.removeAll(PredicateT)
List.sort(Comparator)
List.replaceAll(UnaryOperatorT)
It also provides more efficient
On 12/09/2012 10:03 PM, David Holmes wrote:
Hi David,
On 7/12/2012 1:06 AM, David M. Lloyd wrote:
On 12/06/2012 05:35 AM, Alan Bateman wrote:
On 05/12/2012 11:59, David Holmes wrote:
Java 7 introduced support for parallel classloading by adding to each
class loader a ConcurrentHashMap,
On 12/10/2012 11:51 AM, Chris Hegarty wrote:
On 07/12/2012 15:46, Remi Forax wrote:
On 12/07/2012 04:34 PM, Chris Hegarty wrote:
I filed 8004707: Remove superfluous access$000 methods in java.util,
to track this issue. I can file a separate issue for java.lang.
yes, please do that.
I
Hi David,
It would be informative to look at how java.lang.Class evolved during
history. The oldest revision I can access is from 1st of Dec. 2007,
which already contains Java 1.5 code (annotations) and is more or less
unchanged until now. The most interesting changesets would be those that
Ok, I've got it. Downloaded j2sdk1.4_19 and unpacked src.zip ...
There are SoftReferences for individual Field/Method/Constructor arrays:
// Caches for certain reflective results
private static boolean useCaches = true;
private volatile transient SoftReference declaredFields;
Shouldn't 'cal.set(1970, 0, 1, 0, 0, 0)' be inside the for loop?
The test can simply throw Exception, rather can catching.
Otherwise, looks fine to me.
-Crhis.
On 06/12/2012 21:19, Rob McKenna wrote:
Hi folks,
According to HttpCookie.java:
There are 3 http cookie specifications:
Netscape
Hi,
After further discussion with Joe Alan, I changed the call
to ServiceLoader to simply return the first provider it finds,
or null.
This is closer to what was present in JDK 7 - and looping is
not necessary in JDK 8 since the default implementation is
not returned as a service provider.
So
Hi Daniel,
Looks good!
Joe
On 12/10/2012 9:12 AM, Daniel Fuchs wrote:
Hi,
After further discussion with Joe Alan, I changed the call
to ServiceLoader to simply return the first provider it finds,
or null.
This is closer to what was present in JDK 7 - and looping is
not necessary in JDK 8
Yes; the OpenJDK sources only go back to circa 2007, which was part-way
into the JDK 7 release. The exact changesets of how annotations were
added back in JDK 5 are not available publicly. However, the final
results of that process may be mostly visible in the src.zip from JDK 5.
HTH,
-Joe
Hi David, Joe,
I unpacked the src.zip of the first release of JDK 1.5.0. Here's the
relevant part:
private transient MapClass, Annotation annotations;
private transient MapClass, Annotation declaredAnnotations;
private synchronized void initAnnotationsIfNecessary() {
if
Please review and push this ridiculously trivial fix:
http://cr.openjdk.java.net/~jgish/Bug4819681-Day1-typo-in-LogManager/
http://cr.openjdk.java.net/%7Ejgish/Bug4819681-Day1-typo-in-LogManager/
I'd love to know how many people have stumbled on this ridiculous
one-letter capitalization bug
Approved!
-Joe
On 12/10/2012 02:44 PM, Jim Gish wrote:
Please review and push this ridiculously trivial fix:
http://cr.openjdk.java.net/~jgish/Bug4819681-Day1-typo-in-LogManager/
http://cr.openjdk.java.net/%7Ejgish/Bug4819681-Day1-typo-in-LogManager/
I'd love to know how many people have
I am pushing the typo fix for you - Jim.
Mandy
On 12/10/2012 2:59 PM, Joe Darcy wrote:
Approved!
-Joe
On 12/10/2012 02:44 PM, Jim Gish wrote:
Please review and push this ridiculously trivial fix:
http://cr.openjdk.java.net/~jgish/Bug4819681-Day1-typo-in-LogManager/
Changeset: cac1bfaceaaa
Author:mchung
Date: 2012-12-10 15:15 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cac1bfaceaaa
4819681: Typo in
http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html
Summary: Simple capitalization typo in LogManager()
Jim,
Pushed [1]. I'm sorry that I missed to set the user when creating the
changeset and it was too late when I noticed that and attempted to kill
the hg push comment. Hope you don't mind.
Mandy
[1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cac1bfaceaaa
On 12/10/2012 2:44 PM, Jim Gish
http://cr.openjdk.java.net/~akhil/8004201.2/webrev/
- replaced Suitable for conversion as a method reference to functional
interfaces such as ... with @see java.util.function.BinaryOperator
- javadoc - replaced 'a type argument'/'another type argument' with
'the first operand'/'the second
On 12/10/12 3:25 AM, Alan Bateman wrote:
On 10/12/2012 11:13, Chris Hegarty wrote:
Thank you Mark, this is a really useful contribution.
I noticed that a few tests (below) specify either -client or -server. If the
vmoptions contain either of these arguments, and this seems to be the way our
On 10/12/2012 11:53 PM, David M. Lloyd wrote:
On 12/09/2012 10:03 PM, David Holmes wrote:
That sounds promising. Are you in a position to try out this proposal on
a testbed with your app server?
Sure, I'd love to. What tree should I build?
Please apply the patches from the webrevs here:
Hi Peter,
On 12/10/2012 02:23 PM, Peter Levart wrote:
Hi David, Joe,
I unpacked the src.zip of the first release of JDK 1.5.0. Here's the
relevant part:
private transient MapClass, Annotation annotations;
private transient MapClass, Annotation declaredAnnotations;
private
Changeset: 883feced1cdd
Author:dingxmin
Date: 2012-12-11 10:42 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883feced1cdd
6512101: Incorrect encoding in NetworkInterface.getDisplayName()
Reviewed-by: chegar, dsamersoff
! src/windows/native/java/net/NetworkInterface.c
On 12/10/2012 06:36 PM, David Holmes wrote:
On 10/12/2012 11:53 PM, David M. Lloyd wrote:
On 12/09/2012 10:03 PM, David Holmes wrote:
That sounds promising. Are you in a position to try out this proposal on
a testbed with your app server?
Sure, I'd love to. What tree should I build?
Please
FYI I've made some small updates to the blog entry.
Just to quantify the inefficiencies here is the instrumented output of a
simple test that tries to load all classes in rt.jar and prints out the
size of the lock maps:
18521 classes loaded.
sun.misc.Launcher$AppClassLoader@f2f585 -
Changeset: d206e52bf8a6
Author:weijun
Date: 2012-12-11 13:14 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d206e52bf8a6
8004488: wrong permissions checked in krb5
Reviewed-by: xuelei
! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java
!
David,
Many thanks for trialling this so promptly!
Do you have any suggestions for what instrumentation you would like to
see accompany this?
David
On 11/12/2012 1:41 PM, David M. Lloyd wrote:
On 12/10/2012 06:36 PM, David Holmes wrote:
On 10/12/2012 11:53 PM, David M. Lloyd wrote:
On
http://cr.openjdk.java.net/~akhil/8001647.3/webrev/
- now with synchronized and unmodifiable wrappers in Collections.java
for the default methods being added
On 12/10/2012 01:48 PM, Akhil Arora wrote:
Updated with yours and Alan's comments -
31 matches
Mail list logo
