Changeset: 645d774b683a
Author:xuelei
Date: 2012-12-28 00:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/645d774b683a
7109274: Restrict the use of certificates with RSA keys less than 1024 bits
Summary: This restriction is applied via the Java Security property,
Changeset: 4472a641b4dc
Author:xuelei
Date: 2012-12-28 03:50 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4472a641b4dc
8003265: Need to clone array of input/output parameters
Reviewed-by: mullan
! src/share/classes/com/sun/jndi/dns/DnsContext.java
!
Henry,
It is beautiful if that code lives only inside of the logger and the caller is
unaware of its existence. Same is true for writing a guard statement.
The formatter can not always achieve the same laziness. If I converted your
example in the API docs to be passed in the params argument
Please revieiw the following change (simple, non-functional, non-spec
change to bring some consistency to the javadoc tags - using {@code }
where possible, etc.}
http://cr.openjdk.java.net/~jgish/Bug8005118-String-spec-consistency/
Looks fine; cheers,
-Joe
On 12/28/2012 7:19 AM, Jim Gish wrote:
Please revieiw the following change (simple, non-functional, non-spec
change to bring some consistency to the javadoc tags - using {@code }
where possible, etc.}
Thanks, Joe. Could you please submit for me?
Jim
On 12/28/2012 02:07 PM, Joe Darcy wrote:
Looks fine; cheers,
-Joe
On 12/28/2012 7:19 AM, Jim Gish wrote:
Please revieiw the following change (simple, non-functional, non-spec
change to bring some consistency to the javadoc tags - using
Jason,
If I understand you correctly, there are two main concerns,
1. You want to encourage MessageFormat style logging, consider the other way is
an anti-pattern.
2. The construction of message could be further eliminated when a filter is
involved.
Here is what I thought,
For 1, the new API
Changeset: 0cfcba56cfa7
Author:jgish
Date: 2012-12-28 18:32 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cfcba56cfa7
8005594: Fix to 8003265 breaks build
Summary: backout changeset 4472a641b4dc
Reviewed-by: smarks, wetmore
!
On Dec 28, 2012, at 4:11 PM, Henry Jen henry@oracle.com wrote:
Next version I'll enable defer message construction until Logger filter check.
On a second thought and after more reading into logging code in JDK, it seems
like Filter is mostly applied to Handler instead of Logger, thus
Changeset: c37401e77c80
Author:mchung
Date: 2012-12-28 22:20 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/c37401e77c80
8003562: Provide a CLI tool to analyze class dependencies
Reviewed-by: jjg, alanb, ulfzibis, erikj
! common/bin/compare_exceptions.sh.incl
10 matches
Mail list logo
