Re: Codereview request for 8003680: JSR 310: Date/Time API

2013-01-23 Thread Erik Joelsson
On 2013-01-23 01:14, David Holmes wrote: On 23/01/2013 9:08 AM, Xueming Shen wrote: On 01/22/2013 02:58 PM, Alan Bateman wrote: On 22/01/2013 22:19, David Holmes wrote: All of the jar building was modified so that jars go into images/lib not jdk/lib. So it should not be necessary (or

hg: jdk8/tl/jdk: 8006741: javadoc cleanup for 6263419

2013-01-23 Thread vincent . x . ryan
Changeset: 71691b9d45ab Author:vinnie Date: 2013-01-23 09:49 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71691b9d45ab 8006741: javadoc cleanup for 6263419 Reviewed-by: alanb ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java

OPENJDK env var not playing well with new build

2013-01-23 Thread Weijun Wang
I thought building an OpenJDK or Oracle JDK can be fully controlled by using the --enable-openjdk-only configure option, but it seems the OPENJDK env variable still plays a part. If the variable is set to true and --enable-openjdk-only is not provided, the new build process gets confused and

Re: OPENJDK env var not playing well with new build

2013-01-23 Thread Erik Joelsson
On 2013-01-23 11:30, Weijun Wang wrote: I thought building an OpenJDK or Oracle JDK can be fully controlled by using the --enable-openjdk-only configure option, but it seems the OPENJDK env variable still plays a part. If the variable is set to true and --enable-openjdk-only is not provided,

hg: jdk8/tl/jdk: 6519127: user.home property not set correctly

2013-01-23 Thread alexey . utkin
Changeset: 01b36b400145 Author:uta Date: 2013-01-23 15:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b36b400145 6519127: user.home property not set correctly Summary: Registry-based approach was changed to SHGetKnownFolderPath/SHGetFolderPathW Reviewed-by: alanb,

Re: OPENJDK env var not playing well with new build

2013-01-23 Thread David Holmes
On 23/01/2013 8:58 PM, Erik Joelsson wrote: On 2013-01-23 11:30, Weijun Wang wrote: I thought building an OpenJDK or Oracle JDK can be fully controlled by using the --enable-openjdk-only configure option, but it seems the OPENJDK env variable still plays a part. If the variable is set to true

Re: OPENJDK env var not playing well with new build

2013-01-23 Thread Erik Joelsson
On 2013-01-23 12:54, David Holmes wrote: On 23/01/2013 8:58 PM, Erik Joelsson wrote: On 2013-01-23 11:30, Weijun Wang wrote: I thought building an OpenJDK or Oracle JDK can be fully controlled by using the --enable-openjdk-only configure option, but it seems the OPENJDK env variable still

Re: OPENJDK env var not playing well with new build

2013-01-23 Thread Weijun Wang
On 01/23/2013 07:54 PM, David Holmes wrote: On 23/01/2013 8:58 PM, Erik Joelsson wrote: On 2013-01-23 11:30, Weijun Wang wrote: I thought building an OpenJDK or Oracle JDK can be fully controlled by using the --enable-openjdk-only configure option, but it seems the OPENJDK env variable still

Re: OPENJDK env var not playing well with new build

2013-01-23 Thread Erik Joelsson
On 2013-01-23 13:23, Weijun Wang wrote: On 01/23/2013 07:54 PM, David Holmes wrote: On 23/01/2013 8:58 PM, Erik Joelsson wrote: On 2013-01-23 11:30, Weijun Wang wrote: I thought building an OpenJDK or Oracle JDK can be fully controlled by using the --enable-openjdk-only configure option,

Re: RFR : 8006594/8006595 : Define jdk_core test set

2013-01-23 Thread Alan Bateman
On 22/01/2013 21:15, Mike Duigou wrote: Hello all; This is a two piece patch. 8006594: Add jdk_core target to jdk/test/Makefile 8006595: Use jdk/test/Makefile targets in preference to local definitions I chose to do it as two patches because the changes are in different repos and the changes

hg: jdk8/tl/jdk: 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac

2013-01-23 Thread chris . hegarty
Changeset: bf2a14ebb6e9 Author:chegar Date: 2013-01-23 14:45 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf2a14ebb6e9 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac Reviewed-by: alanb !

8006764: FunctionalInterface missing from rt.jar (old build)

2013-01-23 Thread Alan Bateman
The j.l.FunctionalInterface annotation was added recently but it's not showing up in rt.jar when using the old build (NEWBUILD=false). Unfortunately we have to keep the old build on life support until the new build is bedded down and downstream projects have transitioned. So I need a

Re: 8006764: FunctionalInterface missing from rt.jar (old build)

2013-01-23 Thread Lance Andersen - Oracle
+1 On Jan 23, 2013, at 9:54 AM, Alan Bateman wrote: The j.l.FunctionalInterface annotation was added recently but it's not showing up in rt.jar when using the old build (NEWBUILD=false). Unfortunately we have to keep the old build on life support until the new build is bedded down and

Re: 8006764: FunctionalInterface missing from rt.jar (old build)

2013-01-23 Thread Remi Forax
On 01/23/2013 03:56 PM, Lance Andersen - Oracle wrote: +1 +1 too RĂ©mi On Jan 23, 2013, at 9:54 AM, Alan Bateman wrote: The j.l.FunctionalInterface annotation was added recently but it's not showing up in rt.jar when using the old build (NEWBUILD=false). Unfortunately we have to keep the

hg: jdk8/tl/langtools: 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile

2013-01-23 Thread maurizio . cimadamore
Changeset: 97bd5e7151bc Author:mcimadamore Date: 2013-01-23 15:08 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97bd5e7151bc 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile Summary: Missing boxing cause spurious inference failure

Re: 8006764: FunctionalInterface missing from rt.jar (old build)

2013-01-23 Thread Chris Hegarty
Looks fine to me too. -Chris. On 23/01/2013 14:56, Lance Andersen - Oracle wrote: +1 On Jan 23, 2013, at 9:54 AM, Alan Bateman wrote: The j.l.FunctionalInterface annotation was added recently but it's not showing up in rt.jar when using the old build (NEWBUILD=false). Unfortunately we have

hg: jdk8/tl/jdk: 8006764: FunctionalInterface missing from rt.jar (old build)

2013-01-23 Thread alan . bateman
Changeset: 53064bbaeec5 Author:alanb Date: 2013-01-23 15:12 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53064bbaeec5 8006764: FunctionalInterface missing from rt.jar (old build) Reviewed-by: lancea, forax ! make/java/java/FILES_java.gmk

Need volunteer to push JDK-8004729

2013-01-23 Thread Eric McCorkle
I'm not a committer, so I need someone to push this changeset for me. Thanks, Eric

Review Request: JDK-8001334 - Remove use of JVM_* functions from java.io code

2013-01-23 Thread Alan Bateman
Moving to core-libs-dev to allow for wider review. As Dan mentions, we've been looking to remove the Solairs-specific interruptible I/O for a long time. Original Message Subject: Review Request: JDK-8001334 - Remove use of JVM_* functions from java.io code Date: Mon,

Re: Need volunteer to push JDK-8004729

2013-01-23 Thread Alan Bateman
On 23/01/2013 15:16, Eric McCorkle wrote: I'm not a committer, so I need someone to push this changeset for me. Thanks, Eric I'm not volunteering (sorry) but just checking that the HotSpot changes are in jdk8/tl/hotspot already? I think they are, but just doubling checking to avoid problems

Re: Need volunteer to push JDK-8004729

2013-01-23 Thread Eric McCorkle
The first set (JDK-8004728) are in as of last week. The second set (JDK-8006005) are not, and it doesn't look like they are going to make it. However, JDK-8006005 only fixes some small bugs, so I can mark one of the tests I wrote @ignore. On 01/23/13 10:56, Alan Bateman wrote: On 23/01/2013

Re: Need volunteer to push JDK-8004729

2013-01-23 Thread Rob McKenna
Hi Erik, I can take care of this later this evening. -Rob On 23/01/13 15:16, Eric McCorkle wrote: I'm not a committer, so I need someone to push this changeset for me. Thanks, Eric

Re: RFR: 4247235 (spec str) StringBuffer.insert(int, char[]) specification is inconsistent

2013-01-23 Thread Jim Gish
This time with the attachment... Thanks, Jim On 01/22/2013 02:54 PM, Jim Gish wrote: change set/patch attached for pushing. Thanks, Jim On 01/22/2013 02:40 PM, Jim Gish wrote: I've made the changes as suggested by Mike, and this has now been approved by CCC. Could someone please give

Codereview request for 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently

2013-01-23 Thread Xueming Shen
Alan, Here is the webrev for the intermittently j.u.zf regression failure we talked about last night. I'm using the limited loop instead of while(true) to just be cautious. http://cr.openjdk.java.net/~sherman/8006773/webrev Thanks, -Sherman

Re: Codereview request for 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently

2013-01-23 Thread Alan Bateman
On 23/01/2013 17:46, Xueming Shen wrote: Alan, Here is the webrev for the intermittently j.u.zf regression failure we talked about last night. I'm using the limited loop instead of while(true) to just be cautious. http://cr.openjdk.java.net/~sherman/8006773/webrev Looks okay to me (although

hg: jdk8/tl/jdk: 2 new changesets

2013-01-23 Thread xueming . shen
Changeset: e0552f13f4a2 Author:sherman Date: 2013-01-23 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0552f13f4a2 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently Summary: fixed the test case Reviewed-by: alanb !

Re: Request for review: 6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86

2013-01-23 Thread Vladimir Kozlov
To close this discussion before I do the push here are performance numbers for C1. Numbers are almost similar (few % worser, note that with C2 it improved) because C1 does not do loop optimizations. size: 1time: 2526 size: 7time: 3334 size: 8time: 3436 size: 16

hg: jdk8/tl/langtools: 8006694: temporarily workaround combo tests are causing time out in several platforms

2013-01-23 Thread vicente . romero
Changeset: 5c956be64b9e Author:vromero Date: 2013-01-23 20:57 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c956be64b9e 8006694: temporarily workaround combo tests are causing time out in several platforms Reviewed-by: jjg Contributed-by:

hg: jdk8/tl/jdk: 8006591: Protect keystore entries using stronger PBE algorithms

2013-01-23 Thread vincent . x . ryan
Changeset: 0c86df653029 Author:vinnie Date: 2013-01-23 21:25 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c86df653029 8006591: Protect keystore entries using stronger PBE algorithms Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java !

hg: jdk8/tl/langtools: 8006775: JSR 308: Compiler changes in JDK8

2013-01-23 Thread jonathan . gibbons
Changeset: 71f35e4b93a5 Author:jjg Date: 2013-01-23 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/71f35e4b93a5 8006775: JSR 308: Compiler changes in JDK8 Reviewed-by: jjg Contributed-by: mer...@cs.washington.edu, wmdi...@cs.washington.edu, mp...@csail.mit.edu,

hg: jdk8/tl/jdk: 8005408: KeyStore API enhancements

2013-01-23 Thread vincent . x . ryan
Changeset: 1da93663f8f3 Author:vinnie Date: 2013-01-23 23:13 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da93663f8f3 8005408: KeyStore API enhancements Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java +

Re: zip64 compatibility problems

2013-01-23 Thread Martin Buchholz
Ping. On Wed, Jan 16, 2013 at 12:24 PM, Martin Buchholz marti...@google.comwrote: On Tue, Jan 15, 2013 at 5:33 PM, Martin Buchholz marti...@google.com wrote: Actually, I think y'all should do 3 things: - backport Kumar's bug fix to jdk7 - introduce a system property to turn off the zip64

hg: jdk8/tl/jdk: 8006813: Compilation error in PKCS12KeyStore.java

2013-01-23 Thread sean . mullan
Changeset: 89f37f7188df Author:mullan Date: 2013-01-23 20:46 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89f37f7188df 8006813: Compilation error in PKCS12KeyStore.java Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java

Re: OPENJDK env var not playing well with new build

2013-01-23 Thread David Holmes
On 23/01/2013 10:12 PM, Erik Joelsson wrote: On 2013-01-23 12:54, David Holmes wrote: On 23/01/2013 8:58 PM, Erik Joelsson wrote: On 2013-01-23 11:30, Weijun Wang wrote: I thought building an OpenJDK or Oracle JDK can be fully controlled by using the --enable-openjdk-only configure option,

hg: jdk8/tl/langtools: 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model

2013-01-23 Thread joe . darcy
Changeset: 09f65aad4759 Author:darcy Date: 2013-01-23 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09f65aad4759 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model Reviewed-by: jjg !

Re: zip64 compatibility problems

2013-01-23 Thread Xueming Shen
Hi Martin, sorry for the late response, was busy on other stuff these days. I'm OK with the idea of introducing a system property to turn off zip64 support, but NOT by default. You can make it default in your internal build. You do the code, I do the internal process/paper work (need go CCC for