Changeset: b1deb90d2e37
Author:vromero
Date: 2013-02-08 09:15 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1deb90d2e37
8005931: javac doesn't set ACC_STRICT for classes with package access
Reviewed-by: mcimadamore
!
Changeset: 017e8bdd440f
Author:vromero
Date: 2013-02-08 09:21 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/017e8bdd440f
7167125: Two variables after the same operation in a inner class return
different results
Reviewed-by: jjg, mcimadamore
!
The build part of this review looks good to me.
/Erik
On 2013-02-07 19:31, Xueming Shen wrote:
Hi,
8007572: Replace existing jdk timezone data at java.home/lib/zi with
JSR310's tzdb.
Webrev:
http://cr.openjdk.java.net/~sherman/8007572/
Note:
JDK/JRE has been using the time zone data at
Apologies, you are correct. I'll book an appointment with the optician!
-Chris.
On 08/02/2013 00:15, David Holmes wrote:
On 7/02/2013 10:54 PM, Chris Hegarty wrote:
On 02/07/2013 11:54 AM, David Holmes wrote:
AFAICS setting len=0 means len==0 will be true and so we will
free(result).
On 02/07/2013 07:31 PM, Xueming Shen wrote:
8007392: JSR 310: DateTime API Updates
Webrev:
http://cr.openjdk.java.net/~sherman/8007392/
http://cr.openjdk.java.net/~sherman/8007392/javadoc
I don't think you mention that the reference to ISO 8601 actually refers
to ISO 8601:1988 with
On 8 February 2013 11:00, Florian Weimer fwei...@redhat.com wrote:
8007392: JSR 310: DateTime API Updates
Webrev:
http://cr.openjdk.java.net/~sherman/8007392/
http://cr.openjdk.java.net/~sherman/8007392/javadoc
I don't think you mention that the reference to ISO 8601 actually refers to
On 8 February 2013 00:23, Remi Forax fo...@univ-mlv.fr wrote:
I wonder if it's not better to declare enum constants of DayOfWeek (and
Month) in an order that is not the usual week/month order to make clear that
ordinal() doesn't work as expected.
By example they can be declared in alphabetical
Am 08.02.2013 01:15, schrieb Henry Jen:
The specdiff and webrev is available at
http://cr.openjdk.java.net/~henryjen/ccc/8006884.0/
Please include me in the reply as I don't necessary receiving emails
from all aliases.
In Files.lines(...):
After returned from this method, if an I/O error
On 02/08/2013 12:12 PM, Stephen Colebourne wrote:
On 8 February 2013 00:23, Remi Forax fo...@univ-mlv.fr wrote:
I wonder if it's not better to declare enum constants of DayOfWeek (and
Month) in an order that is not the usual week/month order to make clear that
ordinal() doesn't work as
Hi,
We may need to tighten this up; by calling out ISO, folks may
incorrectly assume various features that are by design not reflected in
the API.
Either we need to say what aspects of 8601 and version the API conforms to
and /or list the variances.
Roger
On 2/8/2013 6:11 AM, Stephen
On 02/08/2013 03:15 PM, Roger Riggs wrote:
We may need to tighten this up; by calling out ISO, folks may
incorrectly assume various features that are by design not reflected in
the API.
Either we need to say what aspects of 8601 and version the API conforms to
and /or list the variances.
You
On Thu, Feb 7, 2013 at 9:58 PM, Joe Darcy joe.da...@oracle.com wrote:
Hi Martin,
IIRC, your @since checker was based on parsing javadoc output. If so, it
(like BlenderRev) might have been rendered unusable out of the box due to
the changes in javadoc output made since those tools were
Greetings:
I posted a new webrev image:
http://cr.openjdk.java.net/~jzavgren/8007609/webrev.03/
http://cr.openjdk.java.net/%7Ejzavgren/8007609/webrev.03/
The sole functional revision is contained in the following small code
snippet:
-/* retry with a buffer of the right size
It would be interesting to know the number of thrown throwables in the
JVM, to be able to do some high level application diagnostics /
statistics. A good way to put this number would be a performance
counter, since it is accessible both from Java and from the VM.
On 02/08/2013 04:09 AM, Ulf Zibis wrote:
Am 08.02.2013 01:15, schrieb Henry Jen:
In Files.lines(...):
After returned from this method, if an I/O error occurs reading ...
should be:
After returned from this method, if an I/O error occurs while reading ...
In Files.walk(...):
... a given
Changeset: 79d7595abe95
Author:naoto
Date: 2013-02-08 09:35 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79d7595abe95
8007038: ArrayIndexOutOfBoundsException on calling localizedDateTime().print()
with JapaneseChrono
Reviewed-by: okutsu
!
Am 08.02.2013 18:25, schrieb Henry Jen:
On 02/08/2013 04:09 AM, Ulf Zibis wrote:
Do those streams close automatically from finalize() method, if released
to GC, e.g. by nulling the referencing variable? ...and if not, why?
The stream doesn't do that, it's transparent to whatever the underlying
Hi,
Please review
http://cr.openjdk.java.net/~ksrini/8007519/webrev.0/
Bug:
https://jbs.oracle.com/bugs/browse/JDK-8007519
Thanks
Kumar
Hi all,
Could I have a couple of review for this change:
7087570: java.lang.invoke.MemberName information wrong for method
handles created with findConstructor
Summary: REF_invokeSpecial DMHs (which are unusual) get marked
explicitly; tweak the MHI to use this bit
Reviewed-by: ?
Webrev:
Looks good to me.
- jjh
On 2/8/2013 10:19 AM, Kumar Srinivasan wrote:
Hi,
Please review
http://cr.openjdk.java.net/~ksrini/8007519/webrev.0/
Bug:
https://jbs.oracle.com/bugs/browse/JDK-8007519
Thanks
Kumar
On 08/02/2013 12:09, Ulf Zibis wrote:
:
Do those streams close automatically from finalize() method, if
released to GC, e.g. by nulling the referencing variable? ...and if
not, why?
-Ulf
We don't use finalizers in this area. Aside from the overhead, the other
issue here is that file
On 08/02/2013 17:03, John Zavgren wrote:
Greetings:
I posted a new webrev image:
http://cr.openjdk.java.net/~jzavgren/8007609/webrev.03/
http://cr.openjdk.java.net/%7Ejzavgren/8007609/webrev.03/
The sole functional revision is contained in the following small
code snippet:
-
Hello,
On 2/6/2013 11:32 PM, Bruce Chapman wrote:
Stephen, In your case(s) would the workaround fail to work if the bug
was fixed?
Working around a bug is quite different to taking advantage of the
buggy behaviour. If fixing the bug would break code that works around
it that can be seen as
Hi
The webrev and the javadoc have been updated with some last
minute changes mainly to support non-iso calendar formatting/parsing.
http://cr.openjdk.java.net/~sherman/8007392/
http://cr.openjdk.java.net/~sherman/8007392/javadoc
Thanks!
-Sherman
On 02/07/2013 10:31 AM, Xueming Shen wrote:
We've established that it causes problems (me and Paul) and that likely
workarounds of the bug would not be broken by a fix.
The getMethods case is very different as the spec clearly allowed the
behavior. Here the spec and method name are also clear on the expected
behavior. The proposal would
Changeset: 522fb3867a3a
Author:darcy
Date: 2013-02-08 16:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/522fb3867a3a
8005623: Retrofit FunctionalInterface annotations to core platform interfaces
Reviewed-by: mduigou, chegar, alanb
!
Changeset: 60caf53b98e2
Author:jjg
Date: 2013-02-08 17:35 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/60caf53b98e2
8007610: javadoc doclint does not work with -private
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javadoc/DocEnv.java
!
27 matches
Mail list logo
