hg: jdk8/tl/jdk: 8009604: old make images failed: JarBASE64Encoder class not found

Changeset: cf54f6be3e9e Author:weijun Date: 2013-03-07 11:32 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf54f6be3e9e 8009604: old make images failed: JarBASE64Encoder class not found Reviewed-by: xuelei, wetmore ! make/common/Release.gmk

Re: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so

Pushed to jdk8/tl/jdk. I recommend this be backported to jdk7u.

hg: jdk8/tl/jdk: 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so

Changeset: 14e49a70729a Author:martin Date: 2013-03-06 17:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/14e49a70729a 8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so Summary: Define FILES_m to force use of linker script Reviewed-by: sherman, a

Re: Request for review- RFE 8005716

On 3/6/2013 12:50 PM, Mike Duigou wrote: Hi Bill; Some notes from reviewing the JDK side changes. System.java/Runtime.java: The example which begins with the name "If the filename argument, " needs to better identify that "L" is an example. (Italics?) Re-worded that a bit. java/lang/ClassL

Re: Java regex vs. Unicode TR#18 vs. ICU

On 3/6/13 1:06 PM, Xueming Shen wrote: On 03/06/2013 12:44 PM, Steven R. Loomis wrote: Hello, Someone on the ICU team recently compared the use of "\w" between ICU, Java, and Unicode TR#18 . The results are in the following ICU b

Re: Java regex vs. Unicode TR#18 vs. ICU

On 03/06/2013 12:44 PM, Steven R. Loomis wrote: Hello, Someone on the ICU team recently compared the use of "\w" between ICU, Java, and Unicode TR#18 . The results are in the following ICU bug

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

On 3/6/2013 11:42 AM, Jim Gish wrote: http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ L122-125: you may want to replace with {@code } I think we'll save that for a later day - and then update all the occurrences of to {@code} Fine with me. L129-130

Re: CFR - updated 8001667: Comparator combinators and extension methods

On 03/06/2013 02:31 AM, Michael Hixson wrote: > Hello, > > I'm not one of the people that you're looking at to review this, but I > have to give this feedback anyway. I tried to give similar feedback > on another mailing list and got no response (maybe I chose the wrong > list). These changes ha

Java regex vs. Unicode TR#18 vs. ICU

Hello, Someone on the ICU team recently compared the use of "\w" between ICU, Java, and Unicode TR#18 . The results are in the following ICU bug . A question for core-libs-dev is, d

Re: Request for review- RFE 8005716

Actually for windows I *did* export the undecorated name. I just didn't see where I did it in the VS IDE. If you don't export the undecorated name it doesn't work of course. bill On 3/5/2013 11:13 PM, BILL PITTORE wrote: On 3/5/2013 7:36 PM, Dean Long wrote: If JNI_ONLOAD_SYMBOLS contains som

Re: CFR - updated 8001667: Comparator combinators and extension methods

On 03/06/2013 03:28 AM, Ali Ebrahimi wrote: > Hi, > just one suggestion: > > rename comparing with compareWith > There was a round of discussion on naming. http://mail.openjdk.java.net/pipermail/lambda-libs-spec-observers/2012-November/000446.html I have my personal preference among proposals,

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

On 03/06/2013 12:58 PM, Mandy Chung wrote: On 3/5/2013 9:16 AM, Jim Gish wrote: On 03/01/2013 05:48 PM, Mandy Chung wrote: On 3/1/2013 1:25 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from

Re: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket

Staffan, Thank you for the confirmation and taking care about this issue! Thanks, Serguei On 3/6/13 11:36 AM, Staffan Larsen wrote: Nice catch, Serguei! Unfortunately I have already pushed my change, but I filed "JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite loop" t

Re: RFR(S): 8009397 test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket

Nice catch, Serguei! Unfortunately I have already pushed my change, but I filed "JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite loop" to track this new problem and I am working on a fix. Thanks, /Staffan On 5 mar 2013, at 20:26, serguei.spit...@oracle.com wrote: > Hi S

Re: Review: 7032154 - Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal

The link below has been updated with a few minor changes, notably to use constants from {Double,Float}Consts and to include the link to the OpenJDK issue report. A formatting issue resulting from an awk failure during webrev script execution was also fixed. B. On Feb 28, 2013, at 1:34 PM, Bria

Re: RFR: 8007808: Missing method: Executable.getAnnotatedReturnType()

Thanks for the reviews Joe and Remi cheers /Joel On 6 mar 2013, at 17:15, Remi Forax wrote: > Hi Joel, > looks good for me too :) > > Rémi > > On 03/06/2013 04:35 PM, Joe Darcy wrote: >> Hi Joel, >> >> Look good; approved. >> >> -Joe >> >> On 3/6/2013 6:37 AM, Joel Borggrén-Franck wrote: >

hg: jdk8/tl: 8009019: Updates to generated-configure.sh required for 8008914

Changeset: cb0ac8979caa Author:tbell Date: 2013-02-26 09:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cb0ac8979caa 8009019: Updates to generated-configure.sh required for 8008914 Reviewed-by: sundar, jlaskey, jjg ! common/autoconf/generated-configure.sh

RE: JDK 8 RFR: 8009267: Restore isAnnotationPresent methods in public AnnotatedElement implementations

Looks good to me! Are this the only methods in the corelib that were removed in favour of a default implementation in the interface? Uwe - Uwe Schindler uschind...@apache.org Apache Lucene PMC Member / Committer Bremen, Germany http://lucene.apache.org/ > -Original Message- > From:

Re: Request for review- RFE 8005716

If JNI_ONLOAD_SYMBOLS contains something like "_JNI_OnLoad@8" on Windows, you can't just turn that into "_JNI_OnLoad@8_" + . I think it needs to be "_JNI_OnLoad_" + + "@8" Looks like onLoadSymbols[] is unused in Java_java_lang_ClassLoader_00024NativeLibrary_findBuiltinLib(). Instead of add

Re: CFR - updated 8001667: Comparator combinators and extension methods

Hi, just one suggestion: rename comparing with compareWith 1) public static > Comparator compareWith(Function keyExtractor) { 2) default Comparator thenCompareWith(Comparator other) Best Regards, Ali Ebrahimi On Wed, Mar 6, 2013 at 12:16 AM, Henry Jen wrote: > Hi, > > Another update to re

Re: CFR - updated 8001667: Comparator combinators and extension methods

Hello, I'm not one of the people that you're looking at to review this, but I have to give this feedback anyway. I tried to give similar feedback on another mailing list and got no response (maybe I chose the wrong list). These changes have been bothering me. :) 1. Why disable the following cod

Re: RFR : JDK-8001642 : Add Optional, OptionalDouble, OptionalInt, OptionalLong

Really, this is a lot of fuss over nothing. There is actually no fundamental difference between Scala's Option, Guava's Optional, Fugue's Option, Java's Optional and Haskell's Maybe – they are modelling the same thing, the possibility of a value not being present. The fact that there may be min

Re: Request for review- RFE 8005716

Hi Bill; Some notes from reviewing the JDK side changes. System.java/Runtime.java: The example which begins with the name "If the filename argument, " needs to better identify that "L" is an example. (Italics?) java/lang/ClassLoader.java: NativeLibrary::fromClass could be final. ClassLoade

Re: RFR : JDK-8001642 : Add Optional, OptionalDouble, OptionalInt, OptionalLong

There is no need for an Option container to show how nested collections may be misused, you could just as easily show an example of a List>> that is isomorphic to a flattened Iterable . I'd simply point to the utility of the monadic bind or flatMap function! There are several reasons why Option

RE: JDK 8 RFR: 8009267: Restore isAnnotationPresent methods in public AnnotatedElement implementations

My intention was to say "implementation removed". Uwe - Uwe Schindler uschind...@apache.org Apache Lucene PMC Member / Committer Bremen, Germany http://lucene.apache.org/ > -Original Message- > From: Joe Darcy [mailto:joe.da...@oracle.com] > Sent: Monday, March 04, 2013 5:16 PM > To:

Re: RFR : JDK-8001642 : Add Optional, OptionalDouble, OptionalInt, OptionalLong

Whatever happened to the elvis operator solution from project coin, surely that solves the majority of issues Optional was meant to solve anyway, without the headache of type-mix mud clutering up the code. http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/47.html _ From: R

Re: Request for review- RFE 8005716

On 3/5/2013 8:13 PM, BILL PITTORE wrote: On 3/5/2013 7:36 PM, Dean Long wrote: If JNI_ONLOAD_SYMBOLS contains something like "_JNI_OnLoad@8" on Windows, you can't just turn that into "_JNI_OnLoad@8_" + . I think it needs to be "_JNI_OnLoad_" + + "@8" I'll look into that. When I built for win

hg: jdk8/tl/jdk: 8006853: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout < 0

Changeset: 7246a6e4dd5a Author:juh Date: 2013-02-28 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7246a6e4dd5a 8006853: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout < 0 Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/OCSP.jav

Re: Request for review- RFE 8005716

On Mar 6 2013, at 08:21 , Bob Vandette wrote: > For a traditional > JRE that doesn't even require static library support, we'd have to make sure > to run on a VM that > support JNI_VERSION_1_8. It looks like the JDK maintains their own copy of > jni.h. In earlier days the jni.h file was copie

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

On 3/5/2013 9:16 AM, Jim Gish wrote: On 03/01/2013 05:48 PM, Mandy Chung wrote: On 3/1/2013 1:25 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from Logger.findResourceBundle() It's good to s

hg: jdk8/tl/jdk: 8007808: Missing method: Executable.getAnnotatedReturnType()

Changeset: 38e1821c4472 Author:jfranck Date: 2013-03-06 18:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/38e1821c4472 8007808: Missing method: Executable.getAnnotatedReturnType() Reviewed-by: darcy, forax ! src/share/classes/java/lang/reflect/Constructor.java ! src/share

Re: RFR: 8006593: Performance and compatibility improvements to hash based Map implementations

On 05/03/2013 22:46, Mike Duigou wrote: I have updated the webrev to remove the useAltHashing boolean. http://cr.openjdk.java.net/~mduigou/JDK-8006593/5/webrev/ Mike Peter's suggestion to remove the useAltHashing field is a great idea. I've looked at the webrev and it looks good to me. The l

Re: RFR: 8006593: Performance and compatibility improvements to hash based Map implementations

On Mar 6 2013, at 09:19 , Alan Bateman wrote: > On 05/03/2013 22:46, Mike Duigou wrote: >> >> I have updated the webrev to remove the useAltHashing boolean. >> >> http://cr.openjdk.java.net/~mduigou/JDK-8006593/5/webrev/ >> >> Mike >> > Peter's suggestion to remove the useAltHashing field is

hg: jdk8/tl: 8009162: root repo "make test" target should run against image

Changeset: b35d986ff276 Author:mduigou Date: 2013-03-06 08:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b35d986ff276 8009162: root repo "make test" target should run against image Reviewed-by: alanb, martin, erikj ! common/makefiles/Main.gmk

Re: Request for review- RFE 8005716

On Mar 5, 2013, at 7:36 PM, Dean Long wrote: > If JNI_ONLOAD_SYMBOLS contains something like "_JNI_OnLoad@8" on Windows, you > can't just > turn that into "_JNI_OnLoad@8_" + . I think it needs to be > "_JNI_OnLoad_" + + "@8" > Good catch Dean. > Looks like onLoadSymbols[] is unused in > J

Re: RFR: 8007808: Missing method: Executable.getAnnotatedReturnType()

Hi Joel, looks good for me too :) Rémi On 03/06/2013 04:35 PM, Joe Darcy wrote: Hi Joel, Look good; approved. -Joe On 3/6/2013 6:37 AM, Joel Borggrén-Franck wrote: Hi, Can I get a review of this small fix for issue 8007808: Missing method: Executable.getAnnotatedReturnType() http://cr.o

Re: RFR : JDK-8001642 : Add Optional, OptionalDouble, OptionalInt, OptionalLong

Just another idea: findFirst() throws NoSuchElementException if the stream is empty. Add an intermediary operation that maps an empty stream to a non-empty one Stream ifEmpty(T item); so we can say stream.ifEmpty(null).findFirst(); stream.ifEmpty(0).reduce(sum); stream.ifEmpt

hg: jdk8/tl/langtools: 3 new changesets

Changeset: d0178bd8125c Author:mcimadamore Date: 2013-03-06 15:29 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0178bd8125c 8009299: Javac crashes when compiling method reference to static interface method Summary: Assertion in Check.checMethod is too strict Reviewed

Re: RFR: 8007808: Missing method: Executable.getAnnotatedReturnType()

Hi Joel, Look good; approved. -Joe On 3/6/2013 6:37 AM, Joel Borggrén-Franck wrote: Hi, Can I get a review of this small fix for issue 8007808: Missing method: Executable.getAnnotatedReturnType() http://cr.openjdk.java.net/~jfranck/8007808/webrev.00/ When we added Core Reflection support

RFR: 8007808: Missing method: Executable.getAnnotatedReturnType()

Hi, Can I get a review of this small fix for issue 8007808: Missing method: Executable.getAnnotatedReturnType() http://cr.openjdk.java.net/~jfranck/8007808/webrev.00/ When we added Core Reflection support for type annotations this method got left out on Executable, but were included on Metho

Re: Request for review- RFE 8005716

On 05/03/2013 23:05, bill.pitt...@oracle.com wrote: This request is tied to bugid 8005716 that deals with adding support for statically linked JNI libraries. The JEP is here: http://openjdk.java.net/jeps/178 The bug is here:http://bugs.sun.com/view_bug.do?bug_id=8005716 The webrevs are here:

Re: Request for review- RFE 8005716

On 06/03/2013 04:13, BILL PITTORE wrote: On 3/5/2013 7:36 PM, Dean Long wrote: If JNI_ONLOAD_SYMBOLS contains something like "_JNI_OnLoad@8" on Windows, you can't just turn that into "_JNI_OnLoad@8_" + . I think it needs to be "_JNI_OnLoad_" + + "@8" I'll look into that. When I built for win

Re: RFR : JDK-8001642 : Add Optional, OptionalDouble, OptionalInt, OptionalLong

On 03/06/2013 11:54 AM, Jed Wesley-Smith wrote: Really, this is a lot of fuss over nothing. There is actually no fundamental difference between Scala's Option, Guava's Optional, Fugue's Option, Java's Optional and Haskell's Maybe – they are modelling the same thing, the possibility of a value

hg: jdk8/tl/jdk: 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket

Changeset: 34372bb9115d Author:sla Date: 2013-03-05 19:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34372bb9115d 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket Reviewed-by: alanb ! src/share/back/tran

Re: RFR : JDK-8001642 : Add Optional, OptionalDouble, OptionalInt, OptionalLong

Ok, let be nuclear on this, There is no good reason to introduce Optional in java.util. It doen't work like Google's Guava Optional despite having the same name, it doesn't work like Scala's Option despite having a similar name, moreover the lambda pipeline face a similar issue with the design

Re: CFR - updated 8001667: Comparator combinators and extension methods

Hi Henry, Minor thing. In Comparator: 194 * @param other the other comparator used when equals on this. 195 * @throws NullPointerException if the argument is null. 196 * @since 1.8 197 */ 198 default Comparator thenComparing(Comparator other) { 199 return Co