Re: [PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently

2013-03-13 Thread Eric Wang
Hi, Please review the code change, I have updated the test to make sure test only access files and directories created by itself. http://cr.openjdk.java.net/~ewang/8009258/webrev.01/ Here is the execution result: http://cr.openjdk.java.net/~ewang/8009258/GeneralWin32.jtr Thanks, Eric On

hg: jdk8/tl/jdk: 7190897: (fs) Files.isWritable method returns false when the path is writable (win)

2013-03-13 Thread alexey . utkin
Changeset: e497a050e059 Author:uta Date: 2013-03-13 13:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e497a050e059 7190897: (fs) Files.isWritable method returns false when the path is writable (win) Summary: The [GetEffectiveRightsFromAcl] based implementation was

Re: Review Request: JDK-8001334 - Remove use of JVM_* functions from java.io code

2013-03-13 Thread Alan Bateman
On 12/03/2013 22:19, Dan Xu wrote: I understand now. Here is the updated webrev to directly map IO_Append to handleWrite in *nix platforms, http://cr.openjdk.java.net/~dxu/8001334/webrev.03/. I checked FileOutputStream.java source code, and we do guarantee the consistency of append flag

Re: Review Request: JDK-8001334 - Remove use of JVM_* functions from java.io code

2013-03-13 Thread Alexey Utkin
On 12.03.2013 3:43, Dan Xu wrote: Thanks for all your comments. I have updated the fix accordingly. Please see the webrev at http://cr.openjdk.java.net/~dxu/8001334/webrev.02/. For the language concern in getLastErrorString(char *buf, size_t len) function, I will log another bug and address

Code review request: 8009977: A test library to launch multiple Java processes (using krb5 as an example)

2013-03-13 Thread Weijun Wang
http://cr.openjdk.java.net/~weijun/8009977/webrev.00 /** * This is a test library that makes writing a Java test that spawns multiple * Java processes easily. * * Usage: * *Proc.create(Clazz) // The class to launch *.args(x)// with args *.env(env,

Re: Review Request: JDK-8001334 - Remove use of JVM_* functions from java.io code

2013-03-13 Thread Dan Xu
Thank you for the review. I will push it today. -Dan On 03/13/2013 03:39 AM, Alan Bateman wrote: On 12/03/2013 22:19, Dan Xu wrote: I understand now. Here is the updated webrev to directly map IO_Append to handleWrite in *nix platforms, http://cr.openjdk.java.net/~dxu/8001334/webrev.03/. I

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-13 Thread Jim Gish
Mandy, The CCC request has been approved. Please push the changeset at http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch.patch/ http://cr.openjdk.java.net/%7Ejgish/Bug8002070-RemoveResourceBundleStackSearch.patch/ Thanks, Jim On 03/08/2013 05:51 PM, Mandy

hg: jdk8/tl/jdk: 8009751: (se) Selector spin when select, close and interestOps(0) invoked at same time (lnx)

2013-03-13 Thread alan . bateman
Changeset: e33cbbe21419 Author:alanb Date: 2013-03-13 17:58 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e33cbbe21419 8009751: (se) Selector spin when select, close and interestOps(0) invoked at same time (lnx) Reviewed-by: zhouyx, chegar, robm !

hg: jdk8/tl/jdk: 8002070: Remove the stack search for a resource bundle for Logger to use

2013-03-13 Thread mandy . chung
Changeset: 94335b6ffb32 Author:jgish Date: 2013-03-13 11:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94335b6ffb32 8002070: Remove the stack search for a resource bundle for Logger to use Summary: The fragile, vulnerable, stack crawling has been eliminated from

hg: jdk8/tl/langtools: 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error

2013-03-13 Thread joel . franck
Changeset: eb0198033c5c Author:jfranck Date: 2013-03-13 22:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eb0198033c5c 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error Reviewed-by: jjg !

hg: jdk8/tl/jdk: 8001334: Remove use of JVM_* functions from java.io code

2013-03-13 Thread dan . xu
Changeset: ef0c60b93a17 Author:dxu Date: 2013-03-13 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef0c60b93a17 8001334: Remove use of JVM_* functions from java.io code Summary: Replace JVM_* functions with direct system calls in java io area Reviewed-by: alanb, uta,

hg: jdk8/tl/jdk: 8009650: HttpClient available() check throws SocketException when connection has been closed

2013-03-13 Thread rob . mckenna
Changeset: f5c85c0a9af0 Author:robm Date: 2013-03-14 00:21 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5c85c0a9af0 8009650: HttpClient available() check throws SocketException when connection has been closed Reviewed-by: chegar, khazra, dsamersoff Contributed-by:

Re: RFR: 8009428 and 8009429 - Profile related fixes and clean ups

2013-03-13 Thread Jonathan Gibbons
The langtools changes look OK to me. -- Jon On 03/10/2013 06:24 PM, David Holmes wrote: I had overlooked the need to update the ct.sym creation tool to recognize the new syntax in the profile spec file. That process also uncovered a few bugs in the listing that needed correcting. The

Re: [JSR310 M7 Review request] 8007572: Replace existing jdk timezone data at java.home/lib/zi with JSR310's tzdb.

2013-03-13 Thread Andrew Hughes
- Original Message - The build part of this review looks good to me. Judging by this changeset, I gather javazic is no longer being run. If so, why is the source code being retained in the tree? It means that a build of OpenJDK against itself now fails. The new build system currently

Re: [JSR310 M7 Review request] 8007572: Replace existing jdk timezone data at java.home/lib/zi with JSR310's tzdb.

2013-03-13 Thread Xueming Shen
This should have been addessed via JDK-8008348 *The leftover jdk/make/tools/javazic causes build problems with hs25-b19 control job* https://jbs.oracle.com/bugs/browse/JDK-8008348 -Sherman On 3/13/13 7:19 PM, Andrew Hughes wrote: - Original Message - The build part of this review

Re: [PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently

2013-03-13 Thread Eric Wang
Including more reviewer... Thanks, Eric On 2013/3/13 14:28, Eric Wang wrote: Hi, Please review the code change, I have updated the test to make sure test only access files and directories created by itself. http://cr.openjdk.java.net/~ewang/8009258/webrev.01/ Here is the execution result:

Re: [JSR310 M7 Review request] 8007572: Replace existing jdk timezone data at java.home/lib/zi with JSR310's tzdb.

2013-03-13 Thread David Holmes
On 14/03/2013 12:51 PM, Xueming Shen wrote: This should have been addessed via JDK-8008348 *The leftover jdk/make/tools/javazic causes build problems with hs25-b19 control job* https://jbs.oracle.com/bugs/browse/JDK-8008348 Which is still in the tl repo and unlikely to reach jdk8/jdk8 till

Re: RFR: 8009428 and 8009429 - Profile related fixes and clean ups

2013-03-13 Thread David Holmes
Hi Alan, On 12/03/2013 8:05 PM, Alan Bateman wrote: On 12/03/2013 07:10, David Holmes wrote: : For the intro comment in profile-rtjar-includes.txt then it might be useful to beef up the comment to explain what happens when an API package does not match one of the rules, ie: does it go into

hg: jdk8/tl/jdk: 8009429: Miscellaneous profiles cleanup; ...

2013-03-13 Thread david . holmes
Changeset: 41289b4a1819 Author:dholmes Date: 2013-03-14 01:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41289b4a1819 8009429: Miscellaneous profiles cleanup 8009428: Revert changes to $ substitution performed as part of nashorn integration Reviewed-by: alanb, erikj !

hg: jdk8/tl: 8009428: Revert changes to $ substitution performed as part of nashorn integration

2013-03-13 Thread david . holmes
Changeset: 19a59a13b3ef Author:dholmes Date: 2013-03-14 01:41 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/19a59a13b3ef 8009428: Revert changes to $ substitution performed as part of nashorn integration Reviewed-by: alanb, erikj ! common/makefiles/MakeBase.gmk

tl forest update

2013-03-13 Thread David Holmes
Sorry for the wide distribution but you all see the push messages anyway. I've just pushed a coordinated set of changes to the top-level, langtools and jdk repos in the tl forest. If you use tl you will need to ensure that you update all of these repos to ensure they are in sync. Thanks,