Mandy,
I would like to add few performance advices in the PlatformLogger Javadoc:
NOTE: For performance reasons, PlatformLogger usages should take care of
avoiding useless / wasted object creation and method calls related to *
disabled* log statements:
Always use isLoggable(level) wrapping logs
Dear java2d members,
I figured out some troubles in java2d.pipe.AAShapePipe related to both
concurrency memory usage:
- concurrency issue related to static theTile field: only 1 tile is cached
so a new byte[] is created for other threads at each call to renderTile()
- excessive memory usage
On 04/03/13 06:35, Doug Lea wrote:
This was designed to perform best in the case of possibly contended
updates when the element is absent, by avoiding retraversal, and
thus minimizing lock hold times in the common case. (When not common,
it can be guarded by a contains check.) However even in
On 03/04/2013 17:38, Joe Darcy wrote:
Hi Peter,
On 04/03/2013 01:26 AM, Peter Levart wrote:
Hi Joe,
Why not using StringBuilder instead of StringBuffer in
Class.toGenericString ?
No reason. Thanks for catching this; I'll use StringBuilder in the
final push.
Modifier.toString can probably
Hi all,
While finishing up the netbeans JDBC project, I tried to run the jtreg target
and received the following error;
/Users/lance/Documents/hg-workspaces/jdk8/jdbc-jdk/jdk/make/netbeans/common/shared.xml:289:
A source file is missing
On 04/04/2013 22:58, Mandy Chung wrote:
Alan - can you review this change?
I have changed Level.valueOf(int) to return the nearest Level as Peter
suggests using binary search:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8011380/webrev.01/
I want to push the changeset tomorrow since we
Laurent,
I believe this was mentioned somewhere in j.u.logging. A better
solution may be to take java.util.function.Supplier parameter that
constructs the log message lazily (see
http://download.java.net/jdk8/docs/api/java/util/logging/Logger.html#fine(java.util.function.Supplier).
I can
Mandy,
I agree it should be well known; but I fixed several cases in awt/net code
where isLoggable() calls were missing.
I think it is quite cheap to remind good practices in the PlatformLogger /
jul Logger javadoc ...
PS: maybe some quality control tools could check such missing tests (PMD
can
Laurent,
I believe the awt/net code started logging in 1.4 and 1.5 using
j.u.logging that was really early taker before the performance overhead
was considered.
I filed a bug 8011557: improve the logging documentation to advice on
performance consideration as we may want to mention this in
I have updated this webrev, now at:
http://cr.openjdk.java.net/~briangoetz/JDK-8008670.3/webrev/
These are all nonpublic implementation-only files (no public APIs) that
do not depend on the public Stream APIs.
These can go back as soon as the changes to Map and Spliterator are put
back.
On 04/05/2013 05:46 AM, Alan Bateman wrote:
On 03/04/2013 17:38, Joe Darcy wrote:
Hi Peter,
On 04/03/2013 01:26 AM, Peter Levart wrote:
Hi Joe,
Why not using StringBuilder instead of StringBuffer in
Class.toGenericString ?
No reason. Thanks for catching this; I'll use StringBuilder in the
thanks, Mark!
On Apr 5, 2013, at 11:08 AM, mark.reinh...@oracle.com wrote:
Posted: http://openjdk.java.net/jeps/180
- Mark
Opt-in via Comparable seems rather risky to me.
It's not just potential divergence between equals() and compareTo(),
which the Comparable specification explicitly allows. At the very
least, you'd have to add totally separate balanced trees for each class
of key objects.
--
Florian Weimer /
looks ok
On Apr 5, 2013, at 5:18 PM, Jim Gish wrote:
Please review trivial change to add back in delete of test files on test
completion.
http://cr.openjdk.java.net/~jgish/Bug8006036-WinCommand/
http://cr.openjdk.java.net/%7Ejgish/Bug8006036-WinCommand/
Thanks,
Jim
--
Jim Gish
I'm still advocating an optimistic approach, that does not hold the lock
during the first traversal of the array snapshot. This is much faster when
cache hits are the norm (or equals methods are expensive), which I would
hope would be the common case, and only slightly slower when all adds are
Thank you. Could someone push it for me please.
Cheers,
Jim
On 04/05/2013 05:21 PM, Lance Andersen - Oracle wrote:
looks ok
On Apr 5, 2013, at 5:18 PM, Jim Gish wrote:
Please review trivial change to add back in delete of test files on test
completion.
I can look to do this Monday for you for Sunday eve
I am away from my primary system right now
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Apr 5, 2013, at 5:29
Hi All,
Please review the change to fix the build issue on mac platformat
http://cr.openjdk.java.net/~dxu/8011602/webrev/.It removes the
un-necessary @Native annotation from
src/macosx/native/jobjc/src/core/java/com/apple/jobjc/Coder.java.
Therefore, the objc compilation will not dependon
Thumbs up. Thanks for fixing it quickly. The macosx jobjc build has
its own special build logic that brought some surprise when I merged it
with jigsaw at one time.
Mandy
On 4/5/2013 3:35 PM, Dan Xu wrote:
Hi All,
Please review the change to fix the build issue on mac platformat
Changeset: 15c1642967c9
Author:andrew
Date: 2013-04-02 13:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/15c1642967c9
8009988: build-infra: Fix configure output for zip debuginfo check
Summary: No output from zip debuginfo option when default is used.
Reviewed-by: tbell
!
Changeset: 59a41e1357ab
Author:amurillo
Date: 2013-03-23 10:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59a41e1357ab
8010498: new hotspot build - hs25-b25
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: eca90b8a06eb
Author:rdurbin
Date: 2013-03-19
Dan,
Looks okay to me - glad there was a simple solution.
Still wondering why this didn't get picked up during JPRT testing though ??
Thanks,
David
On 6/04/2013 9:21 AM, Dan Xu wrote:
Right. Even the generated native headers from jobjc are saved into its
own directory.
Thank you for your
Hi David,
Thanks for your review. When I tested it in JPRT run, I added -boot
jdk1.8.0 to use jdk8 as the boot jdk. I did not realize that being able
to build with jdk7 is a requirement. I will push the fix now. Thanks!
-Dan
On 04/05/2013 04:51 PM, David Holmes wrote:
Dan,
Looks okay to
Changeset: 785f3a04ee05
Author:dxu
Date: 2013-04-05 17:15 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/785f3a04ee05
8011602: jobjc build failure on Mac
Summary: Remove @Native annotation from
macosx/native/jobjc/src/core/java/com/apple/jobjc/Coder.java
Reviewed-by:
Changeset: 16f63a94c231
Author:darcy
Date: 2013-04-05 18:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16f63a94c231
8011590: More tests for core reflection modeling of default methods
Reviewed-by: mduigou
+ test/java/lang/reflect/Method/DefaultMethodModeling.java
25 matches
Mail list logo
