Mandy,
first I would like to have the given patch applied to OpenJDK 8 (+ JDK7u)
as it fixes many problems:
- string concatenations
- object creations (Object[] or other objects given as params)
- method calls in log statements
In a second step, I can help somebody migrating JUL usages to
As far as I can tell, there are three different styles being used for
public modifiers in interfaces now:
1) no use of public
2) use of public only on default methods
3) use of pubilc on default and abstract methods
(I can't recall seeing any static methods on interfaces outside of JSR-310 yet)
On 08/04/2013 20:51, Xueming Shen wrote:
Hi,
JSR 310 has continued to refine and update the java.time API.
Please help review the proposed changeset as showed in webrev:
http://cr.openjdk.java.net/~sherman/8011172/webrev/
I skimmed through the changes (not a detailed review, there's way too
Stephen,
On 9/04/2013 7:53 PM, Stephen Colebourne wrote:
As far as I can tell, there are three different styles being used for
public modifiers in interfaces now:
1) no use of public
2) use of public only on default methods
3) use of pubilc on default and abstract methods
(I can't recall
I find it troubling the tzdb.jar is now tzdb.dat - either it is a jar
file or not; if not then it should not be built using CreateJars.gmk and
shouldn't listed on the JAR variables in profile-includes.txt
David
On 9/04/2013 5:51 AM, Xueming Shen wrote:
Hi,
JSR 310 has continued to refine
While I disagree with the choice made (one of Java's strengths is a
little bit of extra verbosity), I am happy if it is consistent. Based
on the links I provided, clearly Project Lambda has a long way to go
to meet that consistency, so it clearly hasn't been a firm
recommendation up until now.
Dear Java2D members,
Could someone review the following webrev concerning Java2D Pisces to
enhance its performance and reduce its memory footprint (RendererContext
stored in thread local or concurrent queue):
http://jmmc.fr/~bourgesl/share/java2d-pisces/webrev-1/
FYI I fixed file headers in this
Hi Laurent,
Thanks for all your hard work! The fix looks fine to me.
I'm also CC'ing jdk8-dev@ to let other teams review the changes in their
areas. I've only reviewed the AWT part of the fix.
--
best regards,
Anthony
On 4/8/2013 15:32, Laurent Bourgès wrote:
Anthony,
here is an updated
Changeset: af6fc67aa73d
Author:jlaskey
Date: 2013-04-02 11:37 -0300
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/af6fc67aa73d
8011233: Create a Nashorn shell for JavaFX
Reviewed-by: lagergren, sundar
Contributed-by: james.las...@oracle.com
! make/build.xml
!
Hi,
This is a request to review adding a netbeans freeform project to
jdk/make/netbeans for jdbc
As part of this change, I also modified common/shared.xml to properly look for
the jtreg report.html in the html directory and so the javadoc was using
version 1.8
The web rev is here
On 4/9/13 5:00 AM, David Holmes wrote:
I find it troubling the tzdb.jar is now tzdb.dat - either it is a jar
file or not; if not then it should not be built using CreateJars.gmk
and shouldn't listed on the JAR variables in profile-includes.txt
tzdb.dat now is NOT a jar file for performance
Hi,
there is a little indentation error in build.xml in line 42.
-Ulf
Am 09.04.2013 16:55, schrieb Lance Andersen - Oracle:
Hi,
This is a request to review adding a netbeans freeform project to
jdk/make/netbeans for jdbc
As part of this change, I also modified common/shared.xml to
Thank you ulf, I made the change in my workspace so that it will be
accommodated as part of the putback
Best
Lance
On Apr 9, 2013, at 11:26 AM, Ulf Zibis wrote:
Hi,
there is a little indentation error in build.xml in line 42.
-Ulf
Am 09.04.2013 16:55, schrieb Lance Andersen - Oracle:
On Mon, Apr 8, 2013 at 6:54 PM, Steven Schlansker
stevenschlans...@gmail.com wrote:
Today I encountered java.lang.IllegalArgumentException: Self-suppression
not permitted from Throwable.addSuppressed.
My first surprise is that the try-with-resources block can throw this
exception; it is
Changeset: 50bc8e085a09
Author:chegar
Date: 2013-04-09 17:27 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50bc8e085a09
8005696: Add CompletableFuture
Reviewed-by: chegar, martin
! make/java/java/FILES_java.gmk
+
On Apr 9, 2013, at 9:30 AM, Zhong Yu zhong.j...@gmail.com wrote:
On Mon, Apr 8, 2013 at 6:54 PM, Steven Schlansker
stevenschlans...@gmail.com wrote:
Today I encountered java.lang.IllegalArgumentException: Self-suppression not
permitted from Throwable.addSuppressed.
My first
Hi Laurent,
Quick questions - which benchmarks were run before/after? I see a lot of
benchmark running in your Pisces improvement thread, but but none here.
Also, this should be tested on multiple platforms, preferably Linux, Windows
and Mac to see how it is affected by differences in the
Dear Jim,
I advocated I only looked at the netbeans memory profiler's output: no more
megabytes allocated !
The main question is: how to know how GC / hotspot deals with such small
allocations ? Is there any JVM flag to enable to see real allocations as
does jmap -histo.
Quick questions -
Hi Laurent,
The allocations will always show up on a heap profiler, I don't know of any way
of having them not show up if they are stack allocated, but I don't think that
stack allocation is the issue here - small allocations come out of a fast
generation that costs almost nothing to allocate
On 4/9/13 12:37 AM, Laurent Bourgès wrote:
Mandy,
first I would like to have the given patch applied to OpenJDK 8 (+
JDK7u) as it fixes many problems:
- string concatenations
- object creations (Object[] or other objects given as params)
- method calls in log statements
This is the patch
Hello,
Please review my changes for
8011800: Add java.util.Objects.requireNonNull(T, SupplierString)
http://cr.openjdk.java.net/~darcy/8011800.0/
which add a new method to java.util.Objects to take a SupplierString
rather than a String.
Patch inline below.
Thanks,
-Joe
---
Changeset: eb134c8e931d
Author:bpatel
Date: 2013-04-09 14:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eb134c8e931d
8005091: javadoc should be able to return the receiver type
Reviewed-by: jjg
! src/share/classes/com/sun/javadoc/ExecutableMemberDoc.java
!
Any further comment on these?
Technically they are adequately reviewed as I have reviewed them and am
submitting them on behalf of Brian Goetz. I would prefer to know that at least
one other set of eyes has looked at them though.
Mike
On Apr 3 2013, at 17:00 , Mike Duigou wrote:
Hello all;
If obj is null and the supplier is also null, you will not get an NPE with
the expected message. Since it's kind of odd to get an NPE constructing an
NPE, I think:
@throws NullPointerException if {@code obj} is {@code null}
should be changed to:
@throws NullPointerException if {@code obj} or
Mike,
It would be nice if the class javadocs would have @see tags to classes in
the same family. For example, DoubleToIntFunction could have a @see to
DoubleToLongFunction, etc. This way a developer viewing of one class can
easily figure out which close cousins exist.
Paul
On 9/04/2013 10:28 PM, Stephen Colebourne wrote:
While I disagree with the choice made (one of Java's strengths is a
little bit of extra verbosity), I am happy if it is consistent. Based
on the links I provided, clearly Project Lambda has a long way to go
to meet that consistency, so it clearly
On Apr 8 2013, at 16:03 , Martin Buchholz wrote:
Style: spaces around =
+private static final int DEFAULT_CAPACITY= 10;
I apologize for these minor style problems in this and my other patches. I am
really loathe to run any kind of automated source reformatting tool on JDK
source.
Hi Sherman,
On 10/04/2013 1:08 AM, Xueming Shen wrote:
On 4/9/13 5:00 AM, David Holmes wrote:
I find it troubling the tzdb.jar is now tzdb.dat - either it is a jar
file or not; if not then it should not be built using CreateJars.gmk
and shouldn't listed on the JAR variables in
On Apr 8 2013, at 05:52 , Alan Bateman wrote:
I think this is the webrev:
http://cr.openjdk.java.net/~mduigou/JDK-8011200/2/webrev/
It's impossible to predict what the usage will be after you reconstitute.
I agree completely. We should have a consistent policy for both deserialization
Are we convinced that the capture cost of the lambdas likely to be used as
suppliers is generally (*) better than the string construction that using a
Supplier would avoid?
(*) I say generally because I am certain examples could be found in which
either is clearly better.
Mike
On Apr 9
Hello all;
Another update to the webrev incorporating feedback from Alan and Martin.
http://cr.openjdk.java.net/~mduigou/JDK-8011200/3/webrev/
- The key change in this revision is that the capacity of both cloned() and
deserialized instances is determined by the number of entries NOT the
On 04/09/2013 06:00 PM, Mike Duigou wrote:
Are we convinced that the capture cost of the lambdas likely to be used as
suppliers is generally (*) better than the string construction that using a
Supplier would avoid?
(*) I say generally because I am certain examples could be found in which
Hi Joe,
On 10/04/2013 7:12 AM, Joe Darcy wrote:
Hello,
Please review my changes for
8011800: Add java.util.Objects.requireNonNull(T, SupplierString)
http://cr.openjdk.java.net/~darcy/8011800.0/
which add a new method to java.util.Objects to take a SupplierString
rather than a
On 10/04/2013 9:07 AM, Mike Duigou wrote:
Any further comment on these?
Technically they are adequately reviewed as I have reviewed them and am
submitting them on behalf of Brian Goetz. I would prefer to know that at least
one other set of eyes has looked at them though.
I looked - no
Mike, thanks.
I don't see anything wrong in this version, although the ongoing
complexification and special-case-ification (with attendant risk of bugs)
of ArrayList and HashMap, the two most didactically important classes,
continue to bother me. This change continues to feel marginal. Anyways,
35 matches
Mail list logo
