Hi,
I get the following compile-time error:
/home/peter/work/hg/jdk8-tl/langtools/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java:264:
error: illegal start of expression
if (qualifiedName == null) }
^
...isn't this '}' supposed to be '{'
On 19/04/2013 08:08, Peter Levart wrote:
Hi,
I get the following compile-time error:
/home/peter/work/hg/jdk8-tl/langtools/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java:264:
error: illegal start of expression
if (qualifiedName == null) }
I'm seeing the same thing, looks
Hi
On 04/19/2013 09:30 AM, Alan Bateman wrote: On 19/04/2013 08:08, Peter
Levart wrote:
Hi,
I get the following compile-time error:
/home/peter/work/hg/jdk8-tl/langtools/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java:264:
error: illegal start of expression
if
Looks good to me Joel,
-Chris.
On 19/04/2013 09:49, Joel Borggrén-Franck wrote:
Hi
On 04/19/2013 09:30 AM, Alan Bateman wrote: On 19/04/2013 08:08, Peter
Levart wrote:
Hi,
I get the following compile-time error:
On Apr 19, 2013, at 6:52 AM, Mike Duigou mike.dui...@oracle.com wrote:
I reversed this change :
-final Collection? extends E c;
-
+final CollectionE c;
in Collections.UnmodifiableCollection instead opting or casts in the forEach
and spliterator Methods.
OK, i prefer the
Changeset: 90b03f9a2e77
Author:jzavgren
Date: 2013-04-17 11:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90b03f9a2e77
8010505: HTTP DIGEST implementation incorrectly quotes header values, fails auth
Summary: The extraneous quotes were removed.
Reviewed-by: chegar
!
Changeset: a3655c24e232
Author:jfranck
Date: 2013-04-19 11:57 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a3655c24e232
8012681: Commit for JDK-8012656 breaks tl build
Reviewed-by: vromero, chegar, alanb
! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java
Fix pushed, thanks for the reviews.
Peter, I missed your patch. My fix should probably have been attributed to
you, sorry!
cheers
/Joel
On 04/19/2013 10:49 AM, Joel Borggrén-Franck wrote:
Hi
On 04/19/2013 09:30 AM, Alan Bateman wrote: On 19/04/2013 08:08, Peter
Levart wrote:
Hi,
I
On 18/04/2013 16:12, Mike Duigou wrote:
:
@implSpec is very welcome, more reasons now with the addition of default
methods.
Clearly distinguishing normative from non-normative text is also been a long standing
problem so having a tag to identify the non-normative text is very useful. I had
On 18/04/2013 19:49, Akhil Arora wrote:
Looks like the stars are aligning on getting on this into TL... the
refreshed webrev is -
http://cr.openjdk.java.net/~akhil/8001647.8/webrev/
A minor comment on Collection.removeIf is that satisifies the given
predicate might be better than which
On Apr 19, 2013, at 1:15 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 18/04/2013 19:49, Akhil Arora wrote:
Looks like the stars are aligning on getting on this into TL... the
refreshed webrev is -
http://cr.openjdk.java.net/~akhil/8001647.8/webrev/
A minor comment on
Hi Akhil,
This is only a partial review so far.
I have some issues with the ConcurrentModificationException strategy.
Taking ArrayList, the basic idea is that you want to detect
modifications that are concurrent with iteration - so the mutators up
the modCount and the iterator functions
On 19/04/2013 13:14, Paul Sandoz wrote:
:
The function value could structurally modify the Vector instance.
Ah yes, got it - thanks.
For removeIf then I assume it isn't required in the pass over the removeSet.
-Alan.
On 19/04/2013 10:14 PM, Paul Sandoz wrote:
On Apr 19, 2013, at 1:15 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 18/04/2013 19:49, Akhil Arora wrote:
Looks like the stars are aligning on getting on this into TL... the
refreshed webrev is -
On Apr 19, 2013, at 2:29 PM, David Holmes david.hol...@oracle.com wrote:
Hi Akhil,
This is only a partial review so far.
I have some issues with the ConcurrentModificationException strategy.
Taking ArrayList, the basic idea is that you want to detect
modifications that are concurrent
Hi Mandy,
On 04/19/2013 07:33 AM, Mandy Chung wrote:
https://dl.dropboxusercontent.com/u/101777488/jdk8-tl/proxy-wc/webrev.02/index.html
What about package-private in java.lang.reflect? It makes Proxy
itself much easier to read. When we decide which way to go, I can
remove the interface
Changeset: fad6560cb32a
Author:dfuchs
Date: 2013-04-17 15:23 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/fad6560cb32a
8005954: JAXP Plugability Layer should use java.util.ServiceLoader
Summary: This fix replaces manual processing of files under META-INF/services
in JAXP
On Apr 19, 2013, at 2:42 PM, David Holmes david.hol...@oracle.com wrote:
On 19/04/2013 10:14 PM, Paul Sandoz wrote:
On Apr 19, 2013, at 1:15 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 18/04/2013 19:49, Akhil Arora wrote:
Looks like the stars are aligning on getting on this into
On Apr 19 2013, at 03:40 , Alan Bateman wrote:
On 18/04/2013 16:12, Mike Duigou wrote:
:
@implSpec is very welcome, more reasons now with the addition of default
methods.
Clearly distinguishing normative from non-normative text is also been a
long standing problem so having a tag to
On 19/04/2013 16:13, Mike Duigou wrote:
:
Not as currently used, no. The @implSpec is being used to describe required
behaviour of the implementation, usually defaults. ie. Conforming defaults
implementations must throw ISE (or UOE, etc.).
Sorry, I meant @implNote where it may not always be
On Apr 19 2013, at 08:15 , Alan Bateman wrote:
On 19/04/2013 16:13, Mike Duigou wrote:
:
Not as currently used, no. The @implSpec is being used to describe required
behaviour of the implementation, usually defaults. ie. Conforming defaults
implementations must throw ISE (or UOE, etc.).
On 04/19/2013 04:36 PM, Peter Levart wrote:
http://dl.dropboxusercontent.com/u/101777488/jdk8-tl/proxy-wc-wi/webrev.01/index.html
Hi Mandy,
I changed the copyright header of WeakCache to GPLv2 with ClassPath
exception and corrected a minor formatting inconsistency:
Hi Mandy,
I just noticed the following (have been thinking of it already, but then
forgot) in original code:
/*
512 * Note that we need not worry about reaping the cache for
513 * entries with cleared weak references because if a proxy
class
514 *
I would like to request for a review of code changes made to support
lambda related modifications to allow static and invokespecial calls to
interface methods per spec version 0.6.2
(http://cr.openjdk.java.net/~dlsmith/jsr335-0.6.2.html). These changes
support an upcoming change that compiles
Hi Henry, Can you please comment on the simplifications you did ?
Thanks,
Jim
On 04/18/2013 07:38 PM, Ulf Zibis wrote:
Am 18.04.2013 19:37, schrieb Jim Gish:
On 04/18/2013 08:49 AM, Ulf Zibis wrote:
Hi,
I'm wondering, that StringJoiner has some logic for pre/suffix, but
nothing to
Hi,
We have been asked by a few JDBC driver vendors to allow a JDBC driver to be
notified when/if it was deregistered via DriverManager.deregisterDriver if
desired.
The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/webrev.01
Best
Lance
Lance Andersen| Principal
Also, this is with the Java version, right?
Yes, my patch is pure java given as webrev:
http://jmmc.fr/~bourgesl/share/java2d-pisces/webrev-1/
We got a decent 2x speedup in FX by porting the version of Open Pisces that
you started with to C code (all except on Linux where we
On Mon, Apr 15, 2013 at 7:30 PM, Mike Duigou mike.dui...@oracle.com wrote:
Another integration review in the JSR-335 libraries series. These three
classes provide a utility for conveniently finding count, sum, min, max
and average of ints, longs or doubles. They can be used with existing code
On Tue, Apr 9, 2013 at 3:02 PM, Laurent Bourgès
bourges.laur...@gmail.comwrote:
Dear Java2D members,
Could someone review the following webrev concerning Java2D Pisces to
enhance its performance and reduce its memory footprint (RendererContext
stored in thread local or concurrent queue):
Changeset: 414384c3b3eb
Author:yhuang
Date: 2013-04-16 22:28 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/414384c3b3eb
8011977: ISO 4217 Amendment Number 155
Reviewed-by: naoto
! src/share/classes/java/util/CurrencyData.properties
! test/java/util/Currency/tablea1.txt
Martin,
I've updated the toString() method as you suggested.
http://cr.openjdk.java.net/~jgish/Bugs-5015163-7172553/
http://cr.openjdk.java.net/%7Ejgish/Bugs-5015163-7172553/
Thanks,
Jim
On 04/18/2013 05:02 PM, Martin Buchholz wrote:
On Thu, Apr 18, 2013 at 10:34 AM, Jim Gish
Changeset: 1c2079d11a79
Author:dfuchs
Date: 2013-04-19 17:22 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1c2079d11a79
8010495: Update JAXP NetBeans project - add support for generating javadoc
Summary: Make it possible to use NetBeans to edit the jaxp sources and to
Changeset: 6139f8fb0137
Author:mduigou
Date: 2013-04-16 22:50 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6139f8fb0137
8008670: Initial java.util.stream putback -- internal API classes
Reviewed-by: mduigou, dholmes
Contributed-by: Brian Goetz brian.go...@oracle.com, Doug
Hi Mandy,
I've incorporated your changes, run JPRT, and posted an updated webrev:
http://cr.openjdk.java.net/~jgish/Bug8010939-LogManager-Deadlock.1/
http://cr.openjdk.java.net/%7Ejgish/Bug8010939-LogManager-Deadlock.1/
Thanks,
Jim
On 04/12/2013 06:51 PM, Mandy Chung wrote:
Hi Jim,
Please review the addition of optimized defaults for Iterator's
forEachRemaining to ArrayList, LinkedList, Vector and
CopyOnWriteArrayList. The unit test has a performance comparison test
(disabled by default) that measures the difference between this method
and hasNext()/next(). Significant
Updated with feedback so far -
http://cr.openjdk.java.net/~akhil/8001647.9/webrev/
On 04/18/2013 11:49 AM, Akhil Arora wrote:
Looks like the stars are aligning on getting on this into TL... the
refreshed webrev is -
http://cr.openjdk.java.net/~akhil/8001647.8/webrev/
Please review
Thanks
On 04/19/2013 05:42 AM, David Holmes wrote:
On 19/04/2013 10:14 PM, Paul Sandoz wrote:
On Apr 19, 2013, at 1:15 PM, Alan Bateman alan.bate...@oracle.com
wrote:
On 18/04/2013 19:49, Akhil Arora wrote:
Looks like the stars are aligning on getting on this into TL... the
refreshed webrev is -
37 matches
Mail list logo
