Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Remi Forax
On 06/14/2013 01:27 AM, Mike Duigou wrote: On Jun 13 2013, at 14:56 , Remi Forax wrote: On 06/13/2013 04:47 PM, Paul Sandoz wrote: On Jun 13, 2013, at 4:06 PM, Remi Forax fo...@univ-mlv.fr wrote: There is a difference between an Iterator/forEach and a spliterator/stream, with a stream you

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Paul Sandoz
On Jun 13, 2013, at 11:56 PM, Remi Forax fo...@univ-mlv.fr wrote: On 06/13/2013 04:47 PM, Paul Sandoz wrote: On Jun 13, 2013, at 4:06 PM, Remi Forax fo...@univ-mlv.fr wrote: There is a difference between an Iterator/forEach and a spliterator/stream, with a stream you know that the called

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Remi Forax
On 06/14/2013 11:20 AM, Paul Sandoz wrote: On Jun 13, 2013, at 11:56 PM, Remi Forax fo...@univ-mlv.fr wrote: On 06/13/2013 04:47 PM, Paul Sandoz wrote: On Jun 13, 2013, at 4:06 PM, Remi Forax fo...@univ-mlv.fr wrote: There is a difference between an Iterator/forEach and a spliterator/stream,

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Paul Sandoz
On Jun 14, 2013, at 12:12 PM, Remi Forax fo...@univ-mlv.fr wrote: The following does not throw CME: ListInteger l = new ArrayList(Arrays.asList(1, 2)); for (Integer i : l) { l.remove(1); // 2 is never encountered } Where as the

RFR 8012987: Optimizations for Stream.limit/substream

2013-06-14 Thread Paul Sandoz
Hi, This patch implements optimizations for the limit/substream operations when input to those operations have certain properties (corresponding to known size or unordered) which helps to avoid out of memory issues (not all, we still have some more work to do). The {Xxx}/Stream.generate

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Remi Forax
On 06/14/2013 12:55 PM, Paul Sandoz wrote: On Jun 14, 2013, at 12:12 PM, Remi Forax fo...@univ-mlv.fr wrote: The following does not throw CME: ListInteger l = new ArrayList(Arrays.asList(1, 2)); for (Integer i : l) { l.remove(1); // 2 is never

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Paul Sandoz
On Jun 14, 2013, at 2:41 PM, Remi Forax fo...@univ-mlv.fr wrote: It would be a shame for overriding forEach/forEachRemaining implementations to conform to such behaviour when they can implement stronger/consistent failure guarantees. While I could agree with you in theory, in practice I

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread David Chase
On 2013-06-14, at 8:41 AM, Remi Forax fo...@univ-mlv.fr wrote: In the codes I was referring to, there was always a way to know that the remove was done at the end by example by knowing that the last element was a special sentinel or by using a counter. So is the following program bugged ?

hg: jdk8/tl/jaxp: 8015978: Incorrect transformation of XPath expression string(-0)

2013-06-14 Thread sean . coffey
Changeset: 659828443145 Author:coffeys Date: 2013-06-14 15:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 8015978: Incorrect transformation of XPath expression string(-0) Reviewed-by: darcy, joehw Contributed-by: aleksej.efi...@oracle.com !

hg: jdk8/tl/jdk: 8015978: Incorrect transformation of XPath expression string(-0)

2013-06-14 Thread sean . coffey
Changeset: 45a3584bfacf Author:coffeys Date: 2013-06-14 15:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45a3584bfacf 8015978: Incorrect transformation of XPath expression string(-0) Reviewed-by: darcy, joehw Contributed-by: aleksej.efi...@oracle.com +

RFR 623 build warnings [deprecation] isLoggable(int) in PlatformLogger

2013-06-14 Thread Chris Hegarty
There are 623 occurrences, and hence 623 deprecated build warnings, of PlatformLogger.isLoggable(int) in the jdk source. PlatformLogger is an internal API, and used in may places in the jdk. isLoggable(int) has been deprecated in favor of isLoggable(Level). isLoggable(Level) is slightly more

hg: jdk8/tl/langtools: 8016569: javac, add new flag for polymorphic method signatures

2013-06-14 Thread vicente . romero
Changeset: 6b48ebae2569 Author:vromero Date: 2013-06-14 16:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b48ebae2569 8016569: javac, add new flag for polymorphic method signatures Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com !

hg: jdk8/tl/jdk: 8014307: Memory leak ... security/jgss/wrapper/GSSLibStub.c

2013-06-14 Thread sean . mullan
Changeset: f695f447f6b7 Author:jzavgren Date: 2013-06-14 09:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f695f447f6b7 8014307: Memory leak ... security/jgss/wrapper/GSSLibStub.c Summary: I modified the native procedure:

Re: RFR 623 build warnings [deprecation] isLoggable(int) in PlatformLogger

2013-06-14 Thread Joe Darcy
Looks fine Chris; thanks, -Joe On 6/14/2013 8:00 AM, Chris Hegarty wrote: There are 623 occurrences, and hence 623 deprecated build warnings, of PlatformLogger.isLoggable(int) in the jdk source. PlatformLogger is an internal API, and used in may places in the jdk. isLoggable(int) has been

hg: jdk8/tl/langtools: 8008023: Get rid of utf8 chars in two tests

2013-06-14 Thread vicente . romero
Changeset: 1936a884b290 Author:vromero Date: 2013-06-14 18:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1936a884b290 8008023: Get rid of utf8 chars in two tests Reviewed-by: jjg ! test/tools/javac/api/6437999/Utf8.java ! test/tools/javac/api/T6306137.java

RE: RFR 8009736: Comparator API cleanup

2013-06-14 Thread Jason Mehrens
Any chance the static method Comparator.reverseOrder() will be renamed to something like reversedNaturalOrder? Now all of the calls to Comparator.reverseOrder() take on new meaning. Jason Date: Tue, 11 Jun 2013 14:04:38 -0700 From: henry@oracle.com To: lambda-...@openjdk.java.net;

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Mike Duigou
On Jun 13 2013, at 06:21 , Remi Forax wrote: On 06/13/2013 07:28 AM, Mike Duigou wrote: I have updated my webrev with Remi's improvements and some other improvements to the fast-fail concurrent modification checking. Revised webrev:

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Mike Duigou
On Jun 14 2013, at 05:41 , Remi Forax wrote: On 06/14/2013 12:55 PM, Paul Sandoz wrote: On Jun 14, 2013, at 12:12 PM, Remi Forax fo...@univ-mlv.fr wrote: The following does not throw CME: ListInteger l = new ArrayList(Arrays.asList(1, 2)); for (Integer i : l) {

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Mike Duigou
I have updated the webrev again. In addition to moving the modification checks to be consistently after the operation for the most complete fast-fail behaviour I've also slightly enhanced the Map default to detect ISE thrown by setValue as a CME condition.

Code Review Request: 8016698: Cleanup overrides warning in sun/tools/ClassDeclaration.java

2013-06-14 Thread Kurchi Hazra
Hi, This is to elimnate the overrides warning from ClassDeclaration.java. This class is used by rmi, but sun/tools/java and sun/tools/javac also heavily uses it, let me know if anyone else should also be reviewing it. Bug: http://bugs.sun.com/view_bug.do?bug_id=8016698 [To appear] Webrev:

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Remi Forax
On 06/14/2013 09:45 PM, Mike Duigou wrote: On Jun 14 2013, at 05:41 , Remi Forax wrote: On 06/14/2013 12:55 PM, Paul Sandoz wrote: On Jun 14, 2013, at 12:12 PM, Remi Forax fo...@univ-mlv.fr wrote: The following does not throw CME: ListInteger l = new ArrayList(Arrays.asList(1,

Re: RFR : 7129185 : (M) Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set}

2013-06-14 Thread Mike Duigou
Hi Martin; Thanks, as always, for the feedback! Louis Wasserman's question about existing methods delegating to newer methods and discussions regarding the serialization impacts with Stuart Marks lead me to reconsider the approach used in revision 3. For revision 4 I've replaced most of

Re: RFR : 8016446 : (m) Add override forEach/replaceAll to HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap

2013-06-14 Thread Remi Forax
On 06/14/2013 11:57 PM, Mike Duigou wrote: I have updated the webrev again. In addition to moving the modification checks to be consistently after the operation for the most complete fast-fail behaviour I've also slightly enhanced the Map default to detect ISE thrown by setValue as a CME

8016701: JAXP Build failure

2013-06-14 Thread Rob McKenna
Hi folks, As per the bug: JAXP must be buildable using JDK7 as the bootdir. Unfortunately http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a method that only exists in 8. (Double.isFinite()) This element of the changeset needs to be reverted.

Re: 8016701: JAXP Build failure

2013-06-14 Thread Joe Darcy
Looks fine Rob; approved. -Joe On 6/14/2013 5:28 PM, Rob McKenna wrote: Hi folks, As per the bug: JAXP must be buildable using JDK7 as the bootdir. Unfortunately http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a method that only exists in 8. (Double.isFinite()) This

Re: 8016701: JAXP Build failure

2013-06-14 Thread Brad Wetmore
Approved. Brad On 6/14/2013 5:31 PM, Joe Darcy wrote: Looks fine Rob; approved. -Joe On 6/14/2013 5:28 PM, Rob McKenna wrote: Hi folks, As per the bug: JAXP must be buildable using JDK7 as the bootdir. Unfortunately http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a method