Re: Error in Javadoc for DatabaseMetaData

2013-06-30 Thread Alan Bateman
On 30/06/2013 22:26, Nick Williams wrote: In java.sql.DatabaseMetaData, the Javadoc for supportsResultSetHoldability fails to properly close a tag, and so everything following that method is monospace. To be precise: ResultSet.CLOSE_CURSORS_AT_COMMIT However, it should be: ResultSet.CLOSE_C

Re: RFR (XS): 8014890 : Reference queues may return more entries than expected

2013-06-30 Thread David Holmes
Hi Thomas, Sorry for the delay in looking into this deeper but I've been OOTO a bit this past week. I'm backing up to the start to explore the apparent problem ... On 19/06/2013 7:08 AM, Thomas Schatzl wrote: Hi all, can I have reviews for the following change? It happens if multiple th

hg: jdk8/tl/jdk: 8019467: Fix doclint issues in java.util.jar.Pack200

2013-06-30 Thread joe . darcy
Changeset: 9eaeb1a0aa46 Author:darcy Date: 2013-06-30 17:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9eaeb1a0aa46 8019467: Fix doclint issues in java.util.jar.Pack200 Reviewed-by: lancea, ksrini ! src/share/classes/java/util/jar/Pack200.java

Re: JDK 8 code review request for doclint fixes in java.util.jar.Pack200

2013-06-30 Thread Joe Darcy
Hi Kumar, On 06/30/2013 04:45 PM, Kumar Srinivasan wrote: Hi Joe, The changes looks good, thanks for doing this!. I should've peeked at the generated reports. :-[ The changes look fine according to specdiff too. But, there are 2 more errors j.u.j.Attributes.java and some missing @throws fo

Re: JDK 8 code review request for doclint fixes in java.util.jar.Pack200

2013-06-30 Thread Kumar Srinivasan
Hi Joe, The changes looks good, thanks for doing this!. I should've peeked at the generated reports. :-[ But, there are 2 more errors j.u.j.Attributes.java and some missing @throws for j.u.j.JarEntry.java, are you planning on doing this separately ? Thanks Kumar Hello, Pack200 has some doc

Re: JDK 8 code review request for doclint fixes in java.util.jar.Pack200

2013-06-30 Thread Lance Andersen - Oracle
looks good Joe On Jun 30, 2013, at 7:20 PM, Joe Darcy wrote: > Hello, > > Pack200 has some doclint issues; please review the fixes to them below. > > Thanks, > > -Joe > > --- a/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:02:11 > 2013 -0700 > +++ b/src/share/classes/java/util

JDK 8 code review request for doclint fixes in java.util.jar.Pack200

2013-06-30 Thread Joe Darcy
Hello, Pack200 has some doclint issues; please review the fixes to them below. Thanks, -Joe --- a/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:02:11 2013 -0700 +++ b/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:19:25 2013 -0700 @@ -1,5 +1,5 @@ /* - * Copyr

Code update for 8014319: Faster division of large integers

2013-06-30 Thread Tim Buktu
Hi, I made a few changes to the BigInteger code in my GitHub repo: * Moved Burnikel-Ziegler division to MutableBigInteger * Added more comments to the Burnikel-Ziegler code * Updated Barrett thresholds * Merged BigInteger.java and BigIntegerTest.java with the latest from hg The files at the l

hg: jdk8/tl/jdk: 8019466: Fix doclint issues in java.util.function

2013-06-30 Thread joe . darcy
Changeset: bf650fee4983 Author:darcy Date: 2013-06-30 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf650fee4983 8019466: Fix doclint issues in java.util.function Reviewed-by: briangoetz ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/ja

Error in Javadoc for DatabaseMetaData

2013-06-30 Thread Nick Williams
In java.sql.DatabaseMetaData, the Javadoc for supportsResultSetHoldability fails to properly close a tag, and so everything following that method is monospace. To be precise: ResultSet.CLOSE_CURSORS_AT_COMMIT However, it should be: ResultSet.CLOSE_CURSORS_AT_COMMIT Nick