Hi Joe,
This looks reasonable.
Out of curiosity - could it be that it was fSAXParser that was null,
and not fSecurityPropertyMgr?
JAXPSAXParser has a no arg public constructor that could have lead to
that...
I have only one remark:
It looks as if fSecurityPropertyMgr could be declared
Joe,
I can see in SAXParserImpl constructor, setFeature0 could throw, leaving
the fSecurityPropertyMgr uninitialized. There my be other code paths too.
I agree with this change, and Daniel's comments to make both
fSecurityPropertyMgr fields final. Consider it reviewed ( at least on my
side
On Jul 11, 2013, at 12:51 PM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
Doug's explanation provides an excellent hook to hang the RFR off:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8020291-completion-stage/specdiff/overview-summary.html
Agree with the change and making fSecurityPropertyMgr final
Best
Lance
On Jul 24, 2013, at 5:04 AM, chris Hegarty wrote:
Joe,
I can see in SAXParserImpl constructor, setFeature0 could throw, leaving the
fSecurityPropertyMgr uninitialized. There my be other code paths too.
I agree with
Hi Paul, Doug,
I am happy to be considered as a reviewer for this change. I think the
separation of policies and execution mechanisms from the fluent
completion-style capabilities is nice.
Some minor comments/questions:
1) Should CS.toCompletableFuture declare UnsupportedOperationException
I've just created JDK-8021257 to track this. Yes - the ORB.init issue
can be corrected easily but more issues fall out from that. One example
: [1]. All calling sites into creation of com.sun.corba.se.impl classes
need to be examined.
regards,
Sean.
[1]
java.lang.NoClassDefFoundError: Could
On 23/07/2013 11:08 PM, Daniel Fuchs wrote:
Hi,
Please find below a changeset for fixing
8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is
failing intermittently [1]
This appears to be a test bug due to a bizarre use of synchronization
in the test. The test was failing
On Jul 24, 2013, at 12:04 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Hi Paul, Doug,
I am happy to be considered as a reviewer for this change.
Thanks!
I think the separation of policies and execution mechanisms from the fluent
completion-style capabilities is nice.
Some minor
Hi David,
On 7/24/13 1:48 PM, David Holmes wrote:
On 23/07/2013 11:08 PM, Daniel Fuchs wrote:
Hi,
Please find below a changeset for fixing
8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is
failing intermittently [1]
This appears to be a test bug due to a bizarre use of
On 24/07/2013 06:24, Chris Hegarty wrote:
I'm planning this months update to the ProblemList.txt.
Anyone got anything else they would like to add, under this bug
number? Otherwise, I'll push the two changes I have below.
8008200: has been fixed
8020435: will be fixed soon. We can remove
Changeset: 187a1f2613c0
Author:sjiang
Date: 2013-07-24 15:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/187a1f2613c0
8016221: A unit test should not use a fix port to run a jmx connector
Reviewed-by: jbachorik, dfuchs
!
Thanks for the review Alan ;-)
I would also like to add:
+ # 8021186
+ jdk/lambda/vm/DefaultMethodsTest.java generic-all
... until 8021186 can be addressed.
-Chris.
On 24/07/2013 14:48, Alan Bateman wrote:
On 24/07/2013 06:24, Chris Hegarty wrote:
I'm planning this months update to
On 24/07/13 15:56, Chris Hegarty wrote:
Thanks for the review Alan ;-)
I would also like to add:
+ # 8021186
+ jdk/lambda/vm/DefaultMethodsTest.java generic-all
... until 8021186 can be addressed.
Thanks for taking care of this!
Maurizio
-Chris.
On 24/07/2013 14:48, Alan Bateman
On 07/24/13 08:37, Paul Sandoz wrote:
On Jul 24, 2013, at 12:04 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Hi Paul, Doug,
I am happy to be considered as a reviewer for this change.
Thanks!
Thanks to you both!
I think the separation of policies and execution mechanisms from
Thanks Doug, I see the updates in you CVS. Paul, or I, can sync these
before pushing this.
On 24/07/2013 16:25, Doug Lea wrote:
Thanks also to Chris for pointing out that CompletableFuture
did not have arrangements in place for asyncs when users run with
system property
On 16/07/2013 12:05, Henry Jen wrote:
Hi,
Please review the webrev at,
http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/
The test is mostly contributed by Ben Evans.
Cheers,
Henry
It looks okay to me, just a concern that the tests for the regex API are
normally in
On Jul 24, 2013, at 5:14 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 16/07/2013 12:05, Henry Jen wrote:
Hi,
Please review the webrev at,
http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/
The test is mostly contributed by Ben Evans.
Cheers,
Henry
It looks okay to
On 10/07/2013 12:01, Omair Majid wrote:
On 07/09/2013 03:40 AM, Erik Joelsson wrote:
I would like to see a comment explaining why the option was needed. Is
this a bug in gcc or has the checking just become better?
-Werror is not a great default. It means all warnings are errors. The
set of
Hi,
I'm curious if there was a conclusion on this one. I assume SCTP_WERROR was
originally intended for building libsctp (not libnio) so it would be
strange to add to SCTP_WERROR to disable -Werror for issues coming from the
file system code. One other thing that isn't clear is why there aren't
Ok first feedback
configure: error: Could not find a C++ compiler. You might be able to fix
this by running 'sudo yum groupinstall Development Tools'.
I did this but the error continue.
Going to investigate a workaround.
Regards,
Helio
2013/7/24 Helio Frota heliofr...@gmail.com
Hi,
I'm
Hi,
Please need to add the message on the autoconf config scripts:
You might be able to fix this by running 'sudo yum install gcc-c++'.
because 'sudo yum groupinstall Development Tools' not installed the
gcc-c++ compiler.
Regards,
Helio
2013/7/24 Helio Frota heliofr...@gmail.com
Ok
Hi,
Another problem:
configure: error: Could not find all X11 headers (shape.h Xrender.h
XTest.h). You might be able to fix this by running 'sudo yum install
libXtst-devel'.
configure exiting with result code 1
I did this, but the error persists.
Going to investigate...
Regards,
Helio
Hi,
Please add the message:
You might be able to fix this by running 'sudo yum install
libXrender-devel'.
sudo yum install libXrender-devel
Because shape.h Xrender.h XTest.h are not installed with sudo yum install
libXtst-devel
Regards,
Helio
2013/7/24 Helio Frota heliofr...@gmail.com
On 07/24/2013 03:44 PM, Helio Frota wrote:
Hi,
Another problem:
configure: error: Could not find all X11 headers (shape.h Xrender.h
XTest.h). You might be able to fix this by running 'sudo yum install
libXtst-devel'.
configure exiting with result code 1
I did this, but the error
Hi,
Configure ok
A new configuration has been successfully created in
/home/hf/adopt_openjdk/openjdk8/build/linux-x86-normal-server-release
using default settings.
Configuration summary:
* Debug level:release
* JDK variant:normal
*
Sorry, its me again.
I get the configure error:
configure: error: Could not find freetype2! You might be able to fix this
by running 'sudo yum install freetype2-devel'.
configure exiting with result code 1
But after run the command:
sudo yum install freetype2-devel
Fedora 19 appears not to have
Hi,
I got the same problem with GCC 4.8.1 and Manjaro distribution ( distro son
of archlinux )
Generating precompiled header precompiled.hpp.gch
cc1plus: error: the stabs debug format cannot be used with pre-compiled
headers [-Werror=deprecated]
cc1plus: all warnings being treated as errors
On 07/24/2013 04:11 PM, Helio Frota wrote:
Hi,
I got the same problem with GCC 4.8.1 and Manjaro distribution ( distro
son of archlinux )
Generating precompiled header precompiled.hpp.gch
cc1plus: error: the stabs debug format cannot be used with
pre-compiled headers [-Werror=deprecated]
I suspect the reason this was done is because the stream is actually a
ChannelInputStream. If you don't do the 1-byte array thing, the
ChannelInputStream will construct an entire ByteBuffer to read into,
which is even worse. As it is, it'll create a wrapper ByteBuffer to
encapsulate the
It looks like under the covers the ChannelInputStream uses a 1-byte buffer
but caches it and re-uses it. That's slightly better than allocating a
new one every time.
Also, I don't see much difference between the original use (before the
Alan's previous change)
of Files.newInputStream(path)
Hi Omair,
Thanks for the tips !
About freetype:
Just change to sudo yum install freetype-devel
This solve the problem..
Going to validate the alsa now...
Regards,
Helio
2013/7/24 Omair Majid oma...@redhat.com
On 07/24/2013 03:44 PM, Helio Frota wrote:
Hi,
Another problem:
Yes, and there should be. I will open an issue.
Mike
On Jul 23 2013, at 17:26 , Alan Bateman wrote:
On 22/07/2013 12:24, Mike Duigou wrote:
Hello all;
A simple rewiew for the addition of another constructor to PriorityQueue.
Currently if you wish to specify a Comparator you must also
Changeset: f9224fb49890
Author:juh
Date: 2013-07-24 12:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9224fb49890
8016916: UnstructuredName should support DirectoryString
Reviewed-by: mullan
! src/share/classes/sun/security/pkcs/PKCS9Attribute.java
!
Hi Omair,
The only problem is that modern gcc versions don't produce stabs either.
Try:
$ make DEBUG_BINARIES=true all
Thanks for the tip !
I will try again tomorrow on job (fedora19) machine.
Regards,
Helio
2013/7/24 Omair Majid oma...@redhat.com
On 07/24/2013 04:11 PM, Helio Frota
Yes, you're right, I read this wrong. I agree with Martin then that the
nullary read method is a better choice.
On 07/24/2013 03:49 PM, roger riggs wrote:
It looks like under the covers the ChannelInputStream uses a 1-byte buffer
but caches it and re-uses it. That's slightly better than
Changeset: fd1b5adcfdf0
Author:chegar
Date: 2013-07-24 22:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd1b5adcfdf0
8021261: ProblemList.txt updates (7/2013)
Reviewed-by: alanb, mcimadamore
! test/ProblemList.txt
Hello Roger!
On 25.07.2013 0:49, roger riggs wrote:
It looks like under the covers the ChannelInputStream uses a 1-byte
buffer
but caches it and re-uses it. That's slightly better than allocating
a new one every time.
Thanks, I'll change it.
Also, I don't see much difference between the
Hello Martin!
On 24.07.2013 23:36, Martin Buchholz wrote:
Use javadoc style even in private methods.
s/Read/Reads/
Use @param initialSize
/**
+ * Read all the bytes from an input stream. The {@code initialSize}
+ * parameter indicates the initial size of the byte[] to allocate.
+
Hello everybody!
Would you please review an updated webrev?
http://cr.openjdk.java.net/~igerasim/8020669/3/webrev/
http://cr.openjdk.java.net/%7Eigerasim/8020669/3/webrev/
Thanks in advance,
Ivan
On 24.07.2013 23:36, Martin Buchholz wrote:
Use javadoc style even in private methods.
JDK 8 Reviewers:
This review request concerns the issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6378503
for which the proposed webrev is
http://cr.openjdk.java.net/~bpb/6378503/
The fix consists in preventing overflowing the int type in certain places. The
added test case is
Changeset: 2fbe77c38802
Author:jjg
Date: 2013-07-24 17:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fbe77c38802
8020556: doclint does not check type variables for @throws
Reviewed-by: mcimadamore
! src/share/classes/com/sun/source/util/DocTrees.java
!
Hi Brian,
I took a look through the code and I don't see how sdiff ==
Integer.MIN_VALUE is handled.
In any case, as long as the runtimes and memory usage are tractable, the
set of test cases should be augmented to include sdiff ==
Integer.MIN_VALUE and (long)Integer.MIN_VALUE + 1, etc.
Changeset: 8b97fe2b7c98
Author:attila
Date: 2013-07-23 18:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8b97fe2b7c98
8021129: Use public lookup again
Reviewed-by: lagergren, sundar
! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java
!
On 24/07/2013 11:07 PM, Daniel Fuchs wrote:
Hi David,
On 7/24/13 1:48 PM, David Holmes wrote:
On 23/07/2013 11:08 PM, Daniel Fuchs wrote:
Hi,
Please find below a changeset for fixing
8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is
failing intermittently [1]
This
44 matches
Mail list logo
