Hi,
Please help to review the fix below for bug
https://jbs.oracle.com/bugs/browse/JDK-8022879
http://cr.openjdk.java.net/~ewang/8022879/webrev.00/
The test has defect as it wouldn't be executed if the file.encoding is
UTF-8 (lots of test machines in nightly are UTF-8), it also doesn't
Changeset: a6378c19836b
Author:vromero
Date: 2013-08-16 10:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6378c19836b
8022053: javac generates unverifiable initializer for nested subclass of local
class
Reviewed-by: jjg, mcimadamore
!
There is an update syncing JAX-WS sources in jdk8/tl/jaxws to most
recent development version.
It is quite big changeset (13k+ LOC changed) and includes several bug fixes:
http://java.net/jira/browse/JAX_WS-1114 problem sending XML primitive
type gMonth (the request ends up null on server)
Hi,
This patch fixes a compilation failure in the stream-based tests:
diff -r 5649837a4cfa
test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java
---
a/test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java
Mon Aug 12 12:06:50 2013 -0400
I see no objections to this, and I think it has been through enough
review. I'll sponsor this change for Aleksej.
-Chris.
On 13/08/2013 10:20, Aleksej Efimov wrote:
Stuart,
Thanks for your comments.
New webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.03/
On 16/08/2013 11:27, Paul Sandoz wrote:
Hi,
This patch fixes a compilation failure in the stream-based tests:
diff -r 5649837a4cfa
test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java
---
On 12/08/2013 17:02, Ivan Gerasimov wrote:
Hello everybody!
Would you please help review a small change to File.mkdirs() method?
The current implementation of the method, when past an argument
dir1/../dir2 only tries to create dir2.
mkdir -p 'dir1/../dir2' command on Linux creates both dir1
On 16/08/2013 11:15, Miroslav Kos wrote:
There is an update syncing JAX-WS sources in jdk8/tl/jaxws to most
recent development version.
It is quite big changeset (13k+ LOC changed) and includes several bug
fixes:
http://java.net/jira/browse/JAX_WS-1114 problem sending XML primitive
type
Changeset: 5fe19566b6f0
Author:psandoz
Date: 2013-08-16 12:29 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5fe19566b6f0
8023150: java/util/stream tests no longer compiling following JDK-8019401
Reviewed-by: alanb
!
Changeset: 2eebaff52a94
Author:psandoz
Date: 2013-08-16 12:46 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2eebaff52a94
8012940: More than 50 tests failed in Serialization/DeSerialization testing
(test-mangled)
Reviewed-by: ksrini
+
Changeset: ec77c7b46c37
Author:jlahoda
Date: 2013-08-15 22:33 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec77c7b46c37
8015809: More user friendly compile-time errors for uncaught exceptions in
lambda expression
Summary: Producing individual errors for uncaught
Changeset: 737b6c298d81
Author:psandoz
Date: 2013-08-13 11:16 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/737b6c298d81
8022797: Clarify spliterator characteristics for collections containing no
elements
Reviewed-by: alanb, mduigou
!
Thanks for getting these in.
Stephen
On 10 August 2013 02:26, Mike Duigou mike.dui...@oracle.com wrote:
Looks good to me. I am glad we were able to get this back into Java 8.
Mike
On Aug 9 2013, at 17:39 , Brian Burkhalter wrote:
Please review at your convenience:
Issue
Hi
Please review this small fix for a type annotation reflection issue.
The javadoc spec for Class.getAnnotatedSuperclass says:
* If this Class represents either the Object class, an interface type, an
* array type, a primitive type, or void, the return value is null.
The patch fixes this.
On 16/08/2013 11:37, Alan Bateman wrote:
On 16/08/2013 11:27, Paul Sandoz wrote:
Hi,
This patch fixes a compilation failure in the stream-based tests:
diff -r 5649837a4cfa
test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java
---
Looks ok to me.
-Chris.
On 12/08/2013 13:22, Paul Sandoz wrote:
Hi,
The following patch updates documentation for various spliterators in the
j.u.concurrent package:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8022318-concurrent-split-docs/webrev/
This syncs from the 166 repo and the
It looks OK for me,
Vicente
On 16/08/13 13:17, Joel Borggren-Franck wrote:
Hi
Please review this small fix for a type annotation reflection issue.
The javadoc spec for Class.getAnnotatedSuperclass says:
* If this Class represents either the Object class, an interface type, an
* array
Hello everybody!
It was reported that BufferedInputStream#read() method may throw
NegativeArraySizeException.
This is due to doubling the buffer size in the fill() method without
checking for a possible overflow.
BUG: http://bugs.sun.com/view_bug.do?bug_id=7129312
Affected versions of jdk
Changeset: 4300c2f5fb1b
Author:erikj
Date: 2013-08-16 16:00 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4300c2f5fb1b
8023146: Sjavac test failes in langtools nightly
Reviewed-by: mcimadamore, jfranck
! test/tools/sjavac/SJavac.java
On Aug 16, 2013, at 3:45 PM, Martin Buchholz marti...@google.com wrote:
Thanks, Paul.
I made a mistake with the anchor name in package-info.java.
s/WeaklyConsistent/Weakly/
Fix is already in latest jsr166. Resync package-info.java.
Thanks, i caught that one and updated my patch.
Else
On Aug 16, 2013, at 4:22 PM, Martin Buchholz marti...@google.com wrote:
On Fri, Aug 16, 2013 at 7:02 AM, Paul Sandoz paul.san...@oracle.com wrote:
On Aug 16, 2013, at 3:45 PM, Martin Buchholz marti...@google.com wrote:
Thanks, Paul.
I made a mistake with the anchor name in
Chris,
Thank you for review and for sponsorship.
I have prepared hg changeset patches for root and jdk repositories:
root repo patch: http://cr.openjdk.java.net/~aefimov/8021820/jdk8_hg.export
jdk repo patch:
http://cr.openjdk.java.net/~aefimov/8021820/jdk_jdk8_hg.export
I think if there is no
Sorry, the webrev happened to be empty.
Here's the full one:
http://cr.openjdk.java.net/~igerasim/7129312/1/webrev/
http://cr.openjdk.java.net/%7Eigerasim/7129312/1/webrev/
Sincerely yours,
Ivan
On 16.08.2013 17:12, Ivan Gerasimov wrote:
Hello everybody!
It was reported that
Looks good.
-Sherman
On 08/14/2013 12:48 PM, roger riggs wrote:
The issue 8019185: Inconsistency between JapaneseEra start dates and
java.util.JapaneseImperialDate
Observes a minor discrepancy between the java.util.Calendar Japanese
implementation
and the java.time JapaneseEra.
This fix
Changeset: 53819fd0ab61
Author:rriggs
Date: 2013-08-16 11:28 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53819fd0ab61
8022770: java/time/tck/java/time/chrono/TCKChronology.java start failing
8022766: java/time/test/java/time/chrono/TestUmmAlQuraChronology.java failed.
Changeset: acaa256e3f7c
Author:rriggs
Date: 2013-08-16 13:58 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/acaa256e3f7c
8019185: Inconsistency between JapaneseEra start dates and
java.util.JapaneseImperialDate
Summary: align Meiji start date with lib/calendar.properties to
Hi, Aleksej, thanks for the update. The latest version looks good.
Chris, thanks for sponsoring this change.
s'marks
On 8/16/13 7:51 AM, Aleksej Efimov wrote:
Chris,
Thank you for review and for sponsorship.
I have prepared hg changeset patches for root and jdk repositories:
root repo
On 08/16/2013 03:40 AM, Alan Bateman wrote:
On 12/08/2013 17:02, Ivan Gerasimov wrote:
Hello everybody!
Would you please help review a small change to File.mkdirs() method?
The current implementation of the method, when past an argument
dir1/../dir2 only tries to create dir2.
mkdir -p
Thanks Dan!
Yes, the old version of the test somehow crept into the webrev. Sorry
about that!
Of course if was meant to include the check of os.name
http://cr.openjdk.java.net/~igerasim/6883354/1/webrev/
http://cr.openjdk.java.net/%7Eigerasim/6883354/1/webrev/
The idea was to make the
On 8/14/13 3:34 AM, Paul Sandoz wrote:
If no one else volunteers i can try and sort this out and sync up
stuff from the current HashMap/LinkedHashMap (e.g. forEachRem. as
reported by Remi) and the lint warnings in one go, and submit for
review.
That would be great, Paul.
One thing on my
I noticed this method is not listed in the Javadocs for 5/6/7/8 but it's
part of every enum. Is this an oversight or is there a good reason why it's
not documented?
--
Cheers,
Paul
That method doesn't exist in the actual java.lang.Enum base class. It gets
generated automatically when the enum is compiled and is part of the compiled
enum class, not part of the Enum base class.
With that said, I don't disagree that it could use some documentation. I've
often wondered why
Oh, yea. Duh. I completely forgot about it being static, which of course it
would HAVE to be to be useful. Silly me.
Maybe there's a new language feature in there somewhere. Abstract static
methods? ;-)
Still, yes. I would recommend that the JavaDoc for the Enum class list the
signature and
The valueOf method in Enum subclasses is static, so Enum itself can't
usefully declare it. But the description of the Enum class could say
in text what the generated methods are, rather than referring the
reader to the JLS without even a link. If you forget what the methods
are you can always look
34 matches
Mail list logo
