On 09/09/2013 09:42 PM, roger riggs wrote:
Hi Peter,
Right, max doesn't solve the issue but I'm not keen on a test that
retries
until it gets a better answer.
Hi Roger,
If java.time logic is correct, it should only ever retry once when
roll-over or DST jump-back happens, so the test could
Changeset: 909aced59bef
Author:alanb
Date: 2013-09-10 10:42 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/909aced59bef
8023878: (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java
fails intermittently
Reviewed-by: alanb
Contributed-by: yiming.w...@oracle.com
In SunCommandLineLauncher.java:
198 if (home.length() 0) {
199 String os_arch = System.getProperty(os.arch);
200 if (SunOS.equals(System.getProperty(os.name))) {
201 exePath = home + File.separator + bin +
File.separator + exe;
Changeset: bb7271e64ef6
Author:jfranck
Date: 2013-09-10 13:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb7271e64ef6
8005222: Fixed bugs should have tests with bugid in @bug tag
Reviewed-by: jfranck, jjg
Contributed-by: Andreas Lundblad andreas.lundb...@oracle.com
On 06/09/2013 04:23, mark.reinh...@oracle.com wrote:
:
Well, looking ahead to when the platform will be composed of modules,
those modules will declare that they export some API elements, but
not others. An @Exported annotation would help get people used to
the expected future terminology.
A new webrev has been posted, with some improvements to the comment.
On 09/09/13 17:41, Eric McCorkle wrote:
Hello,
Please review this patch which updates the javadoc comments for
java.lang.reflect.Executable.getParameterAnnotations(). The patch
corrects the javadocs to describe the actual
Hi Peter,
Point taken about the edge cases, I'm not sure it will occur in practice
but I updated the test to retry if the time changes by more than 15 minutes.
There are likely to be other existing tests that do not taken into account
DST changes but it is not a high priority now to find and fix
On 09/09/2013 14:35, Paul Sandoz wrote:
On Sep 6, 2013, at 4:56 PM, Alan Batemanalan.bate...@oracle.com wrote:
:
The comments are very educational as the resizing is difficult to completely
grok without going through examples on a whiteboard. Anyway, I don't see
anything obviously wrong
Hi Roger,
Sorry to be persistent, but if the LocalTime.now() returns local time
for a time zone that is not the default time zone (which is an error in
java.time implementation that I assume the test is trying to catch) then
the diff can be a constant 15 minutes and the loop will roll
Hi all,
this is the JDK part of the fix for 8014659 [0]. I've added the output
of the compressed class space performance counters next to the metaspace
output. I've also updated the jstat and jstatd tests to take the new
output into account.
Webrev:
Changeset: d87f017ec217
Author:mcimadamore
Date: 2013-09-10 16:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d87f017ec217
8024414: javac, should facilitate the use of the bootstrap compiler for
debugging
Reviewed-by: jjg
! make/netbeans/langtools/build.xml
!
On 9/10/2013 6:28 AM, Alan Bateman wrote:
On 06/09/2013 04:23, mark.reinh...@oracle.com wrote:
:
Well, looking ahead to when the platform will be composed of modules,
those modules will declare that they export some API elements, but
not others. An @Exported annotation would help get people
On 09/10/2013 11:54 AM, Mandy Chung wrote:
On 9/10/13 9:47 AM, Joe Darcy wrote:
On 9/10/2013 6:28 AM, Alan Bateman wrote:
On 06/09/2013 04:23, mark.reinh...@oracle.com wrote:
:
Well, looking ahead to when the platform will be composed of modules,
those modules will declare that they export
On 9/10/13 9:47 AM, Joe Darcy wrote:
On 9/10/2013 6:28 AM, Alan Bateman wrote:
On 06/09/2013 04:23, mark.reinh...@oracle.com wrote:
:
Well, looking ahead to when the platform will be composed of modules,
those modules will declare that they export some API elements, but
not others. An
This isn't every other platform, this is Mac OS X and all the baggage that
goes along with it! :)
What do you actually need access to user.home for? Do you have empirical
evidence that this will break your application?
The whole point of sandboxing is you no longer have direct access
Hi Eric,
Looks good, modulo some typos:
434 * this object. Synthetic and mandated parameters (see
435 * explanation below), such as the inner this parameter to an
Inner class constructors have an *outer* this parameter.
437 * array. If the executable has no parameters
This isn't every other platform, this is Mac OS X and all the baggage that goes
along with it! :)
What do you actually need access to user.home for? Do you have empirical
evidence that this will break your application?
The whole point of sandboxing is you no longer have direct access to the
Hi Peter,
Love those pathological edge cases...
On 9/10/2013 12:18 PM, Peter Levart wrote:
Hi Roger,
Sorry to be persistent, but if the LocalTime.now() returns local time
for a time zone that is not the default time zone (which is an error
in java.time implementation that I assume the test
http://cr.openjdk.java.net/~mduigou/JDK-8024291/0/webrev/
I'm still mildly opposed.
The main uncompellingness
is that removeIf is a more descriptive name than removeAll.
The method currently called removeIf is like an atom with one valence
electron, searching for a pattern to bond with;
Please review at your convenience.
Issue: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8024356
Webrev: http://cr.openjdk.java.net/~bpb/8024356/
Thanks,
Brian
On 9/10/2013 10:08 AM, David M. Lloyd wrote:
On 09/10/2013 11:54 AM, Mandy Chung wrote:
On 9/10/13 9:47 AM, Joe Darcy wrote:
On 9/10/2013 6:28 AM, Alan Bateman wrote:
On 06/09/2013 04:23, mark.reinh...@oracle.com wrote:
:
Well, looking ahead to when the platform will be composed of modules,
I use user.home to do things like:
String userHomePath = System.getProperty(user.home);
myFileDialog.setDirectory(userHomePath + /Documents);
This will continue to work fine. Like I said, user.home is the Data directory
inside the app container which is a shadow of the users home folder,
Here are the updated changes:
The build changes are here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/
the delta changes since last reviewed:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev.delta/index.html
The jdk changes are here:
Adding a little to what Dave said, based on my understanding...
On 9/10/13 3:36 PM, David DeHaven wrote:
Nicholas Rahn wrote:
In my app, the user selects where he wants to export individual
files, such as CSVs and PDFs. These are files he'll use outside of
my app.
If user.home points to the
Hello,
Sending along some responses to these questions from Alex:
On 8/25/2013 7:03 AM, Kasper Nielsen wrote:
Hi,
just 2 short questions/commons on java.lang.reflect.Parameter
1)
I was wondering if there is any reason for java.lang.reflect.Parameter not
to expose the index field?
Not sure
On 11/09/2013 8:00 AM, Kumar Srinivasan wrote:
Here are the updated changes:
Looks okay to me.
David
The build changes are here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/
the delta changes since last reviewed:
On 09/10/2013 06:26 PM, Joseph Darcy wrote:
On 9/10/2013 10:08 AM, David M. Lloyd wrote:
On 09/10/2013 11:54 AM, Mandy Chung wrote:
On 9/10/13 9:47 AM, Joe Darcy wrote:
On 9/10/2013 6:28 AM, Alan Bateman wrote:
On 06/09/2013 04:23, mark.reinh...@oracle.com wrote:
:
Well, looking ahead to
Hi,
Please review a simple webrev that adds two tests, one for
java.util.function.BiFunction.andThen() another to cover
java.util.Collections.SingletonIterator.
Cheers,
Henry
Changeset: c9083205e6eb
Author:xuelei
Date: 2013-09-10 21:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9083205e6eb
8024501: sun.security.mscapi.Key has no definition of serialVersionUID
Reviewed-by: weijun
! src/windows/classes/sun/security/mscapi/Key.java
Sorry I forgot it again. Copied but not pasted. :(
http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/
Thanks for reviewing.
Cheers,
Henry
On Sep 10, 2013, at 8:47 PM, Henry Jen henry@oracle.com wrote:
Hi,
Please review a simple webrev that adds two tests, one for
30 matches
Mail list logo
