Changeset: 13ee370ee8b3
Author:okutsu
Date: 2013-09-11 15:29 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13ee370ee8b3
8024141: Unexpected timezone display name
Reviewed-by: peytoia
! src/share/classes/sun/util/locale/provider/LocaleResources.java
+
Changeset: b271ea30f440
Author:jfranck
Date: 2013-09-11 09:45 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b271ea30f440
4987375: (reflect) Class.get{Declared}Method{s} does not return clone() for
array types
Summary: Update spec to match long standing behavior
On 2013-09-09, Remi Forax wrote:
On 09/09/2013 07:27 PM, Joel Borggrén-Franck wrote:
On 9 sep 2013, at 19:00, Joel Borggrén-Franck joel.fra...@oracle.com wrote:
The issue is that since we added static methods to interfaces those have
erroneously been reflected in getMethods of implementing
Changeset: 517c5e99fb2f
Author:chegar
Date: 2013-09-11 11:03 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/517c5e99fb2f
8024508: Fix doclint issues in com.sun.nio.sctp
Reviewed-by: alanb
! src/share/classes/com/sun/nio/sctp/Association.java
!
On 11/09/2013 03:50, David M. Lloyd wrote:
I'm aware of that; however I guarantee you that if you try to munge
this functionality up with the concept of exported classes or packages
before the module system is realized, it's going to end up wrong and
we'll have yet more dead cruft in the
Changeset: d389dedd1ccb
Author:chegar
Date: 2013-09-11 11:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d389dedd1ccb
8023090: Additional debug info for java/net/NetworkInterface/Equals.java
Reviewed-by: alanb
! test/java/net/NetworkInterface/Equals.java
On 2013-09-11 00:00, Kumar Srinivasan wrote:
Here are the updated changes:
The build changes are here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/
the delta changes since last reviewed:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev.delta/index.html
The jdk
Changeset: 65c218b25b61
Author:emc
Date: 2013-09-11 08:30 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/65c218b25b61
8024510: lib/combo/tools/javac/combo/TemplateTest.java fails
Summary: Edit regex in Template to allow MAJOR. pattern.
Reviewed-by: briangoetz
!
Changeset: 7bfe3da4fad6
Author:naoto
Date: 2013-09-11 05:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bfe3da4fad6
8024332: sun/util/resources/en split between rt.jar and localedata.jar
Reviewed-by: alanb, erikj
! make/java/java/genlocales.gmk
!
Changeset: c3ef78cd9081
Author:emc
Date: 2013-09-11 09:24 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3ef78cd9081
6962494: Update documentation on Executable.getParameterAnnotations()
Summary: Update javadoc comments on getParameterAnnotations to correctly
describe its
[repeat]
new, improved webrev: http://cr.openjdk.java.net/~drchase/8022701/webrev.02/
Same small changes to the sources, plus a test.
bug: wrong exception was thrown in call of methodhandle to private method
fix: detect special case of IllegalAccessException, convert to
IllegalAccessError
On 06/09/2013 20:06, roger riggs wrote:
:
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-serial-8024164/
Javadoc: http://cr.openjdk.java.net/~rriggs/javadoc-serial-8024164/
I looked through the webrev and sampled a few cases in the serialized
form and it looks okay to me.
-Alan.
On 11/09/2013 06:03, Henry Jen wrote:
Sorry I forgot it again. Copied but not pasted. :(
http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/
Thanks for reviewing.
A minor comment but you might want to double check
SingletonIterator.java as it looks a bit misaligned (might be tabs,
Changeset: 292d93f32aa1
Author:rriggs
Date: 2013-09-11 10:16 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/292d93f32aa1
8024164: JSR310 serialization should be described in details
Summary: The serialized-form.html should specify the stream format for
interoperability
Yes, the alignment is off, will fix.
Cheers,
Henry
On Sep 11, 2013, at 7:36 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 11/09/2013 06:03, Henry Jen wrote:
Sorry I forgot it again. Copied but not pasted. :(
http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/
Thanks for
Thanks, it should be deliver. I'll fix before push it.
Cheers,
Henry
On Sep 10, 2013, at 10:19 PM, Mike Duigou mike.dui...@oracle.com wrote:
Tests look fine.
In the BiFunction test the unknown word delieve is used. I am not sure what
word was intended.
Mike
On Sep 10 2013, at 22:03
Please review the webrev at:
http://cr.openjdk.java.net/~skuksenko/jsr335/8024630/webrev.00/
LambdaMetafactory is is a quite frequent bootstrap method for
invokedynamic in JDK8.
We can do direct method (LambdaMetafactory) invocation as fastpath when
proved that bootstrap MethodHandle points to
Please review the webrev at:
http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.00/
MethodType.toMethodDescriptorString() is frequently invoked when
generating lambda classes from InnerClassLambdaMetafactory.
Caching resulting string into the field of MethodType gives +5% - +10%
to
Seems like a good trick.
On 09/11/2013 08:23 PM, Sergey Kuksenko wrote:
http://cr.openjdk.java.net/~skuksenko/jsr335/8024630/webrev.00/
* webrev metadata: invokation - invocation
* Why $caller is MethodHandles.Lookup now? Is it known to have that type?
* I would put the entire LMF.metafactory
Hi,
The background of this bug is the anti-pattern of defining constants in
interfaces. In this case all the
constants defined in package private interface ZipConstants are being exposed
as public fields of the
classes that implements it. This is JDK 1.0 era design/implementation,
something
On 09/11/2013 08:23 PM, Sergey Kuksenko wrote:
http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.00/
As much as I hate to see the hand code tweaking instead of relying on
compiler to do it's job, I understand this is about interpreter. Seems
good then.
* Formatting: if(...) should be
On 09/11/2013 08:23 PM, Sergey Kuksenko wrote:
http://cr.openjdk.java.net/~skuksenko/jsr335/8024630/webrev.00/
* webrev metadata: invokation - invocation
misprint. Should I fix it right now, or may it be done later?
* Why $caller is MethodHandles.Lookup now? Is it known to have that type?
On 09/11/2013 08:53 PM, Sergey Kuksenko wrote:
On 09/11/2013 08:23 PM, Sergey Kuksenko wrote:
http://cr.openjdk.java.net/~skuksenko/jsr335/8024630/webrev.00/
* webrev metadata: invokation - invocation
misprint. Should I fix it right now, or may it be done later?
I think later is good. Don't
Changeset: 60b4cbdb446d
Author:sherman
Date: 2013-09-11 11:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60b4cbdb446d
8024338: Constant fields introduced by JDK-4759491 fix in b94 are exposed as
public fields in public API
Summary: to move the new constants out of
Hi,
Please find below a changeset for a small logging RFE:
8024525 - Make Logger log methods call isLoggable()
http://cr.openjdk.java.net/~dfuchs/webrev_8024525/webrev.00/
This change makes the various Logger logging method call isLoggable()
instead of simply inlining the checks.
This should
If you're saying that NSHomeDirectory is the correct behaviour for the Java
user.home property, then I have to disagree. On every other platform,
including non-sandboxed Mac, user.home is the actual user's home directory
(i.e. /home/user or /Users/user or C:\Users\user). Setting user.home
to the
I use user.home to do things like:
String userHomePath = System.getProperty(user.home**);
myFileDialog.setDirectory(**userHomePath + /Documents);
In my app, the user selects where he wants to export individual files, such
as CSVs and PDFs. These are files he'll use outside of my app.
If
Changeset: 70aab3db56de
Author:henryjen
Date: 2013-09-11 11:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70aab3db56de
8024500: Missing API coverage for java.util.function.BiFunction andThen
Reviewed-by: mduigou, alanb
+ test/java/util/Collections/SingletonIterator.java
Yes, this is a good tactic, but as written it is too much of a point hack for
lambdas (important though they are).
I have an alternate solution I would like you to measure. It provides a fast
path for other BSM lookups like Nashorn's, so (if it works well for lambda) it
is preferable.
I will
Thanks everyone for the reviews and suggestions for improvements.
cheers
/Joel
On Sep 4, 2013, at 3:55 PM, Joel Borggren-Franck joel.fra...@oracle.com wrote:
Hi,
Please review fix for: http://bugs.sun.com/view_bug.do?bug_id=4987375
Webrev:
In my app, I have an export dialog where the user can select the file to
export as well as choose some other export options. In that dialog, after
the user has selected the file to export (via the file selection dialog), I
display the full path to the file that was returned from the file
In my app, I have an export dialog where the user can select the file to
export as well as choose some other export options. In that dialog, after
the user has selected the file to export (via the file selection dialog), I
display the full path to the file that was returned from the file selection
On 09/11/2013 09:01 PM, Aleksey Shipilev wrote:
On 09/11/2013 08:23 PM, Sergey Kuksenko wrote:
http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.00/
As much as I hate to see the hand code tweaking instead of relying on
compiler to do it's job, I understand this is about
Changeset: cf37c3775397
Author:bpatel
Date: 2013-09-11 14:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cf37c3775397
8015496: Information that package is deprecated is missing in profiles view
Reviewed-by: jjg
!
On 9/11/13 11:09 AM, Nicholas Rahn wrote:
On David DeHaven wrote:
In my app, I have an export dialog where the user can select the
file to export as well as choose some other export options. In
that dialog, after the user has selected the file to export (via
the file selection dialog), I
The bottom line is, if what you have now allows you to write to
~/Documents and you're sandboxed then this change should not
affect your application at all, except maybe in the UI if you're
displaying that path to the user. The user won't notice the
difference otherwise.
My users *will*
Please review my fix to remove the jdk.map.useRandomSeed system property
added earlier in jdk8.
Some history is in the bug report,
http://bugs.sun.com/view_bug.do?bug_id=8024009
HashMap and LinkedHashMap stopped using the random hash seed as of
8023463. This change removes the code to read
Hi Brent;
Thanks for cleaning this up. The changes look fine.
(A simplifying change in Collections, how unexpected!)
Mike
On Sep 11 2013, at 17:13 , Brent Christian wrote:
Please review my fix to remove the jdk.map.useRandomSeed system property
added earlier in jdk8.
Some history is in
HijrahChronology mixes final transient and transient final. They
should be consistently one way or the other files should be checked,
and I think there is an official coding standard for this).
Some classes have had transient added, while others haven't. For
example LocalDate doesn't use
On Sep 11 2013, at 17:56 , Stephen Colebourne wrote:
HijrahChronology mixes final transient and transient final. They
should be consistently one way or the other files should be checked,
and I think there is an official coding standard for this).
The resource I have been quoted for the
On 9/11/2013 10:59 AM, Daniel Fuchs wrote:
Hi,
Please find below a changeset for a small logging RFE:
8024525 - Make Logger log methods call isLoggable()
http://cr.openjdk.java.net/~dfuchs/webrev_8024525/webrev.00/
Looks good.
...
The test is a bit obscure but it calls all the methods
The short answer: because it is a backport to JDK 7 of part of this JDK 8
change:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017958.html
The long answer is the theory behind the change.
Java conversion from decimal string to double is specified as if it happens
in two steps:
42 matches
Mail list logo
