Hi Mike,
I am probably going over old ground here...
Given that there is ConcurrentMap is there any point in having the defaults on
Map detect concurrent modification and barf, or retry, or neither of the
previous two e.g. putIfAbsent, computeIfPresent and replace respectively i.e.
there
On 10/07/2013 10:03 PM, Brian Burkhalter wrote:
On Oct 7, 2013, at 1:43 PM, Brian Burkhalter wrote:
On second thought an exception really should be thrown on negative size; will
update.
http://cr.openjdk.java.net/~bpb/8016252.2/ updated including a
not-very-exciting and perhaps unnecessary
On 10/08/2013 06:04 AM, Mandy Chung wrote:
On 10/7/2013 9:45 PM, David Holmes wrote:
Hi Mandy,
Note that unless you push both hotspot and jdk changes through the
same forest you will need separate bugs for each part. You will also
need a HSX committer to do the hotspot push.
I do plan to
On 8/10/2013 7:18 PM, Chris Hegarty wrote:
On 10/08/2013 06:04 AM, Mandy Chung wrote:
On 10/7/2013 9:45 PM, David Holmes wrote:
Hi Mandy,
Note that unless you push both hotspot and jdk changes through the
same forest you will need separate bugs for each part. You will also
need a HSX
On 08/10/2013 00:00, Brian Burkhalter wrote:
Resuming this discussion …
Thanks for the previous comments. My feeling at this point is to do one of two
things:
A) defer to something after JDK 8, or
B) on EAI_AGAIN do not retry but set the cause of the UAE to new
Hi Gili,
the mail threads you mention in your mail refer to debugging symbols in the
native VM implementation (i.e. libjvm.so) and not to debug symbols in the
java classes in rt.jar.
Regards,
Volker
On Mon, Oct 7, 2013 at 7:45 PM, cowwoc cow...@bbs.darktech.org wrote:
On 07/10/2013 1:35 PM,
Changeset: b90dcd1a71bf
Author:psandoz
Date: 2013-10-08 11:17 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b90dcd1a71bf
8025136: SplittableRandom enchancements
Reviewed-by: psandoz, martin
Contributed-by: Doug Lea d...@cs.oswego.edu, Guy Steele
guy.ste...@oracle.com
!
On 04/10/2013 21:58, Brian Burkhalter wrote:
:
An updated webrev which I hope adequately addresses the expressed concerns may
be found at:
http://cr.openjdk.java.net/~bpb/7179567.2/
This looks much better.
If I read the code correctly then the long standing behavior of
Changeset: 95bb56c61276
Author:alanb
Date: 2013-10-08 10:49 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95bb56c61276
8024788: (fs) Files.readAllBytes uses FileChannel which may not be supported by
all providers
Reviewed-by: chegar
!
Alan, Rob, Martin,
Would you please help review the backport? I see you were the reviewers
for the master fix.
I need a review for the backport, since the patch couldn't get applied
cleanly.
Here are the changes I had to make:
- I had to manually replace Java_java_lang_ProcessImpl_create()
Hi,
The following patch is a minor clarification to the documentation of
Spliterator.characteristics():
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/653d17f35169
Paul.
--- a/src/share/classes/java/util/Spliterator.java Tue Oct 01 12:10:04
2013 +0200
+++
Sorry Paul, I know the apiNote says for examples see ... but would you
mind providing an example. I'm scratching my head.
-Chris.
On 10/08/2013 12:42 PM, Paul Sandoz wrote:
Hi,
The following patch is a minor clarification to the documentation of
Spliterator.characteristics():
On Oct 8, 2013, at 3:02 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Sorry Paul, I know the apiNote says for examples see ... but would you mind
providing an example. I'm scratching my head.
* @apiNote Most Spliterators for Collections, that cover all elements of a
* {@code
Hi,
Please review the fix for bug JDK-7183985, bug:
https://bugs.openjdk.java.net/browse/JDK-7183985
webrev:
http://cr.openjdk.java.net/~jlahoda/7183985/webrev.00/
The problem, as I understand it, is as follows. Consider this code:
-
@WithArray({E.class})
class O {
}
On 10/08/2013 12:36 AM, Peter Levart wrote:
That said, this is a 13 year old issue that hasn't come up very often
(to my knowledge anyway, perhaps because those making heavy use of
direct buffers are pooling buffers rather than allocating and
unreferencing). In additional we are close to the
Hi Volker,
Thanks for the clarification. I have been able to ascertain that
adding full debug symbols to rt.jar would grow the file by 12MB
(uncompressed, probably much smaller after you run PACK200). The
debugging symbols for native code probably cost a lot more than that.
Any idea
Thanks Paul. In which case, the spec clarifications seem fine.
-Chris.
On 10/08/2013 02:10 PM, Paul Sandoz wrote:
On Oct 8, 2013, at 3:02 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Sorry Paul, I know the apiNote says for examples see ... but would you mind
providing an example. I'm
Changeset: 6345d08fd5de
Author:hannesw
Date: 2013-10-08 11:55 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6345d08fd5de
8025213: Assignment marks variable as defined too early
Reviewed-by: jlaskey, lagergren, sundar
! src/jdk/nashorn/internal/codegen/Attr.java
+
On 10/08/2013 12:08 PM, Alan Bateman wrote:
On 04/10/2013 21:58, Brian Burkhalter wrote:
:
An updated webrev which I hope adequately addresses the expressed
concerns may be found at:
http://cr.openjdk.java.net/~bpb/7179567.2/
This looks much better.
Yes, this is much nicer.
I'd be
Changeset: dbecbb685503
Author:mfang
Date: 2013-10-08 09:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/dbecbb685503
8025215: jdk8 l10n resource file translation update 4
Reviewed-by: joehw, yhuang
! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java
!
Hi,
Please find below a fix for:
8024704: Improve API documentation of ClassLoader and ServiceLoader
with respect to enumeration of resources.
https://bugs.openjdk.java.net/browse/JDK-8024704
This is a clarification of the implementation of the
ServiceLoader.iterator() method, as well
Alex clarified the difference between FULL_DEBUG_SYMBOLS and
DEBUG_CLASSFILES below (thank you!)
Based upon this, I am asking Oracle to ship DEBUG_CLASSFILES=true
as part of the public JDK. Can someone from Oracle please comment on this?
Thanks,
Gili
Original Message
Hi,
This is a backport request towards 7u-dev repository on bug JDK-8025128
that I fixed several days ago. It is going to keep the method,
File.createTempFile(), backward compatible. Please help review it. Thanks!
Bug: https://bugs.openjdk.java.net/browse/JDK-8026061
Webrev:
On 10/8/13 8:17 PM, cowwoc wrote:
Alex clarified the difference between FULL_DEBUG_SYMBOLS and
DEBUG_CLASSFILES below (thank you!)
Based upon this, I am asking Oracle to ship DEBUG_CLASSFILES=true as part
of the public JDK. Can someone from Oracle please comment on this?
Not an
On 08/10/2013 3:25 PM, Dalibor Topic wrote:
On 10/8/13 8:52 PM, cowwoc wrote:
Dalibor,
I don't think anyone from Oracle reads those forums or has the authority
to make this change. Isn't there a better way for me to bring this up?
Well, you could file a bug report instead, if you
Looks fine to me Dan but I'm not a official reviewer.
regards,
Sean.
On 08/10/2013 19:24, Dan Xu wrote:
Hi,
This is a backport request towards 7u-dev repository on bug
JDK-8025128 that I fixed several days ago. It is going to keep the
method, File.createTempFile(), backward compatible.
Alan, Rob, Martin,
Would you please help review the backport? I see you were the reviewers
for the master fix.
I need a review for the backport, since the patch couldn't get applied
cleanly.
Here are the changes I had to make:
- I had to manually replace Java_java_lang_ProcessImpl_create()
On 08/10/2013 19:24, Dan Xu wrote:
Hi,
This is a backport request towards 7u-dev repository on bug
JDK-8025128 that I fixed several days ago. It is going to keep the
method, File.createTempFile(), backward compatible. Please help review
it. Thanks!
Bug:
Yes - no problem pushing the changeset for Dan once the approval request
is logged and approved.
regards,
Sean.
On 08/10/2013 20:43, Alan Bateman wrote:
On 08/10/2013 19:24, Dan Xu wrote:
Hi,
This is a backport request towards 7u-dev repository on bug
JDK-8025128 that I fixed several days
On 07/10/2013 21:36, Peter Levart wrote:
:
Ask not what reference handler can do for you, ask what you can do
for reference handler! ;-)
Indeed.
:
}
I get:
sleep(1) takes 1079078 ns
sleep(2) takes 2058245 ns
sleep(3) takes 3060258 ns
sleep(4) takes 4060121 ns
sleep(5) takes
I've beefed up the test case, as suggested by Alan and Paul. It tries
removing at the start, middle, and end of the iteration.
FWIW, all but one of the test scenarios pass even without the fix. The
failing case is:
checkDescItrRmMid(m.keySet(), m.navigableKeySet().descendingIterator());
On Oct 4, 2013, at 1:33 AM, Paul Sandoz wrote:
On Oct 4, 2013, at 9:18 AM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 10/04/2013 03:34 AM, Brian Burkhalter wrote:
Here is an alternative solution:http://cr.openjdk.java.net/~bpb/7189139.2/.
Seems OK with me,
Same here.
On 08/10/2013 18:19, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8024704: Improve API documentation of ClassLoader and ServiceLoader
with respect to enumeration of resources.
https://bugs.openjdk.java.net/browse/JDK-8024704
This is a clarification of the implementation of
As a mostly ;-) silent observer on this list I just wanted to say Thank
You to everyone for continuing the diligent work to fix issues like this.
I've seen a host of really useful small improvements go in recently (and
docs definitely count as well) - it doesn't go unnoticed!
Cheers,
Martijn
On
The 100 in sample really means a big enough buffer here for simple use case,
not
necessarily means a fixed size' buffer. Sure there is always room for doc
improvement,
especially given this is the API has been there for decade.
Deflater/Inflater.end() is for explicitly/proactively release of
On Oct 8, 2013, at 1:51 AM, Chris Hegarty wrote:
This looks much better.
loadfactor and size validation look good, and in line with the original
suggestion in the bug.
For the initial capacity what was originally suggested was to use a similar
technique to that of HashMap.readObject (
Sean and Alan,
Thanks for the instructions. I just sent out the request to jdk7u-dev
mailing list.
-Dan
On Tue 08 Oct 2013 12:49:08 PM PDT, Seán Coffey wrote:
Yes - no problem pushing the changeset for Dan once the approval
request is logged and approved.
regards,
Sean.
On 08/10/2013
I have posted an updated webrev
http://cr.openjdk.java.net/~bpb/7179567/webrev.3/ which I hope addresses all
the concerns expressed below.
Please see also my comments in line.
Once this looks acceptable I can do the CCC request.
Thanks,
Brian
On Oct 7, 2013, at 9:28 PM, David Holmes wrote:
Changeset: f1e31376f419
Author:robm
Date: 2013-10-09 00:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1e31376f419
7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX
webbugs
Reviewed-by: chegar, dsamersoff
!
On Oct 8 2013, at 01:27 , Paul Sandoz wrote:
Hi Mike,
I am probably going over old ground here...
Not a problem, I don't think this particular aspect has received as much
attention as it probably should
Given that there is ConcurrentMap is there any point in having the defaults
on Map
This fixes Level.parse to return the custom Level instance.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8026027/webrev.00/
When a custom Level is created, a mirrored level instance (containing
the same value as the custom Level) is created and used by the logging
On 10/04/2013 10:30 AM, mark.reinh...@oracle.com wrote:
2013/10/3 16:43 -0700, joe.da...@oracle.com:
Per previous discussions on the mailing list, we've decided to rename
the annotation type jdk.Supported to jdk.Exported.
...
Looks good to me.
One question, though: Is it intended that one
Hello,
Please review the patch below which addresses
JDK-8024354 Explicitly permit DoubleStream.sum()/average()
implementations to use higher precision summation
Thanks,
-Joe
diff -r f1e31376f419
src/share/classes/java/util/DoubleSummaryStatistics.java
---
This seems to contradict the main documentation for these methods. Perhaps
instead we should remove the The average returned can vary depending upon the
order in which values are recorded. This is due to accumulated rounding error
in addition of values of differing magnitudes. Values sorted by
Hello all;
Based upon feedback from the JavaOne Hands-On-Lab and other sources the 335 EG
has decided to rename the two substream methods in the Streams interfaces to
skip and slice.
Webrev:
http://cr.openjdk.java.net/~mduigou/JDK-8025910/0/webrev/
and the specdiff:
Hi,
Please review updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/6/webrev
In this update,
- Check the specified directory once, disable dumping if it is invalid.
This address the comment of unnecessary complexity, as this is a debug
feature and most likely developer would
46 matches
Mail list logo
